Re: [FlexJS, MDL] Layout Problems

2017-02-27 Thread Alex Harui
On 2/27/17, 7:59 AM, "Harbs" wrote: >OK. > >What about @media for JS? > >Would that prevent SWF code from consuming it? I doubt it, but you can try it. > >I do think it’s important to allow specifying any valid css in your MXML >file even if it will not compile to SWF.

Re: [FlexJS, MDL] Layout Problems

2017-02-27 Thread Harbs
OK. What about @media for JS? Would that prevent SWF code from consuming it? I do think it’s important to allow specifying any valid css in your MXML file even if it will not compile to SWF. One of the advantages of FlexJS over “normal” js dev is the ability to have self-contained markup,

Re: [FlexJS, MDL] Layout Problems

2017-02-27 Thread Alex Harui
On 2/27/17, 3:30 AM, "Harbs" wrote: >I don’t need it for SWF. I just want to be able to include valid css in >my app and not have Falcon choke on it. > >I’m not sure I understand why this is related to SimpleCSSValuesImpl. The >calc() should simply be passed through to

Re: [FlexJS, MDL] Layout Problems

2017-02-27 Thread Harbs
I don’t need it for SWF. I just want to be able to include valid css in my app and not have Falcon choke on it. I’m not sure I understand why this is related to SimpleCSSValuesImpl. The calc() should simply be passed through to the css file. Unless you are talking about FlexJS doing something

Re: [FlexJS, MDL] Layout Problems

2017-02-27 Thread Alex Harui
When I fixed this earlier, it was just for the folks who were not using the SWF output. I think recent changes have broken it even for JS output, but I'm wondering if you are expecting this to work for SWF. If so there is a lot more work to be done. IMO, SimpleCSSValuesImpl shouldn't have to

Re: [FlexJS, MDL] Layout Problems

2017-02-26 Thread Harbs
Can someone please look at this? It’s important. Thanks, Harbs > On Feb 22, 2017, at 3:14 PM, Harbs wrote: > > Found it: > https://issues.apache.org/jira/browse/FLEX-35235 > > > I just reopened the issue. > >> On Feb

Re: [FlexJS, MDL] Layout Problems

2017-02-22 Thread Harbs
I’m pretty sure this is not a problem, but I’ll double-check. > On Feb 22, 2017, at 5:12 PM, Carlos Rovira > wrote: > > some-class-selector could remove the slider ones since are not in > typeNames. If this is not happening that would be very good by I'm afraid >

Re: [FlexJS, MDL] Layout Problems

2017-02-22 Thread Harbs
You need a wrapper around the input to set the size as documented on the mdl site. They recommend using , but that introduces a bottom padding. That’s why I used div instead. > On Feb 22, 2017, at 5:12 PM, Carlos Rovira > wrote: > > Hi Harbs, > > the first div

Re: [FlexJS, MDL] Layout Problems

2017-02-22 Thread Carlos Rovira
Hi Harbs, the first div is not in the slider spec, could we get rid of it? if not we'll be introducing output that is not conforming to MDL spec. I look at the changes in typeNames and you should check as well that you are able to add additional class selectors to the Slider, since my

Re: [FlexJS, MDL] Layout Problems

2017-02-22 Thread Harbs
Found it: https://issues.apache.org/jira/browse/FLEX-35235 I just reopened the issue. > On Feb 22, 2017, at 2:30 PM, Harbs wrote: > > Do you have a reference to the JIRA re. clac?

Re: [FlexJS, MDL] Layout Problems

2017-02-22 Thread Harbs
This is the current HTML markup including the FlexJS positioner (with the size set to 100%): Do you have a reference to the JIRA re. clac? > On Feb 22, 2017, at 2:13 PM, Carlos Rovira > wrote: > > Hi Harbs, > > for "calc", Alex fixed the ticket for calc that

Re: [FlexJS, MDL] Layout Problems

2017-02-22 Thread Carlos Rovira
Hi Harbs, for "calc", Alex fixed the ticket for calc that Om create some time ago. If is failing, you should open it again. regarding slider, is great you remove the hardcoded size, I think I forgot to do that in my revision and clean. The only think I 'd ask you if to check that the actual

Re: [FlexJS, MDL] Layout Problems

2017-02-22 Thread Harbs
I committed a change today which fixes the double container problem. It took me quite some time to figure out how to fix the CSS. To fix the CSS so the slider is full width, you need to do this: .mdl-slider { margin: 0px; width: 100%; } .mdl-slider__background-flex {

Re: [FlexJS, MDL] Layout Problems

2017-02-16 Thread OK
>If the Basic set has a component that MDL doesn't, MDL doesn't want you to use >that component. Or am I wrong about that? The problem is that MDL doesn't implement the complete Material Design spec. There's a lack of e.g. DropDown, DatePicker and maybe something other... If MDL would represent

Re: [FlexJS, MDL] Layout Problems

2017-02-16 Thread Josh Tynjala
> If the Basic set has a component that MDL doesn't, MDL doesn't want you to use that component. Or am I wrong about that? MDL is a work in progress, much like FlexJS. Google hasn't necessarily implemented every component that they want to add yet. - Josh

Re: [FlexJS, MDL] Layout Problems

2017-02-16 Thread Alex Harui
On 2/16/17, 1:54 AM, "OK" wrote: >>I will try to create some beads which handle some mentioned cases above. > >From the FlexJS perspective folks of course could wondering why they can't >remove this style but maybe from MDL perspective (including Material >Design >specs)

Re: [FlexJS, MDL] Layout Problems

2017-02-16 Thread piotrz
No problem Olaf! :) Looking forward to see your try of MDL :) Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-MDL-Layout-Problems-tp59423p59540.html Sent from the Apache Flex Development mailing

Re: [FlexJS, MDL] Layout Problems

2017-02-16 Thread OK
>That's why I can provide some beads. If you wanted to use you will if not the core implementation won't >be touched. Yes sorry, this probably makes sens ;-) Thanks for working on MDL! Olaf -- View this message in context:

Re: [FlexJS, MDL] Layout Problems

2017-02-16 Thread piotrz
That's why I can provide some beads. If you wanted to use you will if not the core implementation won't be touched. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

Re: [FlexJS, MDL] Layout Problems

2017-02-16 Thread OK
>I will try to create some beads which handle some mentioned cases above. >From the FlexJS perspective folks of course could wondering why they can't remove this style but maybe from MDL perspective (including Material Design specs) this maybe makes sense [1]. What I would like so say is that on

Re: [FlexJS, MDL] Layout Problems

2017-02-16 Thread Harbs
To sum up the problems: 1. mdl applies a 20 px margin (I think it’s 30px for “flex” sliders) 2. This margin gets applied TWICE in FlexJS mdl. Once for the p element, and then again for the input element. This adds up to a 40px margin. 3. The slider gets wrapped in a mdl-slider__container

Re: [FlexJS, MDL] Layout Problems

2017-02-16 Thread piotrz
Hi Olaf, I will try to create some beads which handle some mentioned cases above. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-MDL-Layout-Problems-tp59423p59534.html Sent from the Apache

Re: [FlexJS, MDL] Layout Problems

2017-02-16 Thread OK
>Can you exact specify what is the class of this container? There's a div that applies the class "mdl-slider__container" which sets the height to 18px [1]. After removing this the vertical gap goes away. The horizontal gap comes as Harbs said from MDL itself, this is not nice but not a FlexJS

Re: [FlexJS, MDL] Layout Problems

2017-02-16 Thread piotrz
Harbs, Can you exact specify what is the class of this container? Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-MDL-Layout-Problems-tp59423p59524.html Sent from the Apache Flex Development

Re: [FlexJS, MDL] Layout Problems

2017-02-16 Thread Harbs
There are actually two problems with Slider. Besides the default 20px margins applied by the mdl css, there’s also an extra container/slider element in FlexJS which causes the margin to be doubled. > On Feb 16, 2017, at 12:12 AM, piotrz wrote: > > Alex, > > I like

Re: [FlexJS, MDL] Layout Problems

2017-02-15 Thread piotrz
Alex, I like the idea! Maybe I should create two beads: LayoutNotImportantBead SliderNoLeftMarginBead What do the others thing ? Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

Re: [FlexJS, MDL] Layout Problems

2017-02-15 Thread Alex Harui
Sounds like several folks have build MDL apps. We should survey the code and look for repeating patterns and encapsulate those things as beads, class selectors, etc. Then maybe the answer will become apparent. -Alex On 2/15/17, 12:45 PM, "piotrz" wrote: >Exactly

Re: [FlexJS, MDL] Layout Problems

2017-02-15 Thread piotrz
Exactly Carlos. That's what I'm trying to get - an opinion whether we should provide such things in our library. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

Re: [FlexJS, MDL] Layout Problems

2017-02-15 Thread OmPrakash Muppirala
On Wed, Feb 15, 2017 at 12:14 PM, piotrz wrote: > Hi Om, > > But saying using !import you mean do not add it to our library, but as an > developer inside our app ? > Yes, I meant for the user-developer. But a component-developer can chose to add the convenient

Re: [FlexJS, MDL] Layout Problems

2017-02-15 Thread Carlos Rovira
Hi Piotr, but in this way of proceed that means that all people using source js/css MDL library in the world will need to make this hack to layout things right isn't it? C. 2017-02-15 21:01 GMT+01:00 piotrz : > Carlos, > > Saying general swc you mean as I mention

Re: [FlexJS, MDL] Layout Problems

2017-02-15 Thread piotrz
Hi Om, But saying using !import you mean do not add it to our library, but as an developer inside our app ? I'm not sure what is for this left margin, but I think this is something which we don't need. Cause if I have simple I expect that everything what is inside there it's displayed with

Re: [FlexJS, MDL] Layout Problems

2017-02-15 Thread OmPrakash Muppirala
As Yishay hinted earlier, we would need to to use !important for display: flex .layout { display: flex !important; } On Wed, Feb 15, 2017 at 12:06 PM, OmPrakash Muppirala wrote: > I have been meaning to add a note asking folks to test out the > FlexTeamPage_MDL

Re: [FlexJS, MDL] Layout Problems

2017-02-15 Thread OmPrakash Muppirala
I have been meaning to add a note asking folks to test out the FlexTeamPage_MDL project https://github.com/apache/flex-asjs/tree/develop/examples/flexjs/FlexTeamPage_MDL Wherever I had layout issues, I simply created a container and gave it a className and did all my layout using FlexBox. That

Re: [FlexJS, MDL] Layout Problems

2017-02-15 Thread piotrz
Carlos, Saying general swc you mean as I mention earlier into our default.css? Cause when I add it will reolve Yishay issue. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

Re: [FlexJS, MDL] Layout Problems

2017-02-15 Thread Carlos Rovira
Hi, 2017-02-15 20:39 GMT+01:00 piotrz : > > I could add it this code to default.css, but is it something which we > wanted > ? > > my guest is that we should upload this kind of css setups to a general SWC since it will impact others. I think we need more experience

Re: [FlexJS, MDL] Layout Problems

2017-02-15 Thread piotrz
Hi Yishay, I have found solution but I'm not sure whether I should commit it. In order to get rid of this ugly margin on the left you have to add style for container of MDL slider - to your mdl-styles.css. .mdl-slider__container { margin: 0, 0, 0, -20px; } I could add it this code to

Re: [FlexJS, MDL] Layout Problems

2017-02-15 Thread OK
Hi Yishayw, yishayw wrote > Carols, Piotrz, if you have time to have a look at this [1] it would be > helpful. We spent some time trying to figure this out, but ended up just > overriding some css attributes with !important, which doesn't seem robust. > > [1]