Seems ok to me. If no tests blow up, should be ok to push.
On 10/19/16, 1:56 AM, "carlos.rov...@gmail.com on behalf of Carlos Rovira"
wrote:
>Hi Alex,
>
>I made a change in a "feature/buttonbase-refactor"
>is tiny, but could potentially break things.
>
>This solves the problem, but I want to kn
Hi Alex,
I made a change in a "feature/buttonbase-refactor"
is tiny, but could potentially break things.
This solves the problem, but I want to know your thinking about collateral
damages in other code or examples.
If you think is not what we need, I think I would go the route of extending
from
On 10/18/16, 4:47 PM, "carlos.rov...@gmail.com on behalf of Carlos Rovira"
wrote:
>I extended TextButton (ergo Button in the end), but I think carry all its
>CSS is not what I expect...maybe I should not extend and replicate
>functionality extending UIBase
Well, maybe. I thought it would be e
I extended TextButton (ergo Button in the end), but I think carry all its
CSS is not what I expect...maybe I should not extend and replicate
functionality extending UIBase
I tried an empty defaults.css in my example project but nothing changes
2016-10-19 1:03 GMT+02:00 Alex Harui :
> They are co
They are coming from the default.css in the HTML swc. I guess because you
have extended the HTML Button or there is one elsewhere in the app, maybe
as a subcomponent. Or maybe it is a bug and it shouldn't be there.
You can specify a custom defaults.css file if you need to.
-Alex
On 10/18/16, 3
