答复: 答复: [discuss] merge module flink-yarn and flink-yarn-test

2016-09-26 Thread shijinkui
ule, not only for good-looking, for its duty. -邮件原件- 发件人: Maximilian Michels [mailto:m...@apache.org] 发送时间: 2016年9月26日 16:33 收件人: dev@flink.apache.org 主题: Re: 答复: [discuss] merge module flink-yarn and flink-yarn-test Hello Jinkui Shi, Due to the nature of most of the Yarn tests, we nee

Re: 答复: [discuss] merge module flink-yarn and flink-yarn-test

2016-09-26 Thread Maximilian Michels
ask why they are exist? Where is the start of such confusion > > modules? > > > > I think we shouldn't do nothing for this. Code and design should be > > comfortable. > > > > Thanks > > > > From Jinkui Shi > > > > -邮件原件- > &g

Re: 答复: [discuss] merge module flink-yarn and flink-yarn-test

2016-09-22 Thread Stephan Ewen
uch confusion > modules? > > I think we shouldn't do nothing for this. Code and design should be > comfortable. > > Thanks > > From Jinkui Shi > > -邮件原件----- > 发件人: Stephan Ewen [mailto:se...@apache.org] > 发送时间: 2016年9月21日 22:19 > 收件人: dev@flink.apach

答复: [discuss] merge module flink-yarn and flink-yarn-test

2016-09-21 Thread shijinkui
x27;t do nothing for this. Code and design should be comfortable. Thanks From Jinkui Shi -邮件原件- 发件人: Stephan Ewen [mailto:se...@apache.org] 发送时间: 2016年9月21日 22:19 收件人: dev@flink.apache.org 主题: Re: [discuss] merge module flink-yarn and flink-yarn-test I would like Robert to comment on this.

Re: [discuss] merge module flink-yarn and flink-yarn-test

2016-09-21 Thread Stephan Ewen
I would like Robert to comment on this. I think there was a reason to have different modules, which had again something to do with the Maven Shade Plugin Dependencies and shading really seem the trickiest thing in bigger Java/Scala projects ;-) On Wed, Sep 21, 2016 at 11:04 AM, shijinkui wrote:

[discuss] merge module flink-yarn and flink-yarn-test

2016-09-21 Thread shijinkui
Hi, All There too much module in the root. There are no necessary to separate the test code from sub-module. I never see such design: two modules, one is main code, the other is test code. Is there some special reason? >From Jinkui Shi