Re: [DISCUSS] FLINK-31873: Add setMaxParallelism to the DataStreamSink Class

2023-04-25 Thread eric xiao
Wow, thank you all for the responses! I have opened a PR [1] to address this ticket, would appreciate any feedback - still relatively new to the codebase, so please let me know if I have overlooked anything obvious . [1] https://github.com/apache/flink/pull/22438 On Tue, Apr 25, 2023 at 1:34 PM

Re: [DISCUSS] FLINK-31873: Add setMaxParallelism to the DataStreamSink Class

2023-04-25 Thread Maximilian Michels
+1 On Tue, Apr 25, 2023 at 5:24 PM David Morávek wrote: > > Hi Eric, > > this sounds reasonable, there are definitely cases where you need to limit > sink parallelism for example not to overload the storage or limit the > number of output files > > +1 > > Best, > D. > > On Sun, Apr 23, 2023 at

Re: [DISCUSS] FLINK-31873: Add setMaxParallelism to the DataStreamSink Class

2023-04-25 Thread David Morávek
Hi Eric, this sounds reasonable, there are definitely cases where you need to limit sink parallelism for example not to overload the storage or limit the number of output files +1 Best, D. On Sun, Apr 23, 2023 at 1:09 PM Weihua Hu wrote: > Hi, Eric > > Thanks for bringing this discussion. >

Re: [DISCUSS] FLINK-31873: Add setMaxParallelism to the DataStreamSink Class

2023-04-23 Thread Weihua Hu
Hi, Eric Thanks for bringing this discussion. I think it's reasonable to add ''setMaxParallelism" for DataStreamSink. +1 Best, Weihua On Sat, Apr 22, 2023 at 3:20 AM eric xiao wrote: > Hi there devs, > > I would like to start a discussion thread for FLINK-31873[1]. > > We are in the