Re: [DISCUSS] Move Flink Docker Files from Flink to 'docker-flink'

2018-02-22 Thread Aljoscha Krettek
+1

> On 22. Feb 2018, at 11:13, Till Rohrmann  wrote:
> 
> +1
> 
> Cheers,
> Till
> 
> On Wed, Feb 21, 2018 at 11:40 PM, Bowen Li  wrote:
> 
>> +1.
>> 
>> flink-contrib is an experiment land, docker-flink should graduate from it.
>> This also helps to clean up flink-contrib/
>> 
>> 
>> 
>> On Wed, Feb 21, 2018 at 1:41 PM, Stephan Ewen  wrote:
>> 
>>> Hi all!
>>> 
>>> I want to start the discussion to whether to drop the "
>>> *flink-contrib/docker-flink*" subproject and instead point users to
>>> "*github.com/docker-flink/docker-flink
>>> *".
>>> 
>>> There are a few reasons for this thought:
>>> 
>>>  - The projects have gone out of sync, and the docker-flink project has
>>> the better maintained code. Users that only see the
>>> "flink-contrib/docker-flink" project refer to outdated build files and
>> have
>>> a suboptimal experience.
>>> 
>>>  - Docker files should be available across multiple Flink versions. That
>>> is easier to do if the files are hosted outside the main source code
>>> repository, which is usually tied to a single version - the latest in the
>>> particular branch.
>>> 
>>>  - We could stop maintaining two repositories.
>>> 
>>> What do you think?
>>> 
>>> I cc-ed the committers/contributors that so far were most active on the
>>> docker projects, would be interested in hearing your opinion.
>>> 
>>> Best,
>>> Stephan
>>> 
>> 



Re: [DISCUSS] Move Flink Docker Files from Flink to 'docker-flink'

2018-02-22 Thread Till Rohrmann
+1

Cheers,
Till

On Wed, Feb 21, 2018 at 11:40 PM, Bowen Li  wrote:

> +1.
>
> flink-contrib is an experiment land, docker-flink should graduate from it.
> This also helps to clean up flink-contrib/
>
>
>
> On Wed, Feb 21, 2018 at 1:41 PM, Stephan Ewen  wrote:
>
> > Hi all!
> >
> > I want to start the discussion to whether to drop the "
> > *flink-contrib/docker-flink*" subproject and instead point users to
> > "*github.com/docker-flink/docker-flink
> > *".
> >
> > There are a few reasons for this thought:
> >
> >   - The projects have gone out of sync, and the docker-flink project has
> > the better maintained code. Users that only see the
> > "flink-contrib/docker-flink" project refer to outdated build files and
> have
> > a suboptimal experience.
> >
> >   - Docker files should be available across multiple Flink versions. That
> > is easier to do if the files are hosted outside the main source code
> > repository, which is usually tied to a single version - the latest in the
> > particular branch.
> >
> >   - We could stop maintaining two repositories.
> >
> > What do you think?
> >
> > I cc-ed the committers/contributors that so far were most active on the
> > docker projects, would be interested in hearing your opinion.
> >
> > Best,
> > Stephan
> >
>


Re: [DISCUSS] Move Flink Docker Files from Flink to 'docker-flink'

2018-02-21 Thread Bowen Li
+1.

flink-contrib is an experiment land, docker-flink should graduate from it.
This also helps to clean up flink-contrib/



On Wed, Feb 21, 2018 at 1:41 PM, Stephan Ewen  wrote:

> Hi all!
>
> I want to start the discussion to whether to drop the "
> *flink-contrib/docker-flink*" subproject and instead point users to
> "*github.com/docker-flink/docker-flink
> *".
>
> There are a few reasons for this thought:
>
>   - The projects have gone out of sync, and the docker-flink project has
> the better maintained code. Users that only see the
> "flink-contrib/docker-flink" project refer to outdated build files and have
> a suboptimal experience.
>
>   - Docker files should be available across multiple Flink versions. That
> is easier to do if the files are hosted outside the main source code
> repository, which is usually tied to a single version - the latest in the
> particular branch.
>
>   - We could stop maintaining two repositories.
>
> What do you think?
>
> I cc-ed the committers/contributors that so far were most active on the
> docker projects, would be interested in hearing your opinion.
>
> Best,
> Stephan
>