Re: [VOTE] Release 1.5.0, release candidate #4

2018-05-22 Thread Thomas Weise
Since we need a new build, can we also include: https://issues.apache.org/jira/browse/FLINK-9402 Thanks, Thomas On Tue, May 22, 2018 at 11:22 AM, Till Rohrmann wrote: > There is another blocker which we should fix with the new RC [1]. There is > already a PR for the

Re: [VOTE] Release 1.5.0, release candidate #4

2018-05-22 Thread Till Rohrmann
There is another blocker which we should fix with the new RC [1]. There is already a PR for the problem. [1] https://issues.apache.org/jira/browse/FLINK-9408 Cheers, Till On Tue, May 22, 2018 at 12:34 PM, Till Rohrmann wrote: > Unfortunately, I have to revise my vote to

Re: [VOTE] Release 1.5.0, release candidate #4

2018-05-22 Thread Till Rohrmann
Unfortunately, I have to revise my vote to -1, because we found a bug in the request partition state RPC call [1]. This bug lets certain batch jobs fail. [1] https://issues.apache.org/jira/browse/FLINK-9406 Cheers, Till On Sat, May 19, 2018 at 9:17 AM, Thomas Weise wrote: >

Re: [VOTE] Release 1.5.0, release candidate #4

2018-05-19 Thread Thomas Weise
+1 - verified signatures and hashes - built Kinesis connector from source archive - run Kinesis consumer against AWS - PASSED - run Kinesis consumer against Kinesalite - FAILED https://issues.apache.org/jira/browse/FLINK-9402 Thomas On Thu, May 17, 2018 at 5:50 PM, Till Rohrmann

Re: [VOTE] Release 1.5.0, release candidate #4

2018-05-18 Thread Ted Yu
bq. We can merge the fix to the master and see if the problem goes away. +1 On Fri, May 18, 2018 at 9:53 AM, Fabian Hueske wrote: > FLINK-9091 is hard to reproduce and only affects the build but no > functionality of Flink or its correctness. > IMO, we should not block the

Re: [VOTE] Release 1.5.0, release candidate #4

2018-05-18 Thread Fabian Hueske
FLINK-9091 is hard to reproduce and only affects the build but no functionality of Flink or its correctness. IMO, we should not block the release it. Since it's hard to reproduce, we cannot be sure that Timo's fix actually solves the problem. We can merge the fix to the master and see if the

Re: [VOTE] Release 1.5.0, release candidate #4

2018-05-18 Thread Ted Yu
When I ran tests, I hit FLINK-9091 . It seems Timo already has a fix. It would be nice to include the fix since flink-json module is new in 1.5 release. On Fri, May 18, 2018 at 9:26 AM, Till Rohrmann wrote: > Hi everyone, > > since the effective voting period for the RC4

Re: [VOTE] Release 1.5.0, release candidate #4

2018-05-18 Thread Till Rohrmann
Hi everyone, since the effective voting period for the RC4 was quite short and it would be better to give the current RC a bit more exposure, I will extend the voting period for another 72 hours until Monday 6:30pm CET. Cheers, Till On Fri, May 18, 2018 at 4:22 PM, Till Rohrmann

Re: [VOTE] Release 1.5.0, release candidate #4

2018-05-18 Thread Till Rohrmann
- Checked checksums and GPG files - Verified that source archives do not contain any binaries - Built Flink with Hadoop 2.8.1 and Scala 2.11.7 from source release - Verified LICENSE and NOTICE file: The LICENSE file contains unnecessary entries for jline-reader and jline-terminal - Checked

Re: [VOTE] Release 1.5.0, release candidate #4

2018-05-18 Thread Till Rohrmann
Just a quick correction, I accidentally wrote that the voting period ends tomorrow 5:30pm CET but what I actually meant was today 5:30pm CET. The problem was that I compiled the mail before midnight. Cheers, Till On Fri, May 18, 2018 at 2:50 AM, Till Rohrmann wrote: > Hi