Re: [VOTE] Release 1.5.0, release candidate #4

2018-05-22 Thread Thomas Weise 
Since we need a new build, can we also include:

https://issues.apache.org/jira/browse/FLINK-9402

Thanks,
Thomas


On Tue, May 22, 2018 at 11:22 AM, Till Rohrmann 
wrote:

> There is another blocker which we should fix with the new RC [1]. There is
> already a PR for the problem.
>
> [1] https://issues.apache.org/jira/browse/FLINK-9408
>
> Cheers,
> Till
>
> On Tue, May 22, 2018 at 12:34 PM, Till Rohrmann 
> wrote:
>
> > Unfortunately, I have to revise my vote to -1, because we found a bug in
> > the request partition state RPC call [1]. This bug lets certain batch
> jobs
> > fail.
> >
> > [1] https://issues.apache.org/jira/browse/FLINK-9406
> >
> > Cheers,
> > Till
> >
> > On Sat, May 19, 2018 at 9:17 AM, Thomas Weise  wrote:
> >
> >> +1
> >>
> >> - verified signatures and hashes
> >> - built Kinesis connector from source archive
> >> - run Kinesis consumer against AWS - PASSED
> >> - run Kinesis consumer against Kinesalite - FAILED
> >> https://issues.apache.org/jira/browse/FLINK-9402
> >>
> >>  Thomas
> >>
> >>
> >> On Thu, May 17, 2018 at 5:50 PM, Till Rohrmann 
> >> wrote:
> >>
> >> > Hi everyone,
> >> >
> >> > Please review and vote on the release candidate #4 for the version
> >> 1.5.0,
> >> > as follows:
> >> > [ ] +1, Approve the release
> >> > [ ] -1, Do not approve the release (please provide specific comments)
> >> >
> >> >
> >> > The complete staging area is available for your review, which
> includes:
> >> > * JIRA release notes [1],
> >> > * the official Apache source release and binary convenience releases
> to
> >> be
> >> > deployed to dist.apache.org [2], which are signed with the key with
> >> > fingerprint 1F302569A96CFFD5 [3],
> >> > * all artifacts to be deployed to the Maven Central Repository [4],
> >> > * source code tag "release-1.5.0-rc3" [5],
> >> >
> >> > Please use this document for coordinating testing efforts: [6]
> >> >
> >> > Since the newly included fixes affect only individual components and
> are
> >> > covered by tests, I will keep the voting period of the RC3 which goes
> at
> >> > least until tomorrow 5:30pm CET. It is adopted by majority approval,
> >> with
> >> > at least 3 PMC affirmative votes.
> >> >
> >> > Thanks,
> >> > Your friendly Release Manager
> >> >
> >> > [1]
> >> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> >> > projectId=12315522=12341764
> >> > [2] http://people.apache.org/~trohrmann/flink-1.5.0-rc4/
> >> > [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> >> > [4] https://repository.apache.org/content/repositories/
> >> > orgapacheflink-1159/
> >> > [5]
> >> > https://git-wip-us.apache.org/repos/asf?p=flink.git;a=commit;h=
> >> > 953f45316b09072e76f3cf3d37d704a7cb7b32c6
> >> > [6]
> >> > https://docs.google.com/document/d/13evetGNVeGvSufeqC0bcfiHGS_
> >> > v8n06I0p6nEtaQzS4/edit?usp=sharing
> >> >
> >> > Pro-tip: you can create a settings.xml file with these contents:
> >> >
> >> > 
> >> > 
> >> >   flink-1.5.0
> >> > 
> >> > 
> >> >   
> >> > flink-1.5.0
> >> > 
> >> >   
> >> > flink-1.5.0
> >> > 
> >> >
> >> > https://repository.apache.org/content/repositories/
> orgapacheflink-1159/
> >> > 
> >> >   
> >> >   
> >> > archetype
> >> > 
> >> >
> >> > https://repository.apache.org/content/repositories/
> orgapacheflink-1159/
> >> > 
> >> >   
> >> > 
> >> >   
> >> > 
> >> > 
> >> >
> >> > And reference that in you maven commands via --settings
> >> > path/to/settings.xml. This is useful for creating a quickstart based
> on
> >> the
> >> > staged release and for building against the staged jars.
> >> >
> >>
> >
> >
>

Re: [VOTE] Release 1.5.0, release candidate #4

2018-05-22 Thread Till Rohrmann 
There is another blocker which we should fix with the new RC [1]. There is
already a PR for the problem.

[1] https://issues.apache.org/jira/browse/FLINK-9408

Cheers,
Till

On Tue, May 22, 2018 at 12:34 PM, Till Rohrmann 
wrote:

> Unfortunately, I have to revise my vote to -1, because we found a bug in
> the request partition state RPC call [1]. This bug lets certain batch jobs
> fail.
>
> [1] https://issues.apache.org/jira/browse/FLINK-9406
>
> Cheers,
> Till
>
> On Sat, May 19, 2018 at 9:17 AM, Thomas Weise  wrote:
>
>> +1
>>
>> - verified signatures and hashes
>> - built Kinesis connector from source archive
>> - run Kinesis consumer against AWS - PASSED
>> - run Kinesis consumer against Kinesalite - FAILED
>> https://issues.apache.org/jira/browse/FLINK-9402
>>
>>  Thomas
>>
>>
>> On Thu, May 17, 2018 at 5:50 PM, Till Rohrmann 
>> wrote:
>>
>> > Hi everyone,
>> >
>> > Please review and vote on the release candidate #4 for the version
>> 1.5.0,
>> > as follows:
>> > [ ] +1, Approve the release
>> > [ ] -1, Do not approve the release (please provide specific comments)
>> >
>> >
>> > The complete staging area is available for your review, which includes:
>> > * JIRA release notes [1],
>> > * the official Apache source release and binary convenience releases to
>> be
>> > deployed to dist.apache.org [2], which are signed with the key with
>> > fingerprint 1F302569A96CFFD5 [3],
>> > * all artifacts to be deployed to the Maven Central Repository [4],
>> > * source code tag "release-1.5.0-rc3" [5],
>> >
>> > Please use this document for coordinating testing efforts: [6]
>> >
>> > Since the newly included fixes affect only individual components and are
>> > covered by tests, I will keep the voting period of the RC3 which goes at
>> > least until tomorrow 5:30pm CET. It is adopted by majority approval,
>> with
>> > at least 3 PMC affirmative votes.
>> >
>> > Thanks,
>> > Your friendly Release Manager
>> >
>> > [1]
>> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
>> > projectId=12315522=12341764
>> > [2] http://people.apache.org/~trohrmann/flink-1.5.0-rc4/
>> > [3] https://dist.apache.org/repos/dist/release/flink/KEYS
>> > [4] https://repository.apache.org/content/repositories/
>> > orgapacheflink-1159/
>> > [5]
>> > https://git-wip-us.apache.org/repos/asf?p=flink.git;a=commit;h=
>> > 953f45316b09072e76f3cf3d37d704a7cb7b32c6
>> > [6]
>> > https://docs.google.com/document/d/13evetGNVeGvSufeqC0bcfiHGS_
>> > v8n06I0p6nEtaQzS4/edit?usp=sharing
>> >
>> > Pro-tip: you can create a settings.xml file with these contents:
>> >
>> > 
>> > 
>> >   flink-1.5.0
>> > 
>> > 
>> >   
>> > flink-1.5.0
>> > 
>> >   
>> > flink-1.5.0
>> > 
>> >
>> > https://repository.apache.org/content/repositories/orgapacheflink-1159/
>> > 
>> >   
>> >   
>> > archetype
>> > 
>> >
>> > https://repository.apache.org/content/repositories/orgapacheflink-1159/
>> > 
>> >   
>> > 
>> >   
>> > 
>> > 
>> >
>> > And reference that in you maven commands via --settings
>> > path/to/settings.xml. This is useful for creating a quickstart based on
>> the
>> > staged release and for building against the staged jars.
>> >
>>
>
>

Re: [VOTE] Release 1.5.0, release candidate #4

2018-05-22 Thread Till Rohrmann 
Unfortunately, I have to revise my vote to -1, because we found a bug in
the request partition state RPC call [1]. This bug lets certain batch jobs
fail.

[1] https://issues.apache.org/jira/browse/FLINK-9406

Cheers,
Till

On Sat, May 19, 2018 at 9:17 AM, Thomas Weise  wrote:

> +1
>
> - verified signatures and hashes
> - built Kinesis connector from source archive
> - run Kinesis consumer against AWS - PASSED
> - run Kinesis consumer against Kinesalite - FAILED
> https://issues.apache.org/jira/browse/FLINK-9402
>
>  Thomas
>
>
> On Thu, May 17, 2018 at 5:50 PM, Till Rohrmann 
> wrote:
>
> > Hi everyone,
> >
> > Please review and vote on the release candidate #4 for the version 1.5.0,
> > as follows:
> > [ ] +1, Approve the release
> > [ ] -1, Do not approve the release (please provide specific comments)
> >
> >
> > The complete staging area is available for your review, which includes:
> > * JIRA release notes [1],
> > * the official Apache source release and binary convenience releases to
> be
> > deployed to dist.apache.org [2], which are signed with the key with
> > fingerprint 1F302569A96CFFD5 [3],
> > * all artifacts to be deployed to the Maven Central Repository [4],
> > * source code tag "release-1.5.0-rc3" [5],
> >
> > Please use this document for coordinating testing efforts: [6]
> >
> > Since the newly included fixes affect only individual components and are
> > covered by tests, I will keep the voting period of the RC3 which goes at
> > least until tomorrow 5:30pm CET. It is adopted by majority approval, with
> > at least 3 PMC affirmative votes.
> >
> > Thanks,
> > Your friendly Release Manager
> >
> > [1]
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > projectId=12315522=12341764
> > [2] http://people.apache.org/~trohrmann/flink-1.5.0-rc4/
> > [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > [4] https://repository.apache.org/content/repositories/
> > orgapacheflink-1159/
> > [5]
> > https://git-wip-us.apache.org/repos/asf?p=flink.git;a=commit;h=
> > 953f45316b09072e76f3cf3d37d704a7cb7b32c6
> > [6]
> > https://docs.google.com/document/d/13evetGNVeGvSufeqC0bcfiHGS_
> > v8n06I0p6nEtaQzS4/edit?usp=sharing
> >
> > Pro-tip: you can create a settings.xml file with these contents:
> >
> > 
> > 
> >   flink-1.5.0
> > 
> > 
> >   
> > flink-1.5.0
> > 
> >   
> > flink-1.5.0
> > 
> >
> > https://repository.apache.org/content/repositories/orgapacheflink-1159/
> > 
> >   
> >   
> > archetype
> > 
> >
> > https://repository.apache.org/content/repositories/orgapacheflink-1159/
> > 
> >   
> > 
> >   
> > 
> > 
> >
> > And reference that in you maven commands via --settings
> > path/to/settings.xml. This is useful for creating a quickstart based on
> the
> > staged release and for building against the staged jars.
> >
>

Re: [VOTE] Release 1.5.0, release candidate #4

2018-05-19 Thread Thomas Weise 
+1

- verified signatures and hashes
- built Kinesis connector from source archive
- run Kinesis consumer against AWS - PASSED
- run Kinesis consumer against Kinesalite - FAILED
https://issues.apache.org/jira/browse/FLINK-9402

 Thomas


On Thu, May 17, 2018 at 5:50 PM, Till Rohrmann  wrote:

> Hi everyone,
>
> Please review and vote on the release candidate #4 for the version 1.5.0,
> as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
>
> The complete staging area is available for your review, which includes:
> * JIRA release notes [1],
> * the official Apache source release and binary convenience releases to be
> deployed to dist.apache.org [2], which are signed with the key with
> fingerprint 1F302569A96CFFD5 [3],
> * all artifacts to be deployed to the Maven Central Repository [4],
> * source code tag "release-1.5.0-rc3" [5],
>
> Please use this document for coordinating testing efforts: [6]
>
> Since the newly included fixes affect only individual components and are
> covered by tests, I will keep the voting period of the RC3 which goes at
> least until tomorrow 5:30pm CET. It is adopted by majority approval, with
> at least 3 PMC affirmative votes.
>
> Thanks,
> Your friendly Release Manager
>
> [1]
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12315522=12341764
> [2] http://people.apache.org/~trohrmann/flink-1.5.0-rc4/
> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> [4] https://repository.apache.org/content/repositories/
> orgapacheflink-1159/
> [5]
> https://git-wip-us.apache.org/repos/asf?p=flink.git;a=commit;h=
> 953f45316b09072e76f3cf3d37d704a7cb7b32c6
> [6]
> https://docs.google.com/document/d/13evetGNVeGvSufeqC0bcfiHGS_
> v8n06I0p6nEtaQzS4/edit?usp=sharing
>
> Pro-tip: you can create a settings.xml file with these contents:
>
> 
> 
>   flink-1.5.0
> 
> 
>   
> flink-1.5.0
> 
>   
> flink-1.5.0
> 
>
> https://repository.apache.org/content/repositories/orgapacheflink-1159/
> 
>   
>   
> archetype
> 
>
> https://repository.apache.org/content/repositories/orgapacheflink-1159/
> 
>   
> 
>   
> 
> 
>
> And reference that in you maven commands via --settings
> path/to/settings.xml. This is useful for creating a quickstart based on the
> staged release and for building against the staged jars.
>

Re: [VOTE] Release 1.5.0, release candidate #4

2018-05-18 Thread Ted Yu 
bq. We can merge the fix to the master and see if the problem goes away.

+1

On Fri, May 18, 2018 at 9:53 AM, Fabian Hueske  wrote:

> FLINK-9091 is hard to reproduce and only affects the build but no
> functionality of Flink or its correctness.
> IMO, we should not block the release it.
>
> Since it's hard to reproduce, we cannot be sure that Timo's fix actually
> solves the problem.
> We can merge the fix to the master and see if the problem goes away.
>
> Best, Fabian
>
> 2018-05-18 18:31 GMT+02:00 Ted Yu :
>
> > When I ran tests, I hit FLINK-9091 .
> >
> > It seems Timo already has a fix.
> >
> > It would be nice to include the fix since flink-json module is new in 1.5
> > release.
> >
> > On Fri, May 18, 2018 at 9:26 AM, Till Rohrmann 
> > wrote:
> >
> > > Hi everyone,
> > >
> > > since the effective voting period for the RC4 was quite short and it
> > would
> > > be better to give the current RC a bit more exposure, I will extend the
> > > voting period for another 72 hours until Monday 6:30pm CET.
> > >
> > > Cheers,
> > > Till
> > >
> > > On Fri, May 18, 2018 at 4:22 PM, Till Rohrmann 
> > > wrote:
> > >
> > > > - Checked checksums and GPG files
> > > > - Verified that source archives do not contain any binaries
> > > > - Built Flink with Hadoop 2.8.1 and Scala 2.11.7 from source release
> > > > - Verified LICENSE and NOTICE file: The LICENSE file contains
> > unnecessary
> > > > entries for jline-reader and jline-terminal
> > > > - Checked licenses of newly added dependencies
> > > > - Checked pom files
> > > > - Read README.md
> > > > - Run manual tests in flink-tests: CheckForbiddenMethodsUsage fails
> > > > because org.apache.flink.queryablestate.messages.
> > > KvStateRequest.serialize()
> > > > uses getBytes without charset. This is non-blocking because it was
> > > > introduced with 1.4 or before
> > > > - Checked builds with SBT and the SBT quickstarts
> > > > - Executed the run-nightly-tests.sh for 10 hours without failures
> > > > - Executed Jepsen tests without failures
> > > >
> > > > +1
> > > >
> > > > Cheers,
> > > > Till
> > > >
> > > > On Fri, May 18, 2018 at 12:58 PM, Piotr Nowojski <
> > > pi...@data-artisans.com>
> > > > wrote:
> > > >
> > > >> +1 From me. I have tested Scala and Java quickstarts and they work
> > fine
> > > >> except of sbt versions. But sbt quickstarts are also failing on my
> > > >> environment for 1.4.x. So it’s either pre-existing issue, or me
> doing
> > > >> something wrong.
> > > >>
> > > >> I have also run some quick tests on EMR cluster, without problems.
> > > >>
> > > >> Piotrek
> > > >>
> > > >> > On 18 May 2018, at 09:48, Till Rohrmann 
> > wrote:
> > > >> >
> > > >> > Just a quick correction, I accidentally wrote that the voting
> period
> > > >> ends
> > > >> > tomorrow 5:30pm CET but what I actually meant was today 5:30pm
> CET.
> > > The
> > > >> > problem was that I compiled the mail before midnight.
> > > >> >
> > > >> > Cheers,
> > > >> > Till
> > > >> >
> > > >> > On Fri, May 18, 2018 at 2:50 AM, Till Rohrmann <
> > trohrm...@apache.org>
> > > >> wrote:
> > > >> >
> > > >> >> Hi everyone,
> > > >> >>
> > > >> >> Please review and vote on the release candidate #4 for the
> version
> > > >> 1.5.0,
> > > >> >> as follows:
> > > >> >> [ ] +1, Approve the release
> > > >> >> [ ] -1, Do not approve the release (please provide specific
> > comments)
> > > >> >>
> > > >> >>
> > > >> >> The complete staging area is available for your review, which
> > > includes:
> > > >> >> * JIRA release notes [1],
> > > >> >> * the official Apache source release and binary convenience
> > releases
> > > >> to be
> > > >> >> deployed to dist.apache.org [2], which are signed with the key
> > with
> > > >> >> fingerprint 1F302569A96CFFD5 [3],
> > > >> >> * all artifacts to be deployed to the Maven Central Repository
> [4],
> > > >> >> * source code tag "release-1.5.0-rc3" [5],
> > > >> >>
> > > >> >> Please use this document for coordinating testing efforts: [6]
> > > >> >>
> > > >> >> Since the newly included fixes affect only individual components
> > and
> > > >> are
> > > >> >> covered by tests, I will keep the voting period of the RC3 which
> > goes
> > > >> at
> > > >> >> least until tomorrow 5:30pm CET. It is adopted by majority
> > approval,
> > > >> with
> > > >> >> at least 3 PMC affirmative votes.
> > > >> >>
> > > >> >> Thanks,
> > > >> >> Your friendly Release Manager
> > > >> >>
> > > >> >> [1] https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > > >> >> projectId=12315522=12341764
> > > >> >> [2] http://people.apache.org/~trohrmann/flink-1.5.0-rc4/
> > > >> >> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > > >> >> [4] https://repository.apache.org/content/repositories/
> > > >> >> orgapacheflink-1159/
> > > >> >> [5] https://git-wip-us.apache.org/repos/asf?p=flink.git;a=
> > commit;h=
> > > >> >>

Re: [VOTE] Release 1.5.0, release candidate #4

2018-05-18 Thread Fabian Hueske 
FLINK-9091 is hard to reproduce and only affects the build but no
functionality of Flink or its correctness.
IMO, we should not block the release it.

Since it's hard to reproduce, we cannot be sure that Timo's fix actually
solves the problem.
We can merge the fix to the master and see if the problem goes away.

Best, Fabian

2018-05-18 18:31 GMT+02:00 Ted Yu :

> When I ran tests, I hit FLINK-9091 .
>
> It seems Timo already has a fix.
>
> It would be nice to include the fix since flink-json module is new in 1.5
> release.
>
> On Fri, May 18, 2018 at 9:26 AM, Till Rohrmann 
> wrote:
>
> > Hi everyone,
> >
> > since the effective voting period for the RC4 was quite short and it
> would
> > be better to give the current RC a bit more exposure, I will extend the
> > voting period for another 72 hours until Monday 6:30pm CET.
> >
> > Cheers,
> > Till
> >
> > On Fri, May 18, 2018 at 4:22 PM, Till Rohrmann 
> > wrote:
> >
> > > - Checked checksums and GPG files
> > > - Verified that source archives do not contain any binaries
> > > - Built Flink with Hadoop 2.8.1 and Scala 2.11.7 from source release
> > > - Verified LICENSE and NOTICE file: The LICENSE file contains
> unnecessary
> > > entries for jline-reader and jline-terminal
> > > - Checked licenses of newly added dependencies
> > > - Checked pom files
> > > - Read README.md
> > > - Run manual tests in flink-tests: CheckForbiddenMethodsUsage fails
> > > because org.apache.flink.queryablestate.messages.
> > KvStateRequest.serialize()
> > > uses getBytes without charset. This is non-blocking because it was
> > > introduced with 1.4 or before
> > > - Checked builds with SBT and the SBT quickstarts
> > > - Executed the run-nightly-tests.sh for 10 hours without failures
> > > - Executed Jepsen tests without failures
> > >
> > > +1
> > >
> > > Cheers,
> > > Till
> > >
> > > On Fri, May 18, 2018 at 12:58 PM, Piotr Nowojski <
> > pi...@data-artisans.com>
> > > wrote:
> > >
> > >> +1 From me. I have tested Scala and Java quickstarts and they work
> fine
> > >> except of sbt versions. But sbt quickstarts are also failing on my
> > >> environment for 1.4.x. So it’s either pre-existing issue, or me doing
> > >> something wrong.
> > >>
> > >> I have also run some quick tests on EMR cluster, without problems.
> > >>
> > >> Piotrek
> > >>
> > >> > On 18 May 2018, at 09:48, Till Rohrmann 
> wrote:
> > >> >
> > >> > Just a quick correction, I accidentally wrote that the voting period
> > >> ends
> > >> > tomorrow 5:30pm CET but what I actually meant was today 5:30pm CET.
> > The
> > >> > problem was that I compiled the mail before midnight.
> > >> >
> > >> > Cheers,
> > >> > Till
> > >> >
> > >> > On Fri, May 18, 2018 at 2:50 AM, Till Rohrmann <
> trohrm...@apache.org>
> > >> wrote:
> > >> >
> > >> >> Hi everyone,
> > >> >>
> > >> >> Please review and vote on the release candidate #4 for the version
> > >> 1.5.0,
> > >> >> as follows:
> > >> >> [ ] +1, Approve the release
> > >> >> [ ] -1, Do not approve the release (please provide specific
> comments)
> > >> >>
> > >> >>
> > >> >> The complete staging area is available for your review, which
> > includes:
> > >> >> * JIRA release notes [1],
> > >> >> * the official Apache source release and binary convenience
> releases
> > >> to be
> > >> >> deployed to dist.apache.org [2], which are signed with the key
> with
> > >> >> fingerprint 1F302569A96CFFD5 [3],
> > >> >> * all artifacts to be deployed to the Maven Central Repository [4],
> > >> >> * source code tag "release-1.5.0-rc3" [5],
> > >> >>
> > >> >> Please use this document for coordinating testing efforts: [6]
> > >> >>
> > >> >> Since the newly included fixes affect only individual components
> and
> > >> are
> > >> >> covered by tests, I will keep the voting period of the RC3 which
> goes
> > >> at
> > >> >> least until tomorrow 5:30pm CET. It is adopted by majority
> approval,
> > >> with
> > >> >> at least 3 PMC affirmative votes.
> > >> >>
> > >> >> Thanks,
> > >> >> Your friendly Release Manager
> > >> >>
> > >> >> [1] https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > >> >> projectId=12315522=12341764
> > >> >> [2] http://people.apache.org/~trohrmann/flink-1.5.0-rc4/
> > >> >> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > >> >> [4] https://repository.apache.org/content/repositories/
> > >> >> orgapacheflink-1159/
> > >> >> [5] https://git-wip-us.apache.org/repos/asf?p=flink.git;a=
> commit;h=
> > >> >> 953f45316b09072e76f3cf3d37d704a7cb7b32c6
> > >> >> [6] https://docs.google.com/document/d/13evetGNVeGvSufeqC0bcfiHGS_
> > >> >> v8n06I0p6nEtaQzS4/edit?usp=sharing
> > >> >>
> > >> >> Pro-tip: you can create a settings.xml file with these contents:
> > >> >>
> > >> >> 
> > >> >> 
> > >> >>  flink-1.5.0
> > >> >> 
> > >> >> 
> > >> >>  
> > >> >>flink-1.5.0
> > >> >>
> > >> >>  
> > >> >>flink-1.5.0
> > >> >>
> > >> >>

Re: [VOTE] Release 1.5.0, release candidate #4

2018-05-18 Thread Ted Yu 
When I ran tests, I hit FLINK-9091 .

It seems Timo already has a fix.

It would be nice to include the fix since flink-json module is new in 1.5
release.

On Fri, May 18, 2018 at 9:26 AM, Till Rohrmann  wrote:

> Hi everyone,
>
> since the effective voting period for the RC4 was quite short and it would
> be better to give the current RC a bit more exposure, I will extend the
> voting period for another 72 hours until Monday 6:30pm CET.
>
> Cheers,
> Till
>
> On Fri, May 18, 2018 at 4:22 PM, Till Rohrmann 
> wrote:
>
> > - Checked checksums and GPG files
> > - Verified that source archives do not contain any binaries
> > - Built Flink with Hadoop 2.8.1 and Scala 2.11.7 from source release
> > - Verified LICENSE and NOTICE file: The LICENSE file contains unnecessary
> > entries for jline-reader and jline-terminal
> > - Checked licenses of newly added dependencies
> > - Checked pom files
> > - Read README.md
> > - Run manual tests in flink-tests: CheckForbiddenMethodsUsage fails
> > because org.apache.flink.queryablestate.messages.
> KvStateRequest.serialize()
> > uses getBytes without charset. This is non-blocking because it was
> > introduced with 1.4 or before
> > - Checked builds with SBT and the SBT quickstarts
> > - Executed the run-nightly-tests.sh for 10 hours without failures
> > - Executed Jepsen tests without failures
> >
> > +1
> >
> > Cheers,
> > Till
> >
> > On Fri, May 18, 2018 at 12:58 PM, Piotr Nowojski <
> pi...@data-artisans.com>
> > wrote:
> >
> >> +1 From me. I have tested Scala and Java quickstarts and they work fine
> >> except of sbt versions. But sbt quickstarts are also failing on my
> >> environment for 1.4.x. So it’s either pre-existing issue, or me doing
> >> something wrong.
> >>
> >> I have also run some quick tests on EMR cluster, without problems.
> >>
> >> Piotrek
> >>
> >> > On 18 May 2018, at 09:48, Till Rohrmann  wrote:
> >> >
> >> > Just a quick correction, I accidentally wrote that the voting period
> >> ends
> >> > tomorrow 5:30pm CET but what I actually meant was today 5:30pm CET.
> The
> >> > problem was that I compiled the mail before midnight.
> >> >
> >> > Cheers,
> >> > Till
> >> >
> >> > On Fri, May 18, 2018 at 2:50 AM, Till Rohrmann 
> >> wrote:
> >> >
> >> >> Hi everyone,
> >> >>
> >> >> Please review and vote on the release candidate #4 for the version
> >> 1.5.0,
> >> >> as follows:
> >> >> [ ] +1, Approve the release
> >> >> [ ] -1, Do not approve the release (please provide specific comments)
> >> >>
> >> >>
> >> >> The complete staging area is available for your review, which
> includes:
> >> >> * JIRA release notes [1],
> >> >> * the official Apache source release and binary convenience releases
> >> to be
> >> >> deployed to dist.apache.org [2], which are signed with the key with
> >> >> fingerprint 1F302569A96CFFD5 [3],
> >> >> * all artifacts to be deployed to the Maven Central Repository [4],
> >> >> * source code tag "release-1.5.0-rc3" [5],
> >> >>
> >> >> Please use this document for coordinating testing efforts: [6]
> >> >>
> >> >> Since the newly included fixes affect only individual components and
> >> are
> >> >> covered by tests, I will keep the voting period of the RC3 which goes
> >> at
> >> >> least until tomorrow 5:30pm CET. It is adopted by majority approval,
> >> with
> >> >> at least 3 PMC affirmative votes.
> >> >>
> >> >> Thanks,
> >> >> Your friendly Release Manager
> >> >>
> >> >> [1] https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> >> >> projectId=12315522=12341764
> >> >> [2] http://people.apache.org/~trohrmann/flink-1.5.0-rc4/
> >> >> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> >> >> [4] https://repository.apache.org/content/repositories/
> >> >> orgapacheflink-1159/
> >> >> [5] https://git-wip-us.apache.org/repos/asf?p=flink.git;a=commit;h=
> >> >> 953f45316b09072e76f3cf3d37d704a7cb7b32c6
> >> >> [6] https://docs.google.com/document/d/13evetGNVeGvSufeqC0bcfiHGS_
> >> >> v8n06I0p6nEtaQzS4/edit?usp=sharing
> >> >>
> >> >> Pro-tip: you can create a settings.xml file with these contents:
> >> >>
> >> >> 
> >> >> 
> >> >>  flink-1.5.0
> >> >> 
> >> >> 
> >> >>  
> >> >>flink-1.5.0
> >> >>
> >> >>  
> >> >>flink-1.5.0
> >> >>
> >> >>https://repository.apache.org/content/repositories/
> >> >> orgapacheflink-1159/
> >> >>
> >> >>  
> >> >>  
> >> >>archetype
> >> >>
> >> >>https://repository.apache.org/content/repositories/
> >> >> orgapacheflink-1159/
> >> >>
> >> >>  
> >> >>
> >> >>  
> >> >> 
> >> >> 
> >> >>
> >> >> And reference that in you maven commands via --settings
> >> >> path/to/settings.xml. This is useful for creating a quickstart based
> >> on the
> >> >> staged release and for building against the staged jars.
> >> >>
> >>
> >>
> >
>

Re: [VOTE] Release 1.5.0, release candidate #4

2018-05-18 Thread Till Rohrmann 
Hi everyone,

since the effective voting period for the RC4 was quite short and it would
be better to give the current RC a bit more exposure, I will extend the
voting period for another 72 hours until Monday 6:30pm CET.

Cheers,
Till

On Fri, May 18, 2018 at 4:22 PM, Till Rohrmann  wrote:

> - Checked checksums and GPG files
> - Verified that source archives do not contain any binaries
> - Built Flink with Hadoop 2.8.1 and Scala 2.11.7 from source release
> - Verified LICENSE and NOTICE file: The LICENSE file contains unnecessary
> entries for jline-reader and jline-terminal
> - Checked licenses of newly added dependencies
> - Checked pom files
> - Read README.md
> - Run manual tests in flink-tests: CheckForbiddenMethodsUsage fails
> because org.apache.flink.queryablestate.messages.KvStateRequest.serialize()
> uses getBytes without charset. This is non-blocking because it was
> introduced with 1.4 or before
> - Checked builds with SBT and the SBT quickstarts
> - Executed the run-nightly-tests.sh for 10 hours without failures
> - Executed Jepsen tests without failures
>
> +1
>
> Cheers,
> Till
>
> On Fri, May 18, 2018 at 12:58 PM, Piotr Nowojski 
> wrote:
>
>> +1 From me. I have tested Scala and Java quickstarts and they work fine
>> except of sbt versions. But sbt quickstarts are also failing on my
>> environment for 1.4.x. So it’s either pre-existing issue, or me doing
>> something wrong.
>>
>> I have also run some quick tests on EMR cluster, without problems.
>>
>> Piotrek
>>
>> > On 18 May 2018, at 09:48, Till Rohrmann  wrote:
>> >
>> > Just a quick correction, I accidentally wrote that the voting period
>> ends
>> > tomorrow 5:30pm CET but what I actually meant was today 5:30pm CET. The
>> > problem was that I compiled the mail before midnight.
>> >
>> > Cheers,
>> > Till
>> >
>> > On Fri, May 18, 2018 at 2:50 AM, Till Rohrmann 
>> wrote:
>> >
>> >> Hi everyone,
>> >>
>> >> Please review and vote on the release candidate #4 for the version
>> 1.5.0,
>> >> as follows:
>> >> [ ] +1, Approve the release
>> >> [ ] -1, Do not approve the release (please provide specific comments)
>> >>
>> >>
>> >> The complete staging area is available for your review, which includes:
>> >> * JIRA release notes [1],
>> >> * the official Apache source release and binary convenience releases
>> to be
>> >> deployed to dist.apache.org [2], which are signed with the key with
>> >> fingerprint 1F302569A96CFFD5 [3],
>> >> * all artifacts to be deployed to the Maven Central Repository [4],
>> >> * source code tag "release-1.5.0-rc3" [5],
>> >>
>> >> Please use this document for coordinating testing efforts: [6]
>> >>
>> >> Since the newly included fixes affect only individual components and
>> are
>> >> covered by tests, I will keep the voting period of the RC3 which goes
>> at
>> >> least until tomorrow 5:30pm CET. It is adopted by majority approval,
>> with
>> >> at least 3 PMC affirmative votes.
>> >>
>> >> Thanks,
>> >> Your friendly Release Manager
>> >>
>> >> [1] https://issues.apache.org/jira/secure/ReleaseNote.jspa?
>> >> projectId=12315522=12341764
>> >> [2] http://people.apache.org/~trohrmann/flink-1.5.0-rc4/
>> >> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
>> >> [4] https://repository.apache.org/content/repositories/
>> >> orgapacheflink-1159/
>> >> [5] https://git-wip-us.apache.org/repos/asf?p=flink.git;a=commit;h=
>> >> 953f45316b09072e76f3cf3d37d704a7cb7b32c6
>> >> [6] https://docs.google.com/document/d/13evetGNVeGvSufeqC0bcfiHGS_
>> >> v8n06I0p6nEtaQzS4/edit?usp=sharing
>> >>
>> >> Pro-tip: you can create a settings.xml file with these contents:
>> >>
>> >> 
>> >> 
>> >>  flink-1.5.0
>> >> 
>> >> 
>> >>  
>> >>flink-1.5.0
>> >>
>> >>  
>> >>flink-1.5.0
>> >>
>> >>https://repository.apache.org/content/repositories/
>> >> orgapacheflink-1159/
>> >>
>> >>  
>> >>  
>> >>archetype
>> >>
>> >>https://repository.apache.org/content/repositories/
>> >> orgapacheflink-1159/
>> >>
>> >>  
>> >>
>> >>  
>> >> 
>> >> 
>> >>
>> >> And reference that in you maven commands via --settings
>> >> path/to/settings.xml. This is useful for creating a quickstart based
>> on the
>> >> staged release and for building against the staged jars.
>> >>
>>
>>
>

Re: [VOTE] Release 1.5.0, release candidate #4

2018-05-18 Thread Till Rohrmann 
- Checked checksums and GPG files
- Verified that source archives do not contain any binaries
- Built Flink with Hadoop 2.8.1 and Scala 2.11.7 from source release
- Verified LICENSE and NOTICE file: The LICENSE file contains unnecessary
entries for jline-reader and jline-terminal
- Checked licenses of newly added dependencies
- Checked pom files
- Read README.md
- Run manual tests in flink-tests: CheckForbiddenMethodsUsage fails
because org.apache.flink.queryablestate.messages.KvStateRequest.serialize()
uses getBytes without charset. This is non-blocking because it was
introduced with 1.4 or before
- Checked builds with SBT and the SBT quickstarts
- Executed the run-nightly-tests.sh for 10 hours without failures
- Executed Jepsen tests without failures

+1

Cheers,
Till

On Fri, May 18, 2018 at 12:58 PM, Piotr Nowojski 
wrote:

> +1 From me. I have tested Scala and Java quickstarts and they work fine
> except of sbt versions. But sbt quickstarts are also failing on my
> environment for 1.4.x. So it’s either pre-existing issue, or me doing
> something wrong.
>
> I have also run some quick tests on EMR cluster, without problems.
>
> Piotrek
>
> > On 18 May 2018, at 09:48, Till Rohrmann  wrote:
> >
> > Just a quick correction, I accidentally wrote that the voting period ends
> > tomorrow 5:30pm CET but what I actually meant was today 5:30pm CET. The
> > problem was that I compiled the mail before midnight.
> >
> > Cheers,
> > Till
> >
> > On Fri, May 18, 2018 at 2:50 AM, Till Rohrmann 
> wrote:
> >
> >> Hi everyone,
> >>
> >> Please review and vote on the release candidate #4 for the version
> 1.5.0,
> >> as follows:
> >> [ ] +1, Approve the release
> >> [ ] -1, Do not approve the release (please provide specific comments)
> >>
> >>
> >> The complete staging area is available for your review, which includes:
> >> * JIRA release notes [1],
> >> * the official Apache source release and binary convenience releases to
> be
> >> deployed to dist.apache.org [2], which are signed with the key with
> >> fingerprint 1F302569A96CFFD5 [3],
> >> * all artifacts to be deployed to the Maven Central Repository [4],
> >> * source code tag "release-1.5.0-rc3" [5],
> >>
> >> Please use this document for coordinating testing efforts: [6]
> >>
> >> Since the newly included fixes affect only individual components and are
> >> covered by tests, I will keep the voting period of the RC3 which goes at
> >> least until tomorrow 5:30pm CET. It is adopted by majority approval,
> with
> >> at least 3 PMC affirmative votes.
> >>
> >> Thanks,
> >> Your friendly Release Manager
> >>
> >> [1] https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> >> projectId=12315522=12341764
> >> [2] http://people.apache.org/~trohrmann/flink-1.5.0-rc4/
> >> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> >> [4] https://repository.apache.org/content/repositories/
> >> orgapacheflink-1159/
> >> [5] https://git-wip-us.apache.org/repos/asf?p=flink.git;a=commit;h=
> >> 953f45316b09072e76f3cf3d37d704a7cb7b32c6
> >> [6] https://docs.google.com/document/d/13evetGNVeGvSufeqC0bcfiHGS_
> >> v8n06I0p6nEtaQzS4/edit?usp=sharing
> >>
> >> Pro-tip: you can create a settings.xml file with these contents:
> >>
> >> 
> >> 
> >>  flink-1.5.0
> >> 
> >> 
> >>  
> >>flink-1.5.0
> >>
> >>  
> >>flink-1.5.0
> >>
> >>https://repository.apache.org/content/repositories/
> >> orgapacheflink-1159/
> >>
> >>  
> >>  
> >>archetype
> >>
> >>https://repository.apache.org/content/repositories/
> >> orgapacheflink-1159/
> >>
> >>  
> >>
> >>  
> >> 
> >> 
> >>
> >> And reference that in you maven commands via --settings
> >> path/to/settings.xml. This is useful for creating a quickstart based on
> the
> >> staged release and for building against the staged jars.
> >>
>
>

Re: [VOTE] Release 1.5.0, release candidate #4

2018-05-18 Thread Till Rohrmann 
Just a quick correction, I accidentally wrote that the voting period ends
tomorrow 5:30pm CET but what I actually meant was today 5:30pm CET. The
problem was that I compiled the mail before midnight.

Cheers,
Till

On Fri, May 18, 2018 at 2:50 AM, Till Rohrmann  wrote:

> Hi everyone,
>
> Please review and vote on the release candidate #4 for the version 1.5.0,
> as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
>
> The complete staging area is available for your review, which includes:
> * JIRA release notes [1],
> * the official Apache source release and binary convenience releases to be
> deployed to dist.apache.org [2], which are signed with the key with
> fingerprint 1F302569A96CFFD5 [3],
> * all artifacts to be deployed to the Maven Central Repository [4],
> * source code tag "release-1.5.0-rc3" [5],
>
> Please use this document for coordinating testing efforts: [6]
>
> Since the newly included fixes affect only individual components and are
> covered by tests, I will keep the voting period of the RC3 which goes at
> least until tomorrow 5:30pm CET. It is adopted by majority approval, with
> at least 3 PMC affirmative votes.
>
> Thanks,
> Your friendly Release Manager
>
> [1] https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12315522=12341764
> [2] http://people.apache.org/~trohrmann/flink-1.5.0-rc4/
> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> [4] https://repository.apache.org/content/repositories/
> orgapacheflink-1159/
> [5] https://git-wip-us.apache.org/repos/asf?p=flink.git;a=commit;h=
> 953f45316b09072e76f3cf3d37d704a7cb7b32c6
> [6] https://docs.google.com/document/d/13evetGNVeGvSufeqC0bcfiHGS_
> v8n06I0p6nEtaQzS4/edit?usp=sharing
>
> Pro-tip: you can create a settings.xml file with these contents:
>
> 
> 
>   flink-1.5.0
> 
> 
>   
> flink-1.5.0
> 
>   
> flink-1.5.0
> 
> https://repository.apache.org/content/repositories/
> orgapacheflink-1159/
> 
>   
>   
> archetype
> 
> https://repository.apache.org/content/repositories/
> orgapacheflink-1159/
> 
>   
> 
>   
> 
> 
>
> And reference that in you maven commands via --settings
> path/to/settings.xml. This is useful for creating a quickstart based on the
> staged release and for building against the staged jars.
>