[jira] [Commented] (FLUME-3205) Remove unnecessary 'synchronized' in ResettableFileInputStream

2017-12-27 Thread guangxian.liao (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLUME-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304570#comment-16304570
 ] 

guangxian.liao commented on FLUME-3205:
---

Hi [~bessbd],
Thank you for review this patch, I changed the code according to your comment 
in the PR.
Could you please review it again?

> Remove unnecessary 'synchronized' in ResettableFileInputStream
> --
>
> Key: FLUME-3205
> URL: https://issues.apache.org/jira/browse/FLUME-3205
> Project: Flume
>  Issue Type: Improvement
>  Components: Sinks+Sources
>Affects Versions: 1.8.0
>Reporter: guangxian.liao
>Assignee: guangxian.liao
>Priority: Minor
>
> I found no concurrent access to ResettableFileInputStream object in flume 
> code.
> Remove 'synchronized' will improve performance of SpoolDirectorySource.
> Tested with a file of 200MB，with 'synchronized' it took 9 seconds to read the 
> file.
> Without 'synchronized' it took 7 seconds. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLUME-3205) Remove unnecessary 'synchronized' in ResettableFileInputStream

2017-12-27 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/FLUME-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304434#comment-16304434
 ] 

Bessenyei Balázs Donát commented on FLUME-3205:
---

Hi [~liaoguangxian],

Thank you for the issue and the PR!

I have added you to the list of contributors. You should be able to assign the 
issue to yourself now.

I have left a comment on your PR. Please let me know what you think.


Thank you,

Donat

> Remove unnecessary 'synchronized' in ResettableFileInputStream
> --
>
> Key: FLUME-3205
> URL: https://issues.apache.org/jira/browse/FLUME-3205
> Project: Flume
>  Issue Type: Improvement
>  Components: Sinks+Sources
>Affects Versions: 1.8.0
>Reporter: guangxian.liao
>Priority: Minor
>
> I found no concurrent access to ResettableFileInputStream object in flume 
> code.
> Remove 'synchronized' will improve performance of SpoolDirectorySource.
> Tested with a file of 200MB，with 'synchronized' it took 9 seconds to read the 
> file.
> Without 'synchronized' it took 7 seconds. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLUME-3205) Remove unnecessary 'synchronized' in ResettableFileInputStream

2017-12-27 Thread guangxian.liao (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLUME-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304381#comment-16304381
 ] 

guangxian.liao commented on FLUME-3205:
---

[~hshreedharan] [~jarcec] [~bessbd] 
Any one please review this small patch and assign it to me?

> Remove unnecessary 'synchronized' in ResettableFileInputStream
> --
>
> Key: FLUME-3205
> URL: https://issues.apache.org/jira/browse/FLUME-3205
> Project: Flume
>  Issue Type: Improvement
>  Components: Sinks+Sources
>Affects Versions: 1.8.0
>Reporter: guangxian.liao
>Priority: Minor
>
> I found no concurrent access to ResettableFileInputStream object in flume 
> code.
> Remove 'synchronized' will improve performance of SpoolDirectorySource.
> Tested with a file of 200MB，with 'synchronized' it took 9 seconds to read the 
> file.
> Without 'synchronized' it took 7 seconds. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLUME-3205) Remove unnecessary 'synchronized' in ResettableFileInputStream

2017-12-26 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLUME-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303887#comment-16303887
 ] 

ASF GitHub Bot commented on FLUME-3205:
---

GitHub user Guangxian opened a pull request:

https://github.com/apache/flume/pull/192

FLUME-3205:Remove unnecessary 'synchronized' in ResettableFileInputStream

I found no concurrent access to ResettableFileInputStream object in flume 
code.
Remove 'synchronized' will improve performance of SpoolDirectorySource.
Tested with a file of 200MB，with 'synchronized' it took 9 seconds to read 
the file.
Without 'synchronized' it took 7 seconds.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Guangxian/flume flume-3205

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flume/pull/192.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #192


commit cdb6deaf7a6ee69d64d590295d44acc62834cdcc
Author: liaoguangxian 
Date:   2017-12-26T15:05:35Z

Remove unnecessary 'synchronized' in ResettableFileInputStream




> Remove unnecessary 'synchronized' in ResettableFileInputStream
> --
>
> Key: FLUME-3205
> URL: https://issues.apache.org/jira/browse/FLUME-3205
> Project: Flume
>  Issue Type: Improvement
>  Components: Sinks+Sources
>Affects Versions: 1.8.0
>Reporter: guangxian.liao
>Priority: Minor
>
> I found no concurrent access to ResettableFileInputStream object in flume 
> code.
> Remove 'synchronized' will improve performance of SpoolDirectorySource.
> Tested with a file of 200MB，with 'synchronized' it took 9 seconds to read the 
> file.
> Without 'synchronized' it took 7 seconds. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)