+1, but there are a few issue I think need to be addressed in future releases:
Issue #1: I'm not sure if this is worth downvoting for or not, but I saw that our integration test module is creating both a regular artifact and a `-tests` artifact. This is bad practice and should be fixed at some point, but the main issue here is that there is no `-javadoc` artifact (because there's no code in src/main/java). The ITs should really be moved from src/test/java to src/main/java for the IT module, and we should discuss whether we want to ship the IT module at all when we deploy. Issue #2: fluo-cluster jar contains a log4j.xml and a logback.xml file. I think it's generally bad to ship log configuration inside jars... because it can corrupt the class path and confuse users when it does. Are these necessary, or should they be removed? Other things I checked: * LICENSE/NOTICE files look fine * source tarball matches git branch / sha1 (minus generated DEPENDENCIES file) * hashes/signatures look fine * other jars have corresponding javadoc and sources jars * project builds with ITs * phrasecount, webindex, and stresso build against this version fine with ITs. On Fri, Feb 23, 2018 at 1:57 PM Mike Walch <mwa...@apache.org> wrote: > +1 > > * Verified sha1 & md5 hashes matched > * Verified signatures > * Ran 'mvn verify' for Fluo Recipes (using Accumuo 1.7.3) and Webindex > using RC > * Successfully ran phrasecount application locally using Uno & Fluo 1.2.0 > RC tarball > > On Wed, Feb 21, 2018 at 4:45 PM, Christopher <ctubb...@apache.org> wrote: > > > Fluo Developers, > > > > I finally had a chance to prep a release candidate for 1.2.0-rc1! Yay! > > Please consider the following candidate for Fluo 1.2.0. > > > > Git Commit: > > 678adebfbd97483bbef7707b6ac5eb357540dea3 > > Branch: > > 1.2.0-rc1 > > > > If this vote passes, a gpg-signed tag will be created using: > > git tag -f -m 'Apache Fluo 1.2.0' -s rel/fluo-1.2.0 \ > > 678adebfbd97483bbef7707b6ac5eb357540dea3 > > > > Staging repo: > > https://repository.apache.org/content/repositories/orgapachefluo-1023 > > Source (official release artifact): > > https://repository.apache.org/content/repositories/orgapache > > fluo-1023/org/apache/fluo/fluo/1.2.0/fluo-1.2.0-source-release.tar.gz > > Binary: > > https://repository.apache.org/content/repositories/orgapache > > fluo-1023/org/apache/fluo/fluo/1.2.0/fluo-1.2.0-bin.tar.gz > > (Append ".sha1", ".md5", or ".asc" to download the signature/hash for a > > given artifact.) > > > > All artifacts were built and staged with: > > mvn release:prepare && mvn release:perform > > > > Signing keys are available at https://www.apache.org/dist/fluo/KEYS > > (Expected fingerprint: 8CC4F8A2B29C2B040F2B835D6F0CDAE700B6899D) > > > > Release notes (in progress) can be found at: > > https://fluo.apache.org/release/fluo-1.2.0/ > > > > Please vote one of: > > [ ] +1 - I have verified and accept... > > [ ] +0 - I have reservations, but not strong enough to vote against... > > [ ] -1 - Because..., I do not accept... > > ... these artifacts as the 1.2.0 release of Apache Fluo. > > > > This vote will remain open until at least Sat Feb 24 22:00:00 UTC 2018 > (Sat > > Feb 24 17:00:00 EST 2018 / Sat Feb 24 14:00:00 PST 2018). > > Voting can continue after this deadline until the release manager sends > an > > email ending the vote. > > > > Thanks! > > > > P.S. Hint: download the whole staging repo with > > wget -erobots=off -r -l inf -np -nH \ > > > https://repository.apache.org/content/repositories/orgapachefluo-1023/ > > # note the trailing slash is needed > > >
