Re: [VOTE] Fluo 1.2.0-rc1

2018-02-26 Thread Mike Walch
> Issue #2: > > fluo-cluster jar contains a log4j.xml and a logback.xml file. I think it's > generally bad to ship log configuration inside jars... because it can > corrupt the class path and confuse users when it does. Are these necessary, > or should they be removed? > Both files existed inside

Re: [VOTE] Fluo 1.2.0-rc1

2018-02-26 Thread Keith Turner
On Mon, Feb 26, 2018 at 10:04 AM, Mike Walch wrote: >> Issue #2: >> >> fluo-cluster jar contains a log4j.xml and a logback.xml file. I think it's >> generally bad to ship log configuration inside jars... because it can >> corrupt the class path and confuse users when it does.

Re: [VOTE] Fluo 1.2.0-rc1

2018-02-26 Thread Keith Turner
On Sun, Feb 25, 2018 at 6:13 PM, Christopher wrote: > +1, but there are a few issue I think need to be addressed in future > releases: > > Issue #1: > > I'm not sure if this is worth downvoting for or not, but I saw that our > integration test module is creating both a

[RESULT][VOTE] Fluo 1.2.0-rc1

2018-02-26 Thread Christopher
Okay, this vote passes with 3 +1s, and no other votes, with some possible issues to follow up with. On Mon, Feb 26, 2018 at 10:07 AM Keith Turner wrote: > On Mon, Feb 26, 2018 at 10:04 AM, Mike Walch wrote: > >> Issue #2: > >> > >> fluo-cluster jar contains