Re: [VOTE] Fluo Recipes 1.0.0-incubating-rc0

Keith Turner wrote: On Thu, Oct 20, 2016 at 6:36 PM, Christopher wrote: > I don't think it technically failed, because majority vote only needs > more +1 than -1, and at least 3 voting. But, since you've created rc1, I'm > going to interpret this vote as withdrawn in

Re: [VOTE] Fluo Recipes 1.0.0-incubating-rc0

On Tue, Oct 18, 2016 at 6:29 PM, Christopher wrote: > -1 > > * Reviewed signatures, hashes > * Commit matches tarball (with the exception of the generated DEPENDENCIES > file, which is created by the maven-remote-resources-plugin) > * Builds fine with tests, but with a

Re: [VOTE] Fluo Recipes 1.0.0-incubating-rc0

-1 * Reviewed signatures, hashes * Commit matches tarball (with the exception of the generated DEPENDENCIES file, which is created by the maven-remote-resources-plugin) * Builds fine with tests, but with a compiler warning about unused auto-closeable in FluoSparkHelperIT.java which should be

Re: [VOTE] Fluo Recipes 1.0.0-incubating-rc0

I'm reviewing this now, but wanted to mention that the branch didn't match the commit (it was one commit ahead), so I just now pushed a rollback of that 1 commit to the rc0 branch, and I staged that extra commit to an rc0-next branch. On Tue, Oct 18, 2016 at 2:24 PM Josh Elser

Re: [VOTE] Fluo Recipes 1.0.0-incubating-rc0

On Tue, Oct 18, 2016 at 1:37 PM Josh Elser wrote: > Keith Turner wrote: > >> * Saw libthrift in the parent pom.xml, but could not see usages of that > >> > anywhere in the child modules. (not a release issue, just curious) > > > > Its in the dep mgmt section. The reason

Re: [VOTE] Fluo Recipes 1.0.0-incubating-rc0

On Tue, Oct 18, 2016 at 1:37 PM, Josh Elser wrote: > Keith Turner wrote: >>> >>> * Saw libthrift in the parent pom.xml, but could not see usages of that >>> > anywhere in the child modules. (not a release issue, just curious) >> >> >> Its in the dep mgmt section. The

Re: [VOTE] Fluo Recipes 1.0.0-incubating-rc0

Keith Turner wrote: * Saw libthrift in the parent pom.xml, but could not see usages of that > anywhere in the child modules. (not a release issue, just curious) Its in the dep mgmt section. The reason is its needed to build recipes against accumulo 1.8.0. Fluo also uses thrift and depends

Re: [VOTE] Fluo Recipes 1.0.0-incubating-rc0

On Tue, Oct 18, 2016 at 12:20 PM, Josh Elser wrote: > +1 > > * xsums/sigs OK > * Can build and run tests > * No binaries in source release > * mvn apache-rat:check passes (no exclusions) > * DISCLAIMER present > * L are good > * README looks good. > > Some comments: > > *

Re: [VOTE] Fluo Recipes 1.0.0-incubating-rc0

+1 * xsums/sigs OK * Can build and run tests * No binaries in source release * mvn apache-rat:check passes (no exclusions) * DISCLAIMER present * L are good * README looks good. Some comments: * Keith, you could consider adding your apache.org email addr to your key. Not required, but a nice

Re: [VOTE] Fluo Recipes 1.0.0-incubating-rc0

+1 * Sigs on all artifacts check out * Source tar contents match commit * Successfully ran mvn verify for stress, webindex, and phrasecount use staging repo On Mon, Oct 17, 2016 at 2:08 PM, Keith Turner wrote: > Fluo Developers, > > Please consider the following candidate

Re: [VOTE] Fluo Recipes 1.0.0-incubating-rc0

On Mon, Oct 17, 2016 at 7:46 PM, Christopher wrote: > Were you intending this to be a vote thread or just a test? By convention, I was intending it to be a test, but as I looked at it I could not find any problems. So I decided to try voting on it. > I usually reserve rc0

Re: [VOTE] Fluo Recipes 1.0.0-incubating-rc0

Were you intending this to be a vote thread or just a test? By convention, I usually reserve rc0 for test of the release process itself, and rc1+ for actual release candidates... but you may have something else in mind. I just want to be sure before I prioritize testing this RC over other stuffs.