[jira] [Commented] (GEARPUMP-339) Improve ScalaDoc for all public classes

2017-08-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115669#comment-16115669 ] ASF GitHub Bot commented on GEARPUMP-339: - Github user manuzhang commented on the issue:

[jira] [Commented] (GEARPUMP-339) Improve ScalaDoc for all public classes

2017-08-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115668#comment-16115668 ] ASF GitHub Bot commented on GEARPUMP-339: - GitHub user manuzhang opened a pull request:

[jira] [Commented] (GEARPUMP-339) Improve ScalaDoc for all public classes

2017-08-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115826#comment-16115826 ] ASF GitHub Bot commented on GEARPUMP-339: - Github user huafengw commented on the issue:

[jira] [Commented] (GEARPUMP-339) Improve ScalaDoc for all public classes

2017-08-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115825#comment-16115825 ] ASF GitHub Bot commented on GEARPUMP-339: - Github user huafengw commented on a diff in the pull

[GitHub] incubator-gearpump pull request #212: [GEARPUMP-339] Add ScalaDoc to Streami...

2017-08-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-gearpump/pull/212 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-gearpump issue #212: [GEARPUMP-339] Add ScalaDoc to Streaming DSL

2017-08-06 Thread manuzhang
Github user manuzhang commented on the issue: https://github.com/apache/incubator-gearpump/pull/212 R: @huafengw --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] incubator-gearpump pull request #212: [GEARPUMP-339] Add ScalaDoc to Streami...

2017-08-06 Thread manuzhang
GitHub user manuzhang opened a pull request: https://github.com/apache/incubator-gearpump/pull/212 [GEARPUMP-339] Add ScalaDoc to Streaming DSL Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the commit

[GitHub] incubator-gearpump pull request #212: [GEARPUMP-339] Add ScalaDoc to Streami...

2017-08-06 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/212#discussion_r131545040 --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/dsl/scalaapi/StreamApp.scala --- @@ -62,6 +62,17 @@ class StreamApp(

[GitHub] incubator-gearpump issue #212: [GEARPUMP-339] Add ScalaDoc to Streaming DSL

2017-08-06 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/212 Generally LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Commented] (GEARPUMP-339) Improve ScalaDoc for all public classes

2017-08-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115949#comment-16115949 ] ASF GitHub Bot commented on GEARPUMP-339: - Github user asfgit closed the pull request at: