[GitHub] incubator-gearpump issue #213: [GEARPUMP-339] Add ScalaDoc to window api and...

Github user manuzhang commented on the issue: https://github.com/apache/incubator-gearpump/pull/213 R: @huafengw --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] incubator-gearpump pull request #213: [GEARPUMP-339] Add ScalaDoc to window ...

GitHub user manuzhang opened a pull request: https://github.com/apache/incubator-gearpump/pull/213 [GEARPUMP-339] Add ScalaDoc to window api and impl Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the

[GitHub] incubator-gearpump issue #213: [GEARPUMP-339] Add ScalaDoc to window api and...

Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/213 No unit test failed, so where does the failure come from? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (GEARPUMP-339) Improve ScalaDoc for all public classes

[ https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125124#comment-16125124 ] ASF GitHub Bot commented on GEARPUMP-339: - Github user manuzhang commented on the issue:

[jira] [Commented] (GEARPUMP-339) Improve ScalaDoc for all public classes

[ https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125135#comment-16125135 ] ASF GitHub Bot commented on GEARPUMP-339: - Github user manuzhang commented on the issue:

[GitHub] incubator-gearpump issue #213: [GEARPUMP-339] Add ScalaDoc to window api and...

Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/213 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] incubator-gearpump pull request #213: [GEARPUMP-339] Add ScalaDoc to window ...

Github user manuzhang commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/213#discussion_r132863203 --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/dsl/window/impl/WindowRunner.scala --- @@ -137,11 +156,14 @@ class

[GitHub] incubator-gearpump pull request #213: [GEARPUMP-339] Add ScalaDoc to window ...

Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/213#discussion_r132863041 --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/dsl/window/impl/WindowRunner.scala --- @@ -137,11 +156,14 @@ class

[GitHub] incubator-gearpump issue #213: [GEARPUMP-339] Add ScalaDoc to window api and...

Github user manuzhang commented on the issue: https://github.com/apache/incubator-gearpump/pull/213 Maybe it's killed after hanging since it took longer than usual. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (GEARPUMP-339) Improve ScalaDoc for all public classes

[ https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125143#comment-16125143 ] ASF GitHub Bot commented on GEARPUMP-339: - Github user huafengw commented on the issue:

[jira] [Commented] (GEARPUMP-339) Improve ScalaDoc for all public classes

[ https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125128#comment-16125128 ] ASF GitHub Bot commented on GEARPUMP-339: - Github user huafengw commented on a diff in the pull

[jira] [Commented] (GEARPUMP-339) Improve ScalaDoc for all public classes

[ https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125202#comment-16125202 ] ASF GitHub Bot commented on GEARPUMP-339: - Github user asfgit closed the pull request at:

[jira] [Commented] (GEARPUMP-339) Improve ScalaDoc for all public classes

[ https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124939#comment-16124939 ] ASF GitHub Bot commented on GEARPUMP-339: - Github user huafengw commented on the issue: