[
https://issues.apache.org/jira/browse/GEARPUMP-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166186#comment-16166186
]
ASF GitHub Bot commented on GEARPUMP-349:
-
Github user huafengw commented on a diff in the pull
[
https://issues.apache.org/jira/browse/GEARPUMP-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166188#comment-16166188
]
ASF GitHub Bot commented on GEARPUMP-349:
-
Github user huafengw commented on a diff in the pull
[
https://issues.apache.org/jira/browse/GEARPUMP-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166201#comment-16166201
]
ASF GitHub Bot commented on GEARPUMP-349:
-
Github user manuzhang commented on a diff in the pull
[
https://issues.apache.org/jira/browse/GEARPUMP-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166339#comment-16166339
]
ASF GitHub Bot commented on GEARPUMP-349:
-
Github user manuzhang commented on the issue:
[
https://issues.apache.org/jira/browse/GEARPUMP-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166159#comment-16166159
]
ASF GitHub Bot commented on GEARPUMP-349:
-
Github user manuzhang commented on a diff in the pull
[
https://issues.apache.org/jira/browse/GEARPUMP-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166139#comment-16166139
]
ASF GitHub Bot commented on GEARPUMP-349:
-
Github user manuzhang commented on a diff in the pull
[
https://issues.apache.org/jira/browse/GEARPUMP-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166152#comment-16166152
]
ASF GitHub Bot commented on GEARPUMP-349:
-
Github user manuzhang commented on a diff in the pull
[
https://issues.apache.org/jira/browse/GEARPUMP-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166199#comment-16166199
]
ASF GitHub Bot commented on GEARPUMP-349:
-
Github user manuzhang commented on a diff in the pull
[
https://issues.apache.org/jira/browse/GEARPUMP-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166157#comment-16166157
]
ASF GitHub Bot commented on GEARPUMP-349:
-
Github user manuzhang commented on a diff in the pull
[
https://issues.apache.org/jira/browse/GEARPUMP-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166191#comment-16166191
]
ASF GitHub Bot commented on GEARPUMP-349:
-
Github user huafengw commented on a diff in the pull
[
https://issues.apache.org/jira/browse/GEARPUMP-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166167#comment-16166167
]
ASF GitHub Bot commented on GEARPUMP-349:
-
Github user manuzhang commented on a diff in the pull
[
https://issues.apache.org/jira/browse/GEARPUMP-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166164#comment-16166164
]
ASF GitHub Bot commented on GEARPUMP-349:
-
Github user manuzhang commented on a diff in the pull
[
https://issues.apache.org/jira/browse/GEARPUMP-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166177#comment-16166177
]
ASF GitHub Bot commented on GEARPUMP-349:
-
Github user manuzhang commented on the issue:
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/223#discussion_r138875971
--- Diff: core/src/main/scala/org/apache/gearpump/util/Graph.scala ---
@@ -243,13 +259,34 @@ class Graph[N, E](vertexList: List[N], edgeList:
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/223#discussion_r138876553
--- Diff: core/src/main/scala/org/apache/gearpump/util/Graph.scala ---
@@ -318,11 +355,12 @@ class Graph[N, E](vertexList: List[N], edgeList:
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/223#discussion_r138876219
--- Diff: core/src/main/scala/org/apache/gearpump/util/Graph.scala ---
@@ -355,19 +393,7 @@ class Graph[N, E](vertexList: List[N], edgeList:
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/223
We also do an extra check for cycle here. Can it be removed ?
```scala
if (dag.hasCycle()) {
LOG.warn(s"Detected cycles in DAG of application $name!")
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/223#discussion_r138884320
--- Diff: core/src/main/scala/org/apache/gearpump/util/Graph.scala ---
@@ -355,19 +393,7 @@ class Graph[N, E](vertexList: List[N], edgeList:
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/223#discussion_r138882103
--- Diff: core/src/main/scala/org/apache/gearpump/util/Graph.scala ---
@@ -355,19 +393,7 @@ class Graph[N, E](vertexList: List[N], edgeList:
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/223#discussion_r138875439
--- Diff: core/src/main/scala/org/apache/gearpump/util/Graph.scala ---
@@ -28,6 +29,8 @@ class Graph[N, E](vertexList: List[N], edgeList:
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/223#discussion_r138875669
--- Diff: core/src/main/scala/org/apache/gearpump/util/Graph.scala ---
@@ -165,7 +181,7 @@ class Graph[N, E](vertexList: List[N], edgeList:
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/223#discussion_r138873545
--- Diff: core/src/main/scala/org/apache/gearpump/util/Graph.scala ---
@@ -81,28 +86,35 @@ class Graph[N, E](vertexList: List[N], edgeList:
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/223#discussion_r138876832
--- Diff: core/src/main/scala/org/apache/gearpump/util/Graph.scala ---
@@ -243,13 +259,34 @@ class Graph[N, E](vertexList: List[N], edgeList:
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/223#discussion_r138881132
--- Diff: core/src/main/scala/org/apache/gearpump/util/Graph.scala ---
@@ -243,13 +259,34 @@ class Graph[N, E](vertexList: List[N], edgeList:
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/223#discussion_r138880775
--- Diff: core/src/main/scala/org/apache/gearpump/util/Graph.scala ---
@@ -81,28 +86,35 @@ class Graph[N, E](vertexList: List[N], edgeList:
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/223#discussion_r138883853
--- Diff: core/src/main/scala/org/apache/gearpump/util/Graph.scala ---
@@ -243,13 +259,34 @@ class Graph[N, E](vertexList: List[N], edgeList:
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/223#discussion_r138879455
--- Diff: core/src/main/scala/org/apache/gearpump/util/Graph.scala ---
@@ -28,6 +29,8 @@ class Graph[N, E](vertexList: List[N], edgeList:
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/223#discussion_r138880939
--- Diff: core/src/main/scala/org/apache/gearpump/util/Graph.scala ---
@@ -165,7 +181,7 @@ class Graph[N, E](vertexList: List[N], edgeList:
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/223
Verified Beam ValidatesRunnerTests can be run much faster now.
---
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/223#discussion_r139061587
--- Diff: core/src/main/scala/org/apache/gearpump/util/Graph.scala ---
@@ -243,13 +258,36 @@ class Graph[N, E](vertexList: List[N], edgeList:
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/223#discussion_r139049164
--- Diff: core/src/main/scala/org/apache/gearpump/util/Graph.scala ---
@@ -81,28 +86,35 @@ class Graph[N, E](vertexList: List[N], edgeList:
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/223#discussion_r139049560
--- Diff: core/src/main/scala/org/apache/gearpump/util/Graph.scala ---
@@ -156,64 +155,64 @@ class Graph[N, E](vertexList: List[N], edgeList:
[
https://issues.apache.org/jira/browse/GEARPUMP-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167218#comment-16167218
]
ASF GitHub Bot commented on GEARPUMP-349:
-
Github user manuzhang commented on a diff in the pull
[
https://issues.apache.org/jira/browse/GEARPUMP-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167222#comment-16167222
]
ASF GitHub Bot commented on GEARPUMP-349:
-
Github user huafengw commented on a diff in the pull
[
https://issues.apache.org/jira/browse/GEARPUMP-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167223#comment-16167223
]
ASF GitHub Bot commented on GEARPUMP-349:
-
Github user manuzhang commented on a diff in the pull
[
https://issues.apache.org/jira/browse/GEARPUMP-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166179#comment-16166179
]
ASF GitHub Bot commented on GEARPUMP-349:
-
Github user manuzhang commented on a diff in the pull
[
https://issues.apache.org/jira/browse/GEARPUMP-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166185#comment-16166185
]
ASF GitHub Bot commented on GEARPUMP-349:
-
Github user huafengw commented on a diff in the pull
37 matches
Mail list logo
