Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/31
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/37
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user huafengw opened a pull request:
https://github.com/apache/incubator-gearpump/pull/24
fix GEARPUMP_114 fix dead loop in graph with cycles
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/huafengw/incubator-gearpump
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/39
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user huafengw commented on the pull request:
https://github.com/apache/incubator-gearpump/pull/23#issuecomment-221764757
Updated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user huafengw opened a pull request:
https://github.com/apache/incubator-gearpump/pull/26
fix GEARPUMP-150 correct the integration test file structure
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/huafengw/incubator
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/25#discussion_r64864833
--- Diff:
external/kafka/src/main/scala/org/apache/gearpump/streaming/kafka/lib/source/AbstractKafkaSource.scala
---
@@ -0,0 +1,173
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/25#discussion_r64865492
--- Diff:
examples/streaming/kafka/src/main/scala/org/apache/gearpump/streaming/examples/kafka/KafkaReadWrite.scala
---
@@ -60,14 +64,19
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/31#discussion_r65495393
--- Diff:
daemon/src/main/scala/org/apache/gearpump/cluster/master/AppManager.scala ---
@@ -310,22 +320,20 @@ private[cluster] class AppManager
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/31#discussion_r65495140
--- Diff:
daemon/src/main/scala/org/apache/gearpump/cluster/master/AppManager.scala ---
@@ -268,9 +275,9 @@ private[cluster] class AppManager
Github user huafengw commented on the pull request:
https://github.com/apache/incubator-gearpump/pull/25#issuecomment-222614486
UT failed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/41
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/44
+1
I'm OK with that, could you please squash the commits @karol-brejna-i ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/42
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/45
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/50
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/49
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/48
Unfortunately, I can't reproduce the problem, here is what I've done:
I work with gearpump 0.8.0 and included the change. I launch the yarn
cluster with user ```huafeng``` and launch
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/50
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/7#discussion_r61231840
--- Diff:
streaming/src/main/scala/io/gearpump/streaming/source/DataSource.scala ---
@@ -29,10 +29,12 @@ import io.gearpump.{Message, TimeStamp
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/7#discussion_r61232328
--- Diff:
external/kafka/src/main/scala/io/gearpump/streaming/kafka/KafkaSource.scala ---
@@ -168,21 +169,11 @@ class KafkaSource(
tp
GitHub user huafengw opened a pull request:
https://github.com/apache/incubator-gearpump/pull/3
fix GEARPUMP-35 Worker's JVM metrics is not shown correctly
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/huafengw/incubator
Github user huafengw commented on the pull request:
https://github.com/apache/incubator-gearpump/pull/21#issuecomment-219899833
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user huafengw commented on the pull request:
https://github.com/apache/incubator-gearpump/pull/20#issuecomment-219916439
That's overriding Java's default serialization implementation:
```
There is, however, a strange yet crafty solution. By using a built
GitHub user huafengw opened a pull request:
https://github.com/apache/incubator-gearpump/pull/23
fix GEARPUMP-117 add scripts to start and stop the cluster
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/huafengw/incubator
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/23#discussion_r64197132
--- Diff: bin/gear-daemon.sh ---
@@ -0,0 +1,128 @@
+#!/usr/bin/env bash
+
+USAGE="Usage: gear-daemon.sh (start|stop|stop-all) (
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/11#discussion_r63815402
--- Diff: project/BuildExample.scala ---
@@ -229,4 +229,20 @@ object BuildExample extends sbt.Build {
CrossVersion.binaryScalaVersion
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/11#discussion_r63824440
--- Diff: project/BuildExample.scala ---
@@ -229,4 +229,20 @@ object BuildExample extends sbt.Build {
CrossVersion.binaryScalaVersion
Github user huafengw commented on the pull request:
https://github.com/apache/incubator-gearpump/pull/13#issuecomment-220235782
Hi, @darionyaphet please rebase your pr and I will merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user huafengw commented on the pull request:
https://github.com/apache/incubator-gearpump/pull/16#issuecomment-218987433
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user huafengw opened a pull request:
https://github.com/apache/incubator-gearpump/pull/9
fix GEARPUMP-108 enable travis CI for Gearpump's apache repository
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/huafengw
GitHub user huafengw opened a pull request:
https://github.com/apache/incubator-gearpump/pull/14
fix GEARPUMP-118 change package name to org.apache
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/huafengw/incubator-gearpump
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/67#discussion_r72413298
--- Diff:
examples/streaming/kafka/src/main/scala/org/apache/gearpump/streaming/examples/kafka/KafkaWriter.scala
---
@@ -0,0 +1,106
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/67#discussion_r72412383
--- Diff:
streaming/src/main/scala/org/apache/gearpump/streaming/source/DataSourceTask.scala
---
@@ -46,23 +46,39 @@ class DataSourceTask
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/67#discussion_r72412991
--- Diff:
examples/streaming/kafka/src/main/scala/org/apache/gearpump/streaming/examples/kafka/KafkaReadWrite.scala
---
@@ -86,4 +90,30
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/67#discussion_r72413816
--- Diff:
external/kafka/src/main/scala/org/apache/gearpump/streaming/kafka/lib/source/AbstractKafkaSource.scala
---
@@ -92,6 +91,7 @@ abstract
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/64
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/48
@karol-brejna-i you mean /etc/passwd and /etc/group?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user huafengw opened a pull request:
https://github.com/apache/incubator-gearpump/pull/58
fix GEARPUMP-174 update shaded akka-kryo version to 0.4.1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/huafengw/incubator
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/61
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/53#discussion_r68906960
--- Diff: project/Build.scala ---
@@ -104,6 +99,7 @@ object Build extends sbt.Build {
System.getenv().get("SONATYPE_PAS
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/53
travis build fail
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/46
Seems the logo is too large:(
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/74
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/74
So we are not considering backward compatibility?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/138
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/139
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/140#discussion_r99815386
--- Diff:
streaming/src/main/scala/org/apache/gearpump/streaming/dsl/window/api/WindowFunction.scala
---
@@ -33,11 +33,19 @@ object
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/140
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/140#discussion_r99813902
--- Diff:
streaming/src/main/scala/org/apache/gearpump/streaming/dsl/window/api/WindowFunction.scala
---
@@ -33,11 +33,19 @@ object
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/134#discussion_r97253953
--- Diff:
core/src/main/scala/org/apache/gearpump/cluster/client/RunningApplication.scala
---
@@ -18,17 +18,21 @@
package
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/134#discussion_r97253035
--- Diff:
core/src/main/scala/org/apache/gearpump/cluster/AppDescription.scala ---
@@ -142,4 +138,25 @@ case class ExecutorContext(
case
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/134#discussion_r97287682
--- Diff:
core/src/main/scala/org/apache/gearpump/cluster/client/RunningApplication.scala
---
@@ -40,6 +44,16 @@ class RunningApplication(val
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/134#discussion_r97287804
--- Diff:
core/src/main/scala/org/apache/gearpump/cluster/client/RunningApplication.scala
---
@@ -18,17 +18,21 @@
package
GitHub user huafengw opened a pull request:
https://github.com/apache/incubator-gearpump/pull/152
[GEARPUMP-275] Remove obsolete examples of 'stockcrawler' and 'transpâ¦
â¦ort'
Be sure to do all of the following to help us incorporate your contribution
quickly
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/151
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user huafengw opened a pull request:
https://github.com/apache/incubator-gearpump/pull/153
[GEARPUMP-276] Remove ununsed 'shade' folder
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the commit
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/154
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/155
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/151
That's it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/159
Can you give some backgrounds?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user huafengw opened a pull request:
https://github.com/apache/incubator-gearpump/pull/160
[GEARPUMP-282] Allow user to configure wait duration for a running apâ¦
â¦plication
Be sure to do all of the following to help us incorporate your contribution
quickly
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/159
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user huafengw opened a pull request:
https://github.com/apache/incubator-gearpump/pull/156
[GEARPUMP-277] Allow user to configure retry times on application faiâ¦
â¦lure
Be sure to do all of the following to help us incorporate your contribution
quickly
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/143#discussion_r100454422
--- Diff:
streaming/src/main/scala/org/apache/gearpump/streaming/task/TaskActor.scala ---
@@ -247,7 +247,11 @@ class TaskActor
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/143
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user huafengw opened a pull request:
https://github.com/apache/incubator-gearpump/pull/146
[GEARPUMP-270] disable 'Kill' button when applciation is not running
Be sure to do all of the following to help us incorporate your contribution
quickly and easily
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/142
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/142#discussion_r100256683
--- Diff:
examples/streaming/state/src/main/scala/org/apache/gearpump/streaming/examples/state/processor/CountProcessor.scala
---
@@ -37,7
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/150
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user huafengw opened a pull request:
https://github.com/apache/incubator-gearpump/pull/133
GEARPUMP-252 return meaningful result than app id when submitting appâ¦
â¦lication in ClientContext
Be sure to do all of the following to help us incorporate your
GitHub user huafengw opened a pull request:
https://github.com/apache/incubator-gearpump/pull/134
[GEARPUMP-265] remove AppMasterRuntimeInfo from AppMasterContext
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/133
@manuzhang
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/133#discussion_r96557102
--- Diff:
core/src/main/scala/org/apache/gearpump/cluster/client/ClientContext.scala ---
@@ -53,20 +55,21 @@ class ClientContext(config: Config
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/136
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/137
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/67
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/67
I'm considering since now every Source task has the watermark logic but
they still have to
send a start WaterMark in `onStart` and a continue WaterMark in `onNext` to
self, almost
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/67#discussion_r75613138
--- Diff:
examples/streaming/state/src/main/scala/org/apache/gearpump/streaming/examples/state/processor/NumberGeneratorProcessor.scala
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/161
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/162#discussion_r103385452
--- Diff: integrationtest/docker/kafka/README.md ---
@@ -0,0 +1,89 @@
+Kafka in Docker
+===
+
+**This is a fork spotify/kafka
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/162#discussion_r103382851
--- Diff: integrationtest/docker/java/README.md ---
@@ -0,0 +1,18 @@
+A minimalistic Oracle JDK 8 container on top of busybox.
+
+We
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/162#discussion_r103382701
--- Diff: integrationtest/docker/README.md ---
@@ -1,28 +1,23 @@
-# Gearpump Launcher Docker Image
-
-The image helps developer
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/158
Hi Karol, this pull request includes the former GEARPUMP-236 and it's also
covered by your another pr, so maybe we can close this one?
---
If your project is set up for it, you can
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/162
Hi Karol, would you mind do some code modification in
org.apache.gearpump.integrationtest.Docker.scala, change the implementation of
`getNetworkGateway` to
```
final def
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/162
+1 Merging
Thanks Karol!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/78#discussion_r77101042
--- Diff:
examples/streaming/wordcount/src/main/scala/org/apache/gearpump/streaming/examples/wordcount/Split.scala
---
@@ -23,29 +23,34
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/78#discussion_r77100932
--- Diff:
examples/streaming/wordcount/src/main/scala/org/apache/gearpump/streaming/examples/wordcount/Split.scala
---
@@ -23,29 +23,34
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/79
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/80
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user huafengw opened a pull request:
https://github.com/apache/incubator-gearpump/pull/81
fix GEARPUMP-205 remove hdfs dependency from gear's classpath
raise the pr to use travis UT
You can merge this pull request into a Git repository by running:
$ git pull https
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/55
Sorry it took so long.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/82
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/83
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/90
@karol-brejna-i
Hi Karol, please help to review this pr.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user huafengw opened a pull request:
https://github.com/apache/incubator-gearpump/pull/90
fix GEARPUMP-144 make the user for HDFS and Yarn configurable in yarnâ¦
â¦client
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/86#discussion_r80175062
--- Diff:
external/hbase/src/main/scala/org/apache/gearpump/external/hbase/HBaseSink.scala
---
@@ -115,15 +116,24 @@ object HBaseSink
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/86
One question, now the `connection` is a transient value, will there be a
NPE after the HBaseSink deserialized?
---
If your project is set up for it, you can reply to this email and have
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/86
Generally my question is that is there any way implementing the
HBaseSinkSpec without changing the HBaseSink?
---
If your project is set up for it, you can reply to this email and have
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/86#discussion_r79978331
--- Diff:
external/hbase/src/main/scala/org/apache/gearpump/external/hbase/HBaseSink.scala
---
@@ -19,39 +19,47 @@ package
1 - 100 of 221 matches
Mail list logo