[jira] [Commented] (GEARPUMP-295) Get stalling tasks from clock service failed
[ https://issues.apache.org/jira/browse/GEARPUMP-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976207#comment-15976207 ] ASF GitHub Bot commented on GEARPUMP-295: - Github user asfgit closed the pull request at: https://github.com/apache/incubator-gearpump/pull/174 > Get stalling tasks from clock service failed > > > Key: GEARPUMP-295 > URL: https://issues.apache.org/jira/browse/GEARPUMP-295 > Project: Apache Gearpump > Issue Type: Bug >Reporter: Huafeng Wang >Assignee: Huafeng Wang >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEARPUMP-295) Get stalling tasks from clock service failed
[ https://issues.apache.org/jira/browse/GEARPUMP-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976191#comment-15976191 ] ASF GitHub Bot commented on GEARPUMP-295: - Github user manuzhang commented on the issue: https://github.com/apache/incubator-gearpump/pull/174 +1 > Get stalling tasks from clock service failed > > > Key: GEARPUMP-295 > URL: https://issues.apache.org/jira/browse/GEARPUMP-295 > Project: Apache Gearpump > Issue Type: Bug >Reporter: Huafeng Wang >Assignee: Huafeng Wang >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEARPUMP-295) Get stalling tasks from clock service failed
[ https://issues.apache.org/jira/browse/GEARPUMP-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975980#comment-15975980 ] ASF GitHub Bot commented on GEARPUMP-295: - Github user manuzhang commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/174#discussion_r112357813 --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/appmaster/ClockService.scala --- @@ -261,7 +261,8 @@ class ClockService( case GetCheckpointClock => sender ! CheckpointClock(minCheckpointClock) -case GetStallingTasks => +// Please do not remove the `getStalling` +case getStalling: GetStallingTasks => --- End diff -- If the field of `GetStallingTasks` is never used, we'd better turn it into a case object > Get stalling tasks from clock service failed > > > Key: GEARPUMP-295 > URL: https://issues.apache.org/jira/browse/GEARPUMP-295 > Project: Apache Gearpump > Issue Type: Bug >Reporter: Huafeng Wang >Assignee: Huafeng Wang >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEARPUMP-295) Get stalling tasks from clock service failed
[ https://issues.apache.org/jira/browse/GEARPUMP-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15968723#comment-15968723 ] ASF GitHub Bot commented on GEARPUMP-295: - Github user manuzhang commented on the issue: https://github.com/apache/incubator-gearpump/pull/174 Let's wait for 0.8.3 release. > Get stalling tasks from clock service failed > > > Key: GEARPUMP-295 > URL: https://issues.apache.org/jira/browse/GEARPUMP-295 > Project: Apache Gearpump > Issue Type: Bug >Reporter: Huafeng Wang >Assignee: Huafeng Wang >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEARPUMP-295) Get stalling tasks from clock service failed
[ https://issues.apache.org/jira/browse/GEARPUMP-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15968707#comment-15968707 ] ASF GitHub Bot commented on GEARPUMP-295: - Github user codecov-io commented on the issue: https://github.com/apache/incubator-gearpump/pull/174 # [Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/174?src=pr&el=h1) Report > Merging [#174](https://codecov.io/gh/apache/incubator-gearpump/pull/174?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gearpump/commit/0da453c9203cf1cf1833f86a68871f862de1357d?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master#174 +/- ## == Coverage71.6% 71.6% == Files 191 191 Lines60866086 Branches 527 527 == Hits 43584358 Misses 17281728 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/174?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/174?src=pr&el=footer). Last update [0da453c...3daeacc](https://codecov.io/gh/apache/incubator-gearpump/pull/174?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). > Get stalling tasks from clock service failed > > > Key: GEARPUMP-295 > URL: https://issues.apache.org/jira/browse/GEARPUMP-295 > Project: Apache Gearpump > Issue Type: Bug >Reporter: Huafeng Wang >Assignee: Huafeng Wang >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEARPUMP-295) Get stalling tasks from clock service failed
[ https://issues.apache.org/jira/browse/GEARPUMP-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15968696#comment-15968696 ] ASF GitHub Bot commented on GEARPUMP-295: - GitHub user huafengw opened a pull request: https://github.com/apache/incubator-gearpump/pull/174 [GEARPUMP-295] Fix the failure of getting stalling tasks from clock s… …ervice Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the commit message is formatted like: `[GEARPUMP-] Meaningful description of pull request` - [ ] Make sure tests pass via `sbt clean test`. - [ ] Make sure old documentation affected by the pull request has been updated and new documentation added for new functionality. You can merge this pull request into a Git repository by running: $ git pull https://github.com/huafengw/incubator-gearpump stalling Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-gearpump/pull/174.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #174 commit 3daeaccc1f1f7967bab95f78fdf1430bf82849fc Author: huafengw Date: 2017-04-14T06:43:24Z [GEARPUMP-295] Fix the failure of getting stalling tasks from clock service > Get stalling tasks from clock service failed > > > Key: GEARPUMP-295 > URL: https://issues.apache.org/jira/browse/GEARPUMP-295 > Project: Apache Gearpump > Issue Type: Bug >Reporter: Huafeng Wang >Assignee: Huafeng Wang >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
