[jira] [Commented] (GEARPUMP-358) Performance regression due to costly watermark calculation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEARPUMP-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209408#comment-16209408
 ] 

ASF GitHub Bot commented on GEARPUMP-358:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-gearpump/pull/232


> Performance regression due to costly watermark calculation
> --
>
> Key: GEARPUMP-358
> URL: https://issues.apache.org/jira/browse/GEARPUMP-358
> Project: Apache Gearpump
>  Issue Type: Bug
>Reporter: Huafeng Wang
> Fix For: 0.8.5
>
>
> For example, in streaming example SOL, everytime SOLStreamProducer output a 
> message to downstream, it will send a Watermark message to itself, which will 
> trigger watermark calculation. We should avoid flooding Watermark messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEARPUMP-358) Performance regression due to costly watermark calculation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEARPUMP-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209406#comment-16209406
 ] 

ASF GitHub Bot commented on GEARPUMP-358:
-

Github user manuzhang commented on the issue:

https://github.com/apache/incubator-gearpump/pull/232
  
LGTM


> Performance regression due to costly watermark calculation
> --
>
> Key: GEARPUMP-358
> URL: https://issues.apache.org/jira/browse/GEARPUMP-358
> Project: Apache Gearpump
>  Issue Type: Bug
>Reporter: Huafeng Wang
>
> For example, in streaming example SOL, everytime SOLStreamProducer output a 
> message to downstream, it will send a Watermark message to itself, which will 
> trigger watermark calculation. We should avoid flooding Watermark messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEARPUMP-358) Performance regression due to costly watermark calculation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEARPUMP-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209175#comment-16209175
 ] 

ASF GitHub Bot commented on GEARPUMP-358:
-

Github user codecov-io commented on the issue:

https://github.com/apache/incubator-gearpump/pull/232
  
# 
[Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/232?src=pr=h1)
 Report
> Merging 
[#232](https://codecov.io/gh/apache/incubator-gearpump/pull/232?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-gearpump/commit/175b08e64c3363a2da9c61e05dac5f01d1f8db2d?src=pr=desc)
 will **decrease** coverage by `0.04%`.
> The diff coverage is `40%`.



```diff
@@Coverage Diff @@
##   master #232  +/-   ##
==
- Coverage   69.01%   68.96%   -0.05% 
==
  Files 191  191  
  Lines6119 6123   +4 
  Branches  358  357   -1 
==
  Hits 4223 4223  
- Misses   1896 1900   +4
```




> Performance regression due to costly watermark calculation
> --
>
> Key: GEARPUMP-358
> URL: https://issues.apache.org/jira/browse/GEARPUMP-358
> Project: Apache Gearpump
>  Issue Type: Bug
>Reporter: Huafeng Wang
>
> For example, in streaming example SOL, everytime SOLStreamProducer output a 
> message to downstream, it will send a Watermark message to itself, which will 
> trigger watermark calculation. We should avoid flooding Watermark messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEARPUMP-358) Performance regression due to costly watermark calculation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEARPUMP-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209161#comment-16209161
 ] 

ASF GitHub Bot commented on GEARPUMP-358:
-

GitHub user huafengw opened a pull request:

https://github.com/apache/incubator-gearpump/pull/232

[GEARPUMP-358] Decrease the frequency of watermark calculation

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the commit message is formatted like:
   `[GEARPUMP-] Meaningful description of pull request` 
 - [ ] Make sure tests pass via `sbt clean test`.
 - [ ] Make sure old documentation affected by the pull request has been 
updated and new documentation added for new functionality. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/huafengw/incubator-gearpump regre

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-gearpump/pull/232.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #232


commit 3456bfcfe1fa643f37dedbb88c6e4090d6df5823
Author: huafengw 
Date:   2017-10-18T11:19:44Z

[GEARPUMP-358] Decrease the frequency of watermark calculation




> Performance regression due to costly watermark calculation
> --
>
> Key: GEARPUMP-358
> URL: https://issues.apache.org/jira/browse/GEARPUMP-358
> Project: Apache Gearpump
>  Issue Type: Bug
>Reporter: Huafeng Wang
>
> For example, in streaming example SOL, everytime SOLStreamProducer output a 
> message to downstream, it will send a Watermark message to itself, which will 
> trigger watermark calculation. We should avoid flooding Watermark messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEARPUMP-358) Performance regression due to costly watermark calculation

[Manu Zhang (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEARPUMP-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207755#comment-16207755
 ] 

Manu Zhang commented on GEARPUMP-358:
-

I don't think it's the message that has caused regression since we previously 
sent message to self as well. Nonetheless, we should avoid watermark 
calculation on each message. Maybe an update interval like that between 
TaskActor and ClockService will do ?

> Performance regression due to costly watermark calculation
> --
>
> Key: GEARPUMP-358
> URL: https://issues.apache.org/jira/browse/GEARPUMP-358
> Project: Apache Gearpump
>  Issue Type: Bug
>Reporter: Huafeng Wang
>
> For example, in streaming example SOL, everytime SOLStreamProducer output a 
> message to downstream, it will send a Watermark message to itself, which will 
> trigger watermark calculation. We should avoid flooding Watermark messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)