[GitHub] geode-native pull request #115: GEODE-3165: Reogranized sources relative to ...

2017-08-11 Thread dgkimura
Github user dgkimura commented on a diff in the pull request: https://github.com/apache/geode-native/pull/115#discussion_r132739636 --- Diff: CMakeLists.txt --- @@ -242,7 +242,7 @@ add_subdirectory(dhimpl) add_subdirectory(sqliteimpl) add_subdirectory(tests)

Re: []DISCUSS] Using package names to identify public API's

2017-08-11 Thread Ernest Burghardt
+1 for protobuf being internal as they are not intended to be first class OO citizens you can read more about there here (the same warning exists for all supported languages btw) On Fri, Aug 11, 2017 at 12:34 PM, Michael William

[GitHub] geode pull request #707: GEODE-3412: Add simple authentication flow to proto...

2017-08-11 Thread kohlmu-pivotal
Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/707#discussion_r132737475 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionConfig.java --- @@ -2433,6 +2433,25 @@ String

[GitHub] geode pull request #707: GEODE-3412: Add simple authentication flow to proto...

2017-08-11 Thread kohlmu-pivotal
Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/707#discussion_r132735527 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java --- @@ -63,6 +65,31 @@ private static

[GitHub] geode pull request #707: GEODE-3412: Add simple authentication flow to proto...

2017-08-11 Thread kohlmu-pivotal
Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/707#discussion_r132735728 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java --- @@ -72,9 +99,15 @@ public static

Re: [DISCUSS] New annotation to identify Functions whose class hierarchy spans multiple jar files

2017-08-11 Thread John Blum
Hi Jared- In general, I like this idea since Annotations are a great form of meta-data and essentially meaningless outside of the intended context and therefore do not impose any adverse effects on any existing behavior. However, 2 things... 1 suggestion and 1 caution... 1. Perhaps

[GitHub] geode-native issue #115: GEODE-3165: Reogranized sources relative to the roo...

2017-08-11 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on the issue: https://github.com/apache/geode-native/pull/115 @dgkimura which CMake find modules are you referring to? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] geode-native pull request #115: GEODE-3165: Reogranized sources relative to ...

2017-08-11 Thread dgkimura
Github user dgkimura commented on a diff in the pull request: https://github.com/apache/geode-native/pull/115#discussion_r132757951 --- Diff: CMakeLists.txt --- @@ -242,7 +242,7 @@ add_subdirectory(dhimpl) add_subdirectory(sqliteimpl) add_subdirectory(tests)

[GitHub] geode-native issue #115: GEODE-3165: Reogranized sources relative to the roo...

2017-08-11 Thread dgkimura
Github user dgkimura commented on the issue: https://github.com/apache/geode-native/pull/115 @pivotal-jbarrett I was referring to `FindNativeClient.cmake` and `FindNativeClientCPPCache.cmake`. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] geode pull request #707: GEODE-3412: Add simple authentication flow to proto...

2017-08-11 Thread kohlmu-pivotal
Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/707#discussion_r132738771 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java --- @@ -63,6 +65,31 @@ private static

[GitHub] geode pull request #707: GEODE-3412: Add simple authentication flow to proto...

2017-08-11 Thread kohlmu-pivotal
Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/707#discussion_r132738100 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/NoOpStreamAuthenticator.java --- @@ -0,0 +1,43 @@ +/* + *

[GitHub] geode pull request #707: GEODE-3412: Add simple authentication flow to proto...

2017-08-11 Thread kohlmu-pivotal
Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/707#discussion_r132737182 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java --- @@ -1378,6 +1379,18 @@ */ String NAME

Re: []DISCUSS] Using package names to identify public API's

2017-08-11 Thread Kirk Lund
One nice thing about releasing new code in *internal* packages is that we can always move them out of the *internal* packages at a later date but we cannot move non-deprecated code from external API packages into *internal* packages without worrying about backwards compatibility. On Fri, Aug 11,

Re: Gitbox enables the full GitHub workflow

2017-08-11 Thread Ernest Burghardt
+1 On Wed, Aug 9, 2017 at 2:57 PM, Nabarun Nag wrote: > +1 > > will this allow us to choose reviewers while creating PRs on github now? > > Regards > Nabarun > > On Wed, Aug 9, 2017 at 1:19 PM Udo Kohlmeyer > wrote: > > > +1 > > > > > > On 8/9/17 12:56,

Re: Review Request 61562: GEODE-3423: Provide support for running parallel docker builds in Jenkins

2017-08-11 Thread Anthony Baker
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61562/#review182715 --- Ship it! Ship It! - Anthony Baker On Aug. 10, 2017, 9:16

[]DISCUSS] Using package names to identify public API's

2017-08-11 Thread Anthony Baker
We have policies in place for versioning [1] and backwards compatibility [2]. How do we identify which API’s need to be controlled? In many cases we use the *.internal.* package naming format to signal API’s that aren’t subject to backwards compatibility requirements. API’s within these

Re: []DISCUSS] Using package names to identify public API's

2017-08-11 Thread Michael William Dodge
The user shouldn't need to access any of the protobuf classes directly. I'm in favor of making all of the protobuf-related packages internal, including any classes generated from .proto files. Sarge > On 11 Aug, 2017, at 11:30, Anthony Baker wrote: > > We have policies in

Re: []DISCUSS] Using package names to identify public API's

2017-08-11 Thread Kirk Lund
+1 to continue using *internal* to differentiate code from external APIs The alternative would require Geode to be more modular, in which we have the external API in API- or SPI-specific jars and then the "internal" packages go into an implementation jar that needs to be on the classpath during

[GitHub] geode pull request #708: GEODE-3410 Doc update for gfsh query command change...

2017-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/708 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #706: GEODE-3304: when colocated child bucket is destroye...

2017-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/706 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode-native pull request #115: GEODE-3165: Reogranized sources relative to ...

2017-08-11 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/115#discussion_r132755738 --- Diff: CMakeLists.txt --- @@ -242,7 +242,7 @@ add_subdirectory(dhimpl) add_subdirectory(sqliteimpl) add_subdirectory(tests)

[GitHub] geode-examples pull request #13: GEODE-3428: Add example of putting multiple...

2017-08-11 Thread PivotalSarge
GitHub user PivotalSarge opened a pull request: https://github.com/apache/geode-examples/pull/13 GEODE-3428: Add example of putting multiple values all at once. Add an example of `Region.putAll()`. You can merge this pull request into a Git repository by running: $ git pull

Re: Gitbox enables the full GitHub workflow

2017-08-11 Thread Jacob Barrett
The geode-native synch from ASF to GitHub is stuck again and while we are waiting for Infra to make the fix it occurred to me it might be more productive to have them just move us to GitBox. We have another big commit coming that will likely break the commit again. Does anyone object to

[DISCUSS] New annotation to identify Functions whose class hierarchy spans multiple jar files

2017-08-11 Thread Jared Stewart
Recent changes introduced to avoid the eager loading of classes have lead to Functions not getting registered correctly if the class hierarchy leading up to Function (or FunctionAdapter) is split up across multiple jar files. We propose to introduce a new annotation to identify functions in

[GitHub] geode issue #698: Mark ProtoBuf interface as experimental

2017-08-11 Thread galen-pivotal
Github user galen-pivotal commented on the issue: https://github.com/apache/geode/pull/698 What you've done looks good. However, it looks like there are ten or so files in `geode-protobuf` that you didn't mark as experimental. Is there a reason for this? Have a look at the

[GitHub] geode pull request #682: GEODE-3393: One-way SSL authentication fails with F...

2017-08-11 Thread galen-pivotal
Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/682#discussion_r132626571 --- Diff: geode-core/src/main/java/org/apache/geode/internal/admin/SSLConfig.java --- @@ -33,11 +34,11 @@ private String ciphers =

[GitHub] geode pull request #609: GEODE-2886 : sent IllegalStateException instead of ...

2017-08-11 Thread ameybarve15
Github user ameybarve15 commented on a diff in the pull request: https://github.com/apache/geode/pull/609#discussion_r132678804 --- Diff: geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesIntegrationTest.java --- @@ -331,6 +331,29 @@ public void

[GitHub] geode-native issue #115: GEODE-3165: Reogranized sources relative to the roo...

2017-08-11 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on the issue: https://github.com/apache/geode-native/pull/115 @dgkimura https://issues.apache.org/jira/browse/GEODE-3432 Anything else you don't like? --- If your project is set up for it, you can reply to this email and have your reply

Re: Geode Native - All your globals are belong to us

2017-08-11 Thread Kirk Lund
Congratulations and thank you! On Fri, Aug 11, 2017 at 1:23 PM, Jacob Barrett wrote: > In case you missed the big commit recently, the Geode Native components has > removed all globals.* > > The biggest win here is that we can more easily unit test sections of the > code

[GitHub] geode pull request #694: GEODE-3270: Refactoring (renaming) StatusCommands

2017-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/694 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #695: GEODE-3267: Refactoring QueueCommands

2017-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/695 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #651: GEODE-3230: Cleaning up unused (Cli)Strings

2017-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/651 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode-native issue #115: GEODE-3165: Reogranized sources relative to the roo...

2017-08-11 Thread dgkimura
Github user dgkimura commented on the issue: https://github.com/apache/geode-native/pull/115 @pivotal-jbarrett: Ship-it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] geode pull request #685: GEODE-3261: Refactoring GfshHelpCommands

2017-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/685 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode issue #699: GEODE-3413: overhaul launcher and process classes and test...

2017-08-11 Thread kirklund
Github user kirklund commented on the issue: https://github.com/apache/geode/pull/699 Merged this PR to develop. Done! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-11 Thread kirklund
Github user kirklund closed the pull request at: https://github.com/apache/geode/pull/699 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode issue #672: GEODE-3256: Refactoring DataCommands

2017-08-11 Thread YehEmily
Github user YehEmily commented on the issue: https://github.com/apache/geode/pull/672 Already merged to develop. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] geode pull request #693: GEODE-3268: Refactoring RegionCommands

2017-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/693 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode-native pull request #115: GEODE-3165: Reogranized sources relative to ...

2017-08-11 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/115#discussion_r132769880 --- Diff: CMakeLists.txt --- @@ -242,7 +242,7 @@ add_subdirectory(dhimpl) add_subdirectory(sqliteimpl) add_subdirectory(tests)

[GitHub] geode pull request #671: GEODE-3255: Refactor CreateAlterDestroyRegionComman...

2017-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/671 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #672: GEODE-3256: Refactoring DataCommands

2017-08-11 Thread YehEmily
Github user YehEmily closed the pull request at: https://github.com/apache/geode/pull/672 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Review Request 61563: GEODE-3383: Refactor deploy tests

2017-08-11 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61563/ --- (Updated Aug. 11, 2017, 9:52 p.m.) Review request for geode, Emily Yeh, Jared

Re: Geode Native - All your globals are belong to us

2017-08-11 Thread Udo Kohlmeyer
Awesome work!!! On 8/11/17 13:23, Jacob Barrett wrote: In case you missed the big commit recently, the Geode Native components has removed all globals.* The biggest win here is that we can more easily unit test sections of the code that before was nearly impossible due to reliance on

[GitHub] geode pull request #680: GEODE-3257: Refactoring DeployCommands

2017-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/680 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #696: GEODE-3265: Refactoring MiscellaneousCommands

2017-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/696 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #704: GEODE-3300: Complete and expose parallel export fea...

2017-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/704 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode-native issue #115: GEODE-3165: Reogranized sources relative to the roo...

2017-08-11 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on the issue: https://github.com/apache/geode-native/pull/115 @dgkimura Those files actually need to be redone in a way more closely aligned with other CMake find modules. I would leave them alone for now and fix later. --- If your project is

Geode Native - All your globals are belong to us

2017-08-11 Thread Jacob Barrett
In case you missed the big commit recently, the Geode Native components has removed all globals.* The biggest win here is that we can more easily unit test sections of the code that before was nearly impossible due to reliance on initialized global instances of Cache, DistributedSystem,

[GitHub] geode pull request #684: GEODE-3266: Refactoring PDXCommands

2017-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/684 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode-native issue #114: GEODE-2729: Remove global variables

2017-08-11 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on the issue: https://github.com/apache/geode-native/pull/114 This was merged without auto-close comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

Review Request 61599: GEODE-3328: fix a test failure on windows.

2017-08-11 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61599/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and

Re: [DISCUSS] New annotation to identify Functions whose class hierarchy spans multiple jar files

2017-08-11 Thread Jared Stewart
Hi John, Thanks for the suggestions. I like “@RegisterableFunction” better than “@RegisterFunction". I think that we don’t want @RegisterableFunction to be @Inherited, in order to avoid creating a new variant of the problem we are trying to fix. As you suggest, we should be mindful to

BCSnapshotDUnitTest failing

2017-08-11 Thread Kirk Lund
BCSnapshotDUnitTest seems to be failing intermittently(?) on develop. :pivotalgf-assembly:distributedTest org.apache.geode.BCSnapshotDUnitTest > testSnapshot[0] FAILED org.apache.geode.test.dunit.RMIException: While invoking org.apache.geode.BCSnapshotDUnitTest$1.run in VM 0 running on Host

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #644 was SUCCESSFUL (with 2027 tests)

2017-08-11 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #644 was successful. --- Scheduled 2029 tests in total. https://build.spring.io/browse/SGF-NAG-644/ -- This

Re: Review Request 61599: GEODE-3328: fix a test failure on windows.

2017-08-11 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61599/#review182758 --- Ship it! Replacing hardcoded path strings with system

[GitHub] geode pull request #690: GEODE-3262: Refactoring IndexCommands

2017-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/690 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #710: GEODE-3435: Fix serialization test failure

2017-08-11 Thread nreich
GitHub user nreich opened a pull request: https://github.com/apache/geode/pull/710 GEODE-3435: Fix serialization test failure This pull request it to fix an issue introduced in GEODE-3300 that caused AnalyzeSerializablesJUnitTest to fail. You can merge this pull request into a Git

[GitHub] geode pull request #710: GEODE-3435: Fix serialization test failure

2017-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/710 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Build failed in Jenkins: Geode-nightly-flaky #88

2017-08-11 Thread Apache Jenkins Server
See Changes: [dbarnes] GEODE-3328 Properties to set Key/Trust Store Type for SSL configuration [huynhja] GEODE-3397: Fixed issue with Tomcat locators in cache-client.xml file [jiliao] GEODE-3328: refactor

[GitHub] geode pull request #687: GEODE-3258: Refactoring DiskStoreCommands

2017-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/687 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

ParallelSnapshotFileMapper broke AnalyzeSerializablesJUnitTest

2017-08-11 Thread Kirk Lund
Looks like one of the recent commits to develop resulted in this failure involving org/apache/geode/internal/cache/snapshot/ParallelSnapshotFileMapper... :geode-core:integrationTest org.apache.geode.codeAnalysis.AnalyzeSerializablesJUnitTest > testSerializables FAILED

[GitHub] geode pull request #689: GEODE-3259: Refactoring DurableClientCommands

2017-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/689 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #692: GEODE-3264: Refactoring MemberCommands

2017-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/692 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #665: GEODE-3254: Refactoring ConfigCommands and ConfigCo...

2017-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/665 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: ParallelSnapshotFileMapper broke AnalyzeSerializablesJUnitTest

2017-08-11 Thread Kirk Lund
Looks like it was this commit... commit 7072f8ef7b764d1507e26cca8ed0c4d184ccc81a Author: Nick Reich Date: Fri Jul 28 16:47:10 2017 -0700 GEODE-3300: Complete and expose parallel export feature for use This closes #704 On Fri, Aug 11, 2017 at 3:40 PM, Kirk Lund

[GitHub] geode pull request #691: GEODE-3260: Refactoring FunctionCommands

2017-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/691 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #709: GEODE-3269: Refactoring ShellCommands

2017-08-11 Thread YehEmily
GitHub user YehEmily opened a pull request: https://github.com/apache/geode/pull/709 GEODE-3269: Refactoring ShellCommands [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3269) - [x] Is there a JIRA ticket associated with this PR? Is it referenced

Build failed in Jenkins: Geode-nightly #920

2017-08-11 Thread Apache Jenkins Server
See Changes: [jstewart] GEODE-3313: Test utility supports building jar files with multiple [dbarnes] GEODE-3111 GatewayReceiver - DEFAULT_MANUAL_START value is ambiguous [dbarnes] GEODE-3328 Properties to set

Re: BCSnapshotDUnitTest failing

2017-08-11 Thread Kirk Lund
Yep you're right. Thanks Mark! Too bad there's no delete in email... On Fri, Aug 11, 2017 at 4:31 PM, Mark Bretl wrote: > Hi Kirk, > > There is no 'pivotalgf-assembly' project in Geode. Looks like it is part of > a different distribution. ;) > > --Mark > > On Fri, Aug 11,

Management tests failing on develop

2017-08-11 Thread Kirk Lund
I merged in 16 PRs today and precheckin was clean for each individually. I launched a precheckin after all were merged in and that seems to have tons of Management test failures. So on Monday, I'll try to identify which PRs aren't playing nicely with each other and start backing them out. Sorry

Re: Review Request 61599: GEODE-3328: fix a test failure on windows.

2017-08-11 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61599/#review182759 --- Ship it! Ship It! - Jared Stewart On Aug. 11, 2017, 10:42

Re: [DISCUSS] New annotation to identify Functions whose class hierarchy spans multiple jar files

2017-08-11 Thread Kirk Lund
I can't even say "RegisterableFunction" flibble flobble ;) On Fri, Aug 11, 2017 at 4:09 PM, Jared Stewart wrote: > Hi John, > > Thanks for the suggestions. I like “@RegisterableFunction” better than > “@RegisterFunction". I think that we don’t want @RegisterableFunction to

[GitHub] geode pull request #701: GEODE-3337: Refactoring LauncherLifecycleCommandsDU...

2017-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/701 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: BCSnapshotDUnitTest failing

2017-08-11 Thread Mark Bretl
Hi Kirk, There is no 'pivotalgf-assembly' project in Geode. Looks like it is part of a different distribution. ;) --Mark On Fri, Aug 11, 2017 at 4:09 PM, Kirk Lund wrote: > BCSnapshotDUnitTest seems to be failing intermittently(?) on develop. > >

[GitHub] geode-native pull request #115: GEODE-3165: Reogranized sources relative to ...

2017-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode-native/pull/115 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: ParallelSnapshotFileMapper broke AnalyzeSerializablesJUnitTest

2017-08-11 Thread Nick Reich
I have created GEODE-3435 to fix the issue. On Fri, Aug 11, 2017 at 3:41 PM, Kirk Lund wrote: > Looks like it was this commit... > > commit 7072f8ef7b764d1507e26cca8ed0c4d184ccc81a > Author: Nick Reich > Date: Fri Jul 28 16:47:10 2017 -0700 > >

[GitHub] geode issue #467: GEODE-258: Remove deprecated Cache.getLoggerI18n and getSe...

2017-08-11 Thread davinash
Github user davinash commented on the issue: https://github.com/apache/geode/pull/467 Thanks @kirklund and @upthewaterspout for your comments. I am moving this discussion on JIRA GEODE-258 and more questions. --- If your project is set up for it, you can reply to this email and

[GitHub] geode-examples pull request #12: Add OQL example

2017-08-11 Thread PivotalSarge
Github user PivotalSarge closed the pull request at: https://github.com/apache/geode-examples/pull/12 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] geode-native pull request #115: GEODE-3165: Reogranized sources relative to ...

2017-08-11 Thread pivotal-jbarrett
GitHub user pivotal-jbarrett opened a pull request: https://github.com/apache/geode-native/pull/115 GEODE-3165: Reogranized sources relative to the root for better CMake … IDE integration. - Moved src/docs to docs/api. - Moved src/* to root. - Fixup paths in CMake

Re: Review Request 61540: GEODE-3403: Modify rolling upgrade test configuration for 1.2.x release

2017-08-11 Thread Bruce Schuchardt
> On Aug. 10, 2017, noon, Udo Kohlmeyer wrote: > > geode-core/src/main/java/org/apache/geode/internal/Version.java > > Line 205 (original), 210 (patched) > > > > > > what is the correlation between this and

Re: Review Request 61540: GEODE-3403: Modify rolling upgrade test configuration for 1.2.x release

2017-08-11 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61540/#review182706 --- Ship it! Ship It! - Udo Kohlmeyer On Aug. 9, 2017, 8:45

Re: Review Request 61540: GEODE-3403: Modify rolling upgrade test configuration for 1.2.x release

2017-08-11 Thread Udo Kohlmeyer
> On Aug. 10, 2017, 7 p.m., Udo Kohlmeyer wrote: > > geode-core/src/main/java/org/apache/geode/internal/Version.java > > Line 205 (original), 210 (patched) > > > > > > what is the correlation between this and