Re: [DISCUSS] - Create new repository for geode benchmarks

2018-11-16 Thread Juan José Ramos
+1 On Thu, Nov 15, 2018 at 8:22 PM Udo Kohlmeyer wrote: > +1, never thought there was any other option... > > > On 11/15/18 10:47, Dan Smith wrote: > > Hi all, > > > > We (Naba, Sean, Brian and I) would like to add some benchmarks for geode, > > with a goal of eventually running them as part of

Re: [DISCUSS] - Create new repository for geode benchmarks

2018-11-16 Thread Dan Smith
Hi Kirk, What we're thinking of putting in geode-benchmarks are new, multi host benchmarks of the full system with the public APIs, not microbenchmarks. We weren't planning on doing anything with the JMH benchmarks at the moment. I agree with you those should stay in the geode module they are

Re: [DISCUSS] - Create new repository for geode benchmarks

2018-11-16 Thread Kirk Lund
That makes sense for some benchmarks but not others. For example, while working on the Logging changes, I wrote a some benchmarks that directly use some new internal code to ensure that the new changes perform well. +1 to creating a benchmarks repo that has general perf tests that will be run in

Re: Questions about Poms and Publishing

2018-11-16 Thread Robert Houghton
Thanks John. Do you foresee the native Gradle DSL https://docs.gradle.org/current/userguide/managing_transitive_dependencies.html as an *eventual* replacement for the dependency-management-plugin you reference? On Tue, Nov 13, 2018 at 9:09 AM John Blum wrote: > If you'd like Maven

Re: Questions about Poms and Publishing

2018-11-16 Thread John Blum
Good question, and that may be a better question for Andy Wilkinson to answer since Andy created the Gradle dependencyManagement plugin. We/I use it quite extensively and with good results. On Fri, Nov 16, 2018 at 9:38 AM Robert Houghton wrote: > Thanks John. > > Do you foresee the native

Re: [DISCUSS] - Create new repository for geode benchmarks

2018-11-16 Thread Kirk Lund
+1 total agreement then! On Fri, Nov 16, 2018 at 10:05 AM Dan Smith wrote: > Hi Kirk, > > What we're thinking of putting in geode-benchmarks are new, multi host > benchmarks of the full system with the public APIs, not microbenchmarks. We > weren't planning on doing anything with the JMH

Re: Spring detecting MockPluginCommand and logging WARN in integration tests

2018-11-16 Thread Kirk Lund
Yep! I have a fixed version now that will not fail due to springshell. On Fri, Nov 16, 2018 at 1:07 PM Jens Deppe wrote: > If this test is already applying a custom log configuration, could it not > also turn down the logging for org.springframework.shell? > > --Jens > > On Fri, Nov 16, 2018 at

Re: Spring detecting MockPluginCommand and logging WARN in integration tests

2018-11-16 Thread Kirk Lund
I checked the DUnit grep for suspect strings and it's ignore WARNING log level. So we may DUnit tests that are generating the same warning log from org.springframework.shell.core.CommandMarker without causing any tests to fail. On Fri, Nov 16, 2018 at 12:43 PM Kirk Lund wrote: > The new logging

Re: Spring detecting MockPluginCommand and logging WARN in integration tests

2018-11-16 Thread Jens Deppe
If this test is already applying a custom log configuration, could it not also turn down the logging for org.springframework.shell? --Jens On Fri, Nov 16, 2018 at 12:53 PM Kirk Lund wrote: > I checked the DUnit grep for suspect strings and it's ignore WARNING log > level. So we may DUnit tests

Spring detecting MockPluginCommand and logging WARN in integration tests

2018-11-16 Thread Kirk Lund
The new logging tests assert that when you create a Cache, there are no WARN log statements being logged. Unfortunately, src/tests (unit tests) is in the classpath of integration tests (CacheWithCustomLogConfigIntegrationTest is an integration test). Apparently springshell gets kicked on when we

Re: [DISCUSS] - Create new repository for geode benchmarks

2018-11-16 Thread Kenneth Howe
+1 to Dan’s proposal - just makes sense > On Nov 16, 2018, at 10:05 AM, Dan Smith wrote: > > Hi Kirk, > > What we're thinking of putting in geode-benchmarks are new, multi host > benchmarks of the full system with the public APIs, not microbenchmarks. We > weren't planning on doing anything

Re: [DISCUSS] Deprecating JUnit4CacheTestCase (and maybe JUnit4DistributedTestCase?)

2018-11-16 Thread Galen O'Sullivan
I have a PR up to deprecate these classes and several other distributed test classes that use inheritance (I actually forgot to mention it here when I first put it up, whoops): https://github.com/apache/geode/pull/2841 I intend to merge it Monday evening if there are no objections. I think I'll

Re: GEODE Slack?

2018-11-16 Thread Kirk Lund
https://join.slack.com/t/the-asf/shared_invite/enQtNDQ3OTEwNzE1MDg5LWY2NjkwMTEzMGI2ZTI1NzUzMDk0MzJmMWM1NWVmODg0MzBjNjAxYzUwMjIwNDI3MjlhZWRjNmNhOTM5NmIxNDk #geode On Fri, Nov 16, 2018 at 3:22 PM Ernest Burghardt wrote: > Hi Geode, > > Will there be a GEODE Slack in the near future? > > Thanks,

Re: GEODE Slack?

2018-11-16 Thread Nabarun Nag
It’s already present. You can find it at http://the-asf.slack.com/ On Fri, Nov 16, 2018 at 3:22 PM Ernest Burghardt wrote: > Hi Geode, > > Will there be a GEODE Slack in the near future? > > Thanks, > EB > -- Regards Nabarun Nag

GEODE Slack?

2018-11-16 Thread Ernest Burghardt
Hi Geode, Will there be a GEODE Slack in the near future? Thanks, EB