Hello all,
I'm having some trouble assigning tickets to myself and closing them in
JIRA. Can someone grant me the appropriate permissions. My username is:
WireBaron
Thanks,
-Brian
ternal/tcp/ConnectionTableTest.java
Line 54 (original), 70 (patched)
<https://reviews.apache.org/r/61411/#comment258000>
Add a when(connection.isReceiverStopped()).thenReturn(false);
- Brian Rowe
On Aug. 3, 2017, 6:59 p.m., Hitesh Kh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61420/#review182179
---
Ship it!
Ship It!
- Brian Rowe
On Aug. 3, 2017, 10:07 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61540/#review182617
---
Ship it!
Ship It!
- Brian Rowe
On Aug. 9, 2017, 8:45 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60856/#review180500
---
Ship it!
Ship It!
- Brian Rowe
On July 13, 2017, 11:28 p.m
Can someone with the relevant karma please grant me edit permissions on
cwiki.apache.org/confluence. My username there is browe.
Thanks,
-Brian
t;
> > This has nothing to do with the ProtobufOpsProcessor. Maybe the builder
> > can be passed in.
>
> Brian Rowe wrote:
> Hmm, I'm not sure I agree. The ProtobufOpsProcessor has to generate the
> ClientProtocol.Response containing the response from the operation ha
`ErrorMessage`, that would contain the `exceptionCode`
> > and `errorMessage`.
This has been removed.
- Brian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60486/#r
test covering new operations
Thanks,
Brian Rowe
/3/
Changes: https://reviews.apache.org/r/60526/diff/2-3/
Testing
---
This change is just adding a test.
Thanks,
Brian Rowe
ps://reviews.apache.org/r/60526/#review179943
-------
On July 7, 2017, 10:16 p.m., Brian Rowe wrote:
>
> ---
> This is an automatically generated e-mail.
/resources/org/apache/geode/protocol/default.keystore
PRE-CREATION
Diff: https://reviews.apache.org/r/60526/diff/2/
Changes: https://reviews.apache.org/r/60526/diff/1-2/
Testing
---
This change is just adding a test.
Thanks,
Brian Rowe
e=1771594#file1771594line48>
> >
> > Empty putAll does nothing. I don't believe we should log an error.
Fixed.
- Brian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org
t; > geode-protobuf/src/main/proto/region_API.proto
> > Line 102 (original), 109 (patched)
> > <https://reviews.apache.org/r/60629/diff/1/?file=1768757#file1768757line109>
> >
> > As raised earlier, how about `GetAvailableRegions`?
See my response to that com
/1/
Testing
---
Thanks,
Brian Rowe
0718/diff/1/?file=1771596#file1771596line141>
> >
> > could we possibly use `addAllFailedKeys(java.lang.Iterable > org.apache.geode.protocol.protobuf.BasicTypes.EncodedValue> values)`
This got removed with the failed keys field.
- Brian
---
This is an automatically generated e-mail. T
/operations/PutAllRequestOperationHandlerJUnitTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/60718/diff/3/
Changes: https://reviews.apache.org/r/60718/diff/2-3/
Testing
---
Added unit tests for new operation handlers
Added integration test covering new operations
Thanks,
Brian Rowe
://reviews.apache.org/r/60718/diff/4/
Changes: https://reviews.apache.org/r/60718/diff/3-4/
Testing
---
Added unit tests for new operation handlers
Added integration test covering new operations
Thanks,
Brian Rowe
/operations/PutAllRequestOperationHandlerJUnitTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/60718/diff/2/
Changes: https://reviews.apache.org/r/60718/diff/1-2/
Testing
---
Added unit tests for new operation handlers
Added integration test covering new operations
Thanks,
Brian Rowe
gt;
>
> On Wed, Jul 12, 2017 at 1:45 PM, Brian Rowe <br...@pivotal.io> wrote:
>
>>
>>
>> > On July 7, 2017, 11:51 p.m., Udo Kohlmeyer wrote:
>> > > geode-protobuf/src/main/java/org/apache/geode/protocol/proto
>> buf/operations/PutAllRequestOperationH
eviews.apache.org/r/60718/#review180212
---
On July 12, 2017, 6:27 p.m., Brian Rowe wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60718/
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60718/#review180349
---
On July 12, 2017, 6:27 p.m., Brian Rowe wrote:
>
>
improvement).
- Brian Rowe
On June 28, 2017, 11:06 p.m., Bruce Schuchardt wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
---
This change is just adding a test.
Thanks,
Brian Rowe
ine46>
> >
> > This is too specific... What about all the other encoding types?
> > Int,long,short,byte?
We discussed templatizing this to make it more generally useful, but decided
that since this is a test utility it wasn't really worth making
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60550/#review179374
---
Ship it!
Ship It!
- Brian Rowe
On June 29, 2017, 9:39 p.m
Diff: https://reviews.apache.org/r/60629/diff/1/
Testing
---
Protobuf tests impacted by these changes have been refactored to check for
error responses.
Thanks,
Brian Rowe
mment253397>
Typo, s/loators/locators
geode-core/src/main/java/org/apache/geode/internal/cache/PoolFactoryImpl.java
Lines 308 (patched)
<https://reviews.apache.org/r/60312/#comment253399>
remove this
- Brian Rowe
On June
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60629/#review179796
---
On July 3, 2017, 11:40 p.m., Brian Rowe wrote:
>
> --
-lucene, there is some per-region configuration that
gets added to cache.xml files. Is there any global configuration?
Thanks,
Brian Rowe and Galen O'Sullivan
nes 62 (patched)
<https://reviews.apache.org/r/61672/#comment259091>
Does this call do anything? serverConnection is a mock and you haven't told
it how to handle this call.
- Brian Rowe
On Aug. 15, 2017, 8:46 p.m., Bruce Schu
inal), 39 (patched)
<https://reviews.apache.org/r/60217/#comment252354>
Alright, I'll leave that for that batch of work then
- Brian Rowe
On June 20, 2017, 12:17 a.m., Brian Rowe wrote:
>
> ---
&g
---
Precheckin in progress. Unit tests added for all new classes, integration test
added for entire module.
Thanks,
Brian Rowe
/CodecRegistryJUnitTest.java
PRE-CREATION
gradle/rat.gradle 1bea5843b
settings.gradle c0fdb6e4f
Diff: https://reviews.apache.org/r/60217/diff/1/
Testing
---
Precheckin in progress. Unit tests added for all new classes, integration test
added for entire module.
Thanks,
Brian Rowe
for entire module.
Thanks,
Brian Rowe
in progress.
Thanks,
Brian Rowe
test, precheckin in progress.
Thanks,
Brian Rowe
)
-
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
9658f98da
Diff: https://reviews.apache.org/r/59863/diff/2/
Changes: https://reviews.apache.org/r/59863/diff/1-2/
Testing
---
Precheckin started
Thanks,
Brian Rowe
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59894/#review177374
---
Ship it!
Ship It!
- Brian Rowe
On June 7, 2017, 9:56 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59925/#review177371
---
Ship it!
Ship It!
- Brian Rowe
On June 8, 2017, 6:36 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59896/#review177375
---
Ship it!
Ship It!
- Brian Rowe
On June 7, 2017, 10:02 p.m
: https://reviews.apache.org/r/59863/diff/1/
Testing
---
Precheckin started
Thanks,
Brian Rowe
://reviews.apache.org/r/60486/diff/1/
Testing
---
Added unit test verifying hanlder behavior.
Added integration test verifying module correctness for getRegion.
Running precheckin.
Thanks,
Brian Rowe
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61816/#review183617
---
Ship it!
Ship It!
- Brian Rowe
On Aug. 23, 2017, 3:47 p.m
I agree that we should have defaulted everything to using ephemeral ports
and forced clients to explicitly assign ports and membership ranges if
needed (any of the reasons Anthony mentioned above). However, I don't
think we can change the default assigned ports at this point, unless we
want to
rts before selecting ephemeral
> ports? I think this would resolve the collision issue described above.
>
> On Thu, Oct 11, 2018 at 9:58 AM Brian Rowe wrote:
>
> > I agree that we should have defaulted everything to using ephemeral ports
> > and forced clients to explicitly
e base? It seems like having a common
> implementation of this would make it a lot easier to solve this type of
> problem in the future.
>
> On Thu, Oct 11, 2018 at 11:27 AM Brian Rowe wrote:
>
> > Galen, this was actually my first instinct. Unfortunately this range is
>
Currently the default value for this parameter covers the default locator
and server port values. As a result of this, when launching a locator and
then a server on the same system using gfsh, it's possible to see the
server fail because the locator has already bound the default server
socket.
The maven repository for 1.8.0 seems to be missing the 1.8.0 source jars.
This means people using an IDE can't download these jars automatically to
see the geode source in their IDE.
Specifically, we see the following in 1.8 vs 1.7:
49 matches
Mail list logo
