Re: [DISCUSS] Release branch for 1.1.0

2017-02-01 Thread Dan Smith
I checked in what I hope is a workaround for GEODE-2386. We'll see what happens when the nightly build runs. It doesn't seem to reproduce in other environments. -Dan On Wed, Feb 1, 2017 at 1:34 PM, Anthony Baker wrote: > If it doesn’t need to be fixed in 1.1.0, please unset

Re: Property-Based Testing for Geode

2017-02-02 Thread Dan Smith
+1 Cool! -Dan On Thu, Feb 2, 2017 at 1:21 PM, Galen M O'Sullivan wrote: > Hi all, > > I would like to propose adding [junit-quickcheck](1) to Geode. It's named > after the [Haskell tool](2) and functions more or less as automated testing > for JUnit Theories (if anyone

Re: Review Request 56244: GEODE-2410 : afterPrimary and afterSecondary event listeners pass through the same critical section code

2017-02-02 Thread Dan Smith
/geode/cache/lucene/internal/IndexRepositoryFactory.java (line 69) <https://reviews.apache.org/r/56244/#comment235577> I think this timeout should maybe be shorter - 100 ms or so. Otherwise a query could block for 5 seconds in rare cases. - Dan Smith On Feb. 2, 2017, 10:55 p.m., nabar

Re: geode git commit: GEODE-2421: Adding packer portion of making a VS2015 dev AMI

2017-02-02 Thread Dan Smith
t; > > > > > > Project: http://git-wip-us.apache.org/repos/asf/geode/repo > > > > Commit: http://git-wip-us.apache.org/repos/asf/geode/commit/340f2fca > > > > Tree: http://git-wip-us.apache.org/repos/asf/geode/tree/340f2fca > > > > Diff: http://git-

geode-old-versions subproject?

2017-02-03 Thread Dan Smith
One thing Hitesh and I noticed is that when you do a build, it creates a directory called geode-old-versions because there is a line in settings.gradle for a geode-old-versions project. Is this leftover cruft, or is it actually supposed to be there? I see a couple of references to

Re: geode git commit: GEODE-2421: Adding packer portion of making a VS2015 dev AMI

2017-02-03 Thread Dan Smith
distributions/apache-geode-${GEODE_VERSION}.tar.gz > >>> && \ > >>> tar xzf apache-geode-${GEODE_VERSION}.tar.gz && \ > >>> ls / > >>> #rm apache-geode-${GEODE_VERSION.tar}.tar.gz > >>> > >>> ENV GEODE /apache

Re: [DISCUSS] Release branch for 1.1.0

2017-02-03 Thread Dan Smith
+1 for pushing out GEODE-2413. I think what Anthony said makes sense. -Dan On Fri, Feb 3, 2017 at 2:32 PM, Anthony Baker wrote: > > > On Feb 3, 2017, at 2:03 PM, Hitesh Khamesra > wrote: > > > > GEODE-2413 : Implementing a peer-to-peer protocol

Re: Review Request 56104: not to create AEQ for acceor

2017-01-31 Thread Dan Smith
test. This looks good! - Dan Smith On Jan. 31, 2017, 10:11 p.m., xiaojian zhou wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Feb 2017 Board Report DRAFT FOR REVIEW (need your input on Tuesday 2/7 if possible)

2017-02-06 Thread Dan Smith
Looks good! A couple of minor edits: "open dev list" => "dev list" "commmitters" => "committers" -Dan On Mon, Feb 6, 2017 at 5:19 PM, Dave Barnes wrote: > Please review and comment by COB Tuesday, 2/7/2017, as the report is due on > Wednesday. Thanks! > > ## Description: >

Re: Review Request 56348: GEODE-2434: Generate old version classpaths in doLast

2017-02-06 Thread Dan Smith
Diff: https://reviews.apache.org/r/56348/diff/ Testing --- Thanks, Dan Smith

Re: Review Request 56355: GEODE-2314: EOF file segment exceptions due to empty file

2017-02-06 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56355/#review164440 --- Ship it! Ship It! - Dan Smith On Feb. 7, 2017, 12:49 a.m

Re: Review Request 56348: GEODE-2434: Generate old version classpaths in doLast

2017-02-07 Thread Dan Smith
eviews.apache.org/r/56348/#review164448 ------- On Feb. 7, 2017, 12:53 a.m., Dan Smith wrote: > > --- > This is an automatically generated e-mail. To re

Review Request 56348: GEODE-2434: Generate old version classpaths in doLast

2017-02-06 Thread Dan Smith
- geode-core/src/test/java/org/apache/geode/test/dunit/standalone/VersionManager.java 7bda9481275d3801e347ae6dfd66520e3f123a3a geode-old-versions/build.gradle a09b2d71c4ae9ab393b2d6e9cd44d94155e760f9 Diff: https://reviews.apache.org/r/56348/diff/ Testing --- Thanks, Dan Smith

Re: Review Request 56355: GEODE-2314: EOF file segment exceptions due to empty file

2017-02-06 Thread Dan Smith
ot;, e); throw new FunctionException(e); } - Dan Smith On Feb. 6, 2017, 11:47 p.m., Jason Huynh wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 56399: GEODE-2403: Number of queries executed stat is incremented before making the lastResult call

2017-02-07 Thread Dan Smith
to be treated this way? - Dan Smith On Feb. 7, 2017, 6:31 p.m., nabarun nag wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Nightly build broken

2017-02-07 Thread Dan Smith
Actually, now that I think about it GEODE-2434 was probably the cause of these backwards compatibility test failures. The build was generating the geodeOldVersionClasspaths file during the configuration phase. What that means is if you run './gradlew clean precheckin', the file gets generated

Re: Review Request 56348: GEODE-2434: Generate old version classpaths in doLast

2017-02-07 Thread Dan Smith
gt; > is 'main' so the tests may use it? > > Dan Smith wrote: > I was thinking that at some point in the future we might want to get this > file from the classpath, rather than what the code is doing now where it's > poking around on the filesystem. > > Things in

Re: Contributor Permissions in Jira

2017-02-07 Thread Dan Smith
Hi Sarge, What's your JIRA username? -Dan On Tue, Feb 7, 2017 at 2:46 PM, Michael William Dodge wrote: > As I'm working on the native code, may I have contributor permission in > Jira so that I may resolve things that I've fixed. Thanks. > > Sarge

Re: Review Request 56457: GEODE-2433 Backwards compatibility tests are not actually running

2017-02-08 Thread Dan Smith
/VersionManager.java (line 148) <https://reviews.apache.org/r/56457/#comment236505> Is this method still needed? - Dan Smith On Feb. 8, 2017, 7:01 p.m., Bruce Schuchardt wrote: > > --- > This is an automatically g

Re: Review Request 56425: GEODE-2272: do not use a new method to start locator with pulse

2017-02-08 Thread Dan Smith
> On Feb. 8, 2017, 7:49 p.m., Kirk Lund wrote: > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java, > > line 130 > > > > > > I didn't notice use of "gemfire.home" before but

Re: Review Request 56457: GEODE-2433 Backwards compatibility tests are not actually running

2017-02-08 Thread Dan Smith
way to handle failures. Maybe the code that actually uses versions should be what triggers this intialization, and we throw the exception and fail at that point, rather than doing this stuff in a static initializer? - Dan Smith On Feb. 8, 2017, 8:57 p.m., Bruce Schuchardt wrote

Re: geode-old-versions subproject?

2017-02-06 Thread Dan Smith
andalone/VersionManager.java: propFile = new > File("../geode-old-versions/build/geodeOldVersionClasspaths.txt"); > settings.gradle:include 'geode-old-versions' > > I noticed the geode-old-versions showed up in the src release as an empty > dir, which is probably not a good

Re: geode-old-versions subproject?

2017-02-06 Thread Dan Smith
> For me, the "--tests" option seems to only work with the "test" task (not > "integrationTest" or "distributedTest" which I've brought up before). > It does work with the syntax I sent. For example if you take the BC out of the name of the test and run the command from my last email, it will

Re: [VOTE] RC1: Apache Geode release - v1.1.0

2017-02-06 Thread Dan Smith
-1 (binding) I dug into the geode-old-versions project some more. It looks like we may not be running the backwards compatibility tests. I filed this bug, which I think we should fix before shipping: GEODE-2433 - Backwards compatibility tests are not actually running If we're spinning another

Re: Apache policy on files types allowed in source code

2017-02-06 Thread Dan Smith
I don't know about apache policy, but I think anything that can't be easily modified is probably a bad thing to have in the source code. If there is a binary jar, but there's no way to update the jar to modify the test that seems like a problem. Since we have a framework to run tests with old

Re: PR Buckets are created during Get call for non-existing key

2017-02-06 Thread Dan Smith
Hi Avinash, Any time you try to use a bucket it will get created. It doesn't matter if you are trying to put or get values. -Dan On Sat, Feb 4, 2017 at 9:32 PM, Avinash Dongre wrote: > Hi, > In the following test, I have one PR, No buckets will be created initially. > But

Review Request 56346: GEODE-2432: Disable maven artifacts for geode-benchmarks

2017-02-06 Thread Dan Smith
Description --- GEODE-2432: Disable maven artifacts for geode-benchmarks Diffs - geode-benchmarks/build.gradle b6f09bcff645aaee7bcc1de8acaf3025d239b978 Diff: https://reviews.apache.org/r/56346/diff/ Testing --- Thanks, Dan Smith

Re: Contributor Permissions in Jira

2017-02-07 Thread Dan Smith
Hmm, you seem to be in there already so either you were added at point in the past or someone just added you. Let me know if you have any access issues. -Dan On Tue, Feb 7, 2017 at 5:19 PM, Michael William Dodge <mdo...@pivotal.io> wrote: > PivotalSarge > > > On 7 Feb, 2017, a

Fix version should be 1.2 for issues fixed on develop

2017-02-07 Thread Dan Smith
Just a reminder that since we've already cut the 1.1.0 release branch, anything fixed on develop should be marked with a fix version of 1.2.0, not 1.1.0. -Dan

Re: Review Request 56398: use function to implement waitUntilFlushed

2017-02-07 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56398/#review164531 --- Ship it! Awesome! - Dan Smith On Feb. 7, 2017, 6:10 p.m

Re: Review Request 56104: not to create AEQ for acceor

2017-01-31 Thread Dan Smith
/LuceneQueriesPRBase.java (line 96) <https://reviews.apache.org/r/56104/#comment235210> These tests will pass because they throw an IllegalArgumentException here. I don't think that's what you intended. - Dan Smith On Jan. 31, 2017, 10:11 p.m., xiaojian zhou

Re: Review Request 56101: GEODE-2393: Adding a test for afterSecondary partitionListener callback

2017-01-30 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56101/#review163585 --- Ship it! Ship It! - Dan Smith On Jan. 30, 2017, 10:26 p.m

Re: Build failed in Jenkins: Geode-release #39

2017-01-30 Thread Dan Smith
fire.DEFAULT_MAX_OPLOG_SIZE=10, -Dgemfire.disallowMcastDefault >> s=true, >> -Dgemfire.use-ephemeral-ports=true, -ea, -XX:MetaspaceSize=512m, >> -XX:+PrintGC, -XX:+PrintGCDetails, -XX:+PrintGCTimeStamps, >> -DdummyArg=true, >> org.apache.geode.test.dunit.standalone.ChildVM] &

Re: Build failed in Jenkins: Geode-release #39

2017-01-30 Thread Dan Smith
I created GEODE-2386 for these "Unable to launch dunit VMs" failures. It looks like this may actually be a gradle bug. I wonder if the some of the changes for the backwards compatibility test framework somehow made it more likely for us to hit this bug, because we're seeing it frequently now.

Re: buildSrc recompiles anytime I run a dunit test

2017-01-30 Thread Dan Smith
Looks like you are using gradle 3.5, rather than the gradle wrapper we have checked in? For me, the buildSrc targets all report that they are up to date: ./gradlew -DdistributedTest.single=BasicDUnitTest geode-core:distributedTest Picked up JAVA_TOOL_OPTIONS: :buildSrc:compileJava UP-TO-DATE

Re: Review Request 56034: GEODE-2372: Displaying the stacktrace while printing the exception message in handleException

2017-01-27 Thread Dan Smith
/OpExecutorImpl.java (line 794) <https://reviews.apache.org/r/56034/#comment234783> Shouldn't you just uncomment the 'e' parameter in this logger.debug message? e.printStackTrace will just do to system out. - Dan Smith On Jan. 28, 2017, 12:49 a.m., nabarun nag

Re: Review Request 55956: GEODE-2367: Lucene indexes do not handle ha scenarios

2017-01-25 Thread Dan Smith
thing that happens, so that another member can't create a writer until after this member closes the writer. - Dan Smith On Jan. 25, 2017, 8:46 p.m., Jason Huynh wrote: > > --- > This is an automatically generated e-mail. To reply

Re: Review Request 55956: GEODE-2367: Lucene indexes do not handle ha scenarios

2017-01-25 Thread Dan Smith
mentioned in the last review are still present, but maybe it would be good to get this in and continue working on cleaning that up. - Dan Smith On Jan. 26, 2017, 1:15 a.m., Jason Huynh wrote: > > --- > This is an automatically ge

Re: Review Request 55976: add Fixed PR dunit tests for lucene

2017-01-25 Thread Dan Smith
apache/geode/cache/lucene/test/LuceneTestUtilities.java (line 156) <https://reviews.apache.org/r/55976/#comment234512> Why is this marked @Deprecated? - Dan Smith On Jan. 26, 2017, 1:47 a.m., xiaojia

Re: Proposal to add new 'export artifacts' GFSH command

2017-01-26 Thread Dan Smith
+1 for export artifacts and +1 for zip-file I'm also generally in favor of gathering the artifacts on the gfsh client but I am a little concerned that in some cases that could be a lot of data going to the client (10s or 100s of GBs), especially if logs and stats aren't being cleaned up on a

Re: Review Request 56767: GEODE-2402: Write to the lucene region buckets using a callback argument

2017-02-16 Thread Dan Smith
https://reviews.apache.org/r/56767/#review165889 ------- On Feb. 16, 2017, 9:15 p.m., Dan Smith wrote: > > --- > This is an automatically generated e-m

Re: for discussion: separate website into its own repo

2017-02-16 Thread Dan Smith
+1 I think the current setup is confusing, because the website is supposed to include docs that are generated from the last release, but the site instructions say the site should be generated from develop. A separate repo with a single branch will probably reduce confusion. We also need to

Re: Review Request 56989: Adding an exception listener for the last lucene exception

2017-02-23 Thread Dan Smith
a later commit. - Dan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56989/#review166556 --- On Feb. 23, 2017, 5:21 p.m.,

Re: Review Request 57001: Added Dunit tests for to test out Lucene pagination in persistent PR

2017-02-23 Thread Dan Smith
<https://reviews.apache.org/r/57001/#comment238614> Maybe use ExpectedException for this. - Dan Smith On Feb. 23, 2017, 10:24 p.m., nabarun nag wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Review Request 57057: GEODE-2538: Don't invoke a cache loader when fetching values for a lucene query

2017-02-24 Thread Dan Smith
/LuceneGetPageFunctionTest.java PRE-CREATION Diff: https://reviews.apache.org/r/57057/diff/ Testing --- Thanks, Dan Smith

Re: Review Request 57046: GEODE-2543: Remove incorrectly marked deprecated methods from LuceneService and LuceneQueryFactory api

2017-02-24 Thread Dan Smith
on LuceneResultStruct geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneQueryFactoryImpl.java (line 64) <https://reviews.apache.org/r/57046/#comment238802> Shouldn't we remove this whole method? - Dan Smith On Feb. 24, 2017, 8:39 p.m., Jason Huynh

Re: Review Request 57046: GEODE-2543: Remove incorrectly marked deprecated methods from LuceneService and LuceneQueryFactory api

2017-02-24 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57046/#review166756 --- Ship it! Ship It! - Dan Smith On Feb. 24, 2017, 8:51 p.m

Re: Review Request 57050: GEODE-2461: remove unnecessary explicit dependencies

2017-02-24 Thread Dan Smith
. Are you saying that it is a transitive dependency of something else in geode-core:testCompile, and you are trying to change the version that is used? If so you should probably add a comment to that effect so that someone knows why guava is there in the first place. - Dan Smith On Feb. 24, 2017

Re: Review Request 57049: GEODE-2545: NPE during lucene query execution when cache is closing or region is destroyed

2017-02-24 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57049/#review166789 --- Ship it! Ship It! - Dan Smith On Feb. 24, 2017, 11:57 p.m

Re: Review Request 56936: Change LuceneFunction exception thrown type and rename to LuceneQueryFunction

2017-02-22 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56936/#review166440 --- Ship it! Ship It! - Dan Smith On Feb. 22, 2017, 11:06 p.m

Re: Review Request 56958: Bring the RegionTestableType pairings into the enum itself

2017-02-22 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56958/#review166463 --- Ship it! Ship It! - Dan Smith On Feb. 23, 2017, 1:30 a.m

Review Request 56989: Adding an exception listener for the last lucene exception

2017-02-23 Thread Dan Smith
--- Thanks, Dan Smith

Review Request 56990: Lowering the log level for errors when cleaning up the index repository

2017-02-23 Thread Dan Smith
8a68b07ebb9f83ce13da6c7922525fca113ae092 Diff: https://reviews.apache.org/r/56990/diff/ Testing --- Thanks, Dan Smith

Review Request 56960: GEODE-2491 - Don't suppress IOExceptions when writing to the lucene index

2017-02-23 Thread Dan Smith
/56960/diff/ Testing --- Thanks, Dan Smith

Review Request 56838: GEODE-2029 Trimming unused parts of Lucene from binary NOTICE

2017-02-19 Thread Dan Smith
- geode-assembly/src/main/dist/NOTICE 2fccd7a507426830c751d3628e4fd983d68aef03 Diff: https://reviews.apache.org/r/56838/diff/ Testing --- Thanks, Dan Smith

Re: Build failed in Jenkins: Geode-nightly #751

2017-02-17 Thread Dan Smith
This AnalyzeSerializablesJUnitTest failure is my fault. It's fixed now. -Dan On Fri, Feb 17, 2017 at 8:55 AM, Apache Jenkins Server < jenk...@builds.apache.org> wrote: > See > > Changes: > > [lhughesgodfrey] Added keys for Lynn

Re: Review Request 56932: GEODE-2520:Add a lucene query test where a bucket is moved while a query is executing

2017-02-22 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56932/#review166375 --- Ship it! Ship It! - Dan Smith On Feb. 22, 2017, 5:09 p.m

Re: Removal of distributed transaction tests

2017-02-09 Thread Dan Smith
What's wrong with these tests? Are you saying there is coverage elsewhere? -Dan On Thu, Feb 9, 2017 at 12:02 PM, Kirk Lund wrote: > Do we really want our nightly build and precheckin runs to waste time > running these tests? > > DistributedTransactionDUnitTest >

Re: New Committer And PMC Member: Jared Stewart

2017-02-13 Thread Dan Smith
Sweet! Welcome! -Dan On Mon, Feb 13, 2017 at 12:23 PM, Kenneth Howe wrote: > Congratulations Jared > > > On Feb 13, 2017, at 12:07 PM, Joey McAllister > wrote: > > > > Nice! Congratulations, Jared! > > > > On Mon, Feb 13, 2017 at 11:59 AM Mark Bretl

Re: Review Request 56520: Update dependency versions

2017-02-09 Thread Dan Smith
direct dependencies. Do we really have a direct dependency on bcel, for example? If not it seems like we shouldn't manually set the bcel version - we should let gradle pull whatever version is required by whatever dependency we have that uses bcel. - Dan Smith On Feb. 10, 2017, 12:07 a.m., Kirk

Re: WaitUntilParallelGatewaySenderFlushedCoordinatorJUnitTest

2017-02-09 Thread Dan Smith
I think Gester already fixed this one: commit 857cd292e8e5d52e5b7a367682e445552a3de25b Author: zhouxh Date: Wed Feb 8 23:02:51 2017 -0800 GEODE-2400: The WaitUntilParallelGatewaySenderFlushedCoordinatorJUnitTest should return false for local callable in negative case

Re: Nightly geode failure due to DNS

2017-02-09 Thread Dan Smith
This is a really weird test, using a bunch of arrays pass things around. In this case it looks like the DistributedMember objects were equal, but it fails when because it's essentially validating the toStrings of the member ids. I think maybe we should just remove the validation of the toString

Re: BaseLineAndCompareQueryPerfJUnitTest failure

2017-02-10 Thread Dan Smith
We do have support for running micro benchmarks with jmh - see the geode-benchmarks project. But we don't have anything to watch and fail the build if the performance gets worse. That may be kinda hard to do since we're running on shared infrastructure. -Dan On Thu, Feb 9, 2017 at 6:13 PM,

Re: Propose a new implementation for collections in Geode transaction (GEODE-2392)

2017-02-09 Thread Dan Smith
+1 - I actually thought these operations didn't include the transaction state - like queries. Will this affect the way that queries operate with transactions? -Dan On Thu, Feb 9, 2017 at 6:03 PM, Anilkumar Gingade wrote: > +1.. > The Geode transaction is built to work

Re: [VOTE] RC2: Apache Geode release - v1.1.0

2017-02-10 Thread Dan Smith
I don't think we should be too concerned about incubating reference in BUILDING.md or those docker files. The docs are a little more concerning, but I think what's probably more important is fixing the manual that's up on the the website. As far as I know building and updating the manual is a

Re: Review Request 56564: GEODE-2449: Moved Redis out of Geode-core into its own module

2017-02-10 Thread Dan Smith
al/hll/Bits.java (line 14) <https://reviews.apache.org/r/56564/#comment237051> Technically, the hyperloglog stuff wasn't introduced for redis. But maybe it's the only component using this stuff now? - Dan Smith On Feb. 10, 2017, 11:22 p.m., Udo Koh

[DISCUSS] JIRA guidelines

2017-02-14 Thread Dan Smith
We have this draft of JIRA guidelines sitting on the wiki. I updated it slightly. Can we agree on these guidelines and remove the draft label? Is there more that needs to be here? https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=57311462 -Dan

Re: [VOTE] RC2: Apache Geode release - v1.1.0

2017-02-13 Thread Dan Smith
+1 (binding) IMO I think we don't have to hold up this release for the incubating references in BUILDING, docker, etc. as long as we can make the docs on the website correct. Is someone working on cleaning up the incubating references on develop? Verified: - signatures of artifacts - download

Re: Requesting more JIRA permission

2017-02-15 Thread Dan Smith
Great! You should have access now. -Dan On Wed, Feb 15, 2017 at 5:00 PM, Addison Huddy wrote: > ahuddy > > Not planning any major reorganization of tickets. If that is ever needed, I > will make a formal proposal to the community. > > \ah >

Review Request 56767: GEODE-2402: Write to the lucene region buckets using a callback argument

2017-02-16 Thread Dan Smith
/internal/PartitionedRepositoryManagerJUnitTest.java 78909034138d9188b19067b5112e4c366750581b geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/partition/BucketTargetingMapTest.java PRE-CREATION Diff: https://reviews.apache.org/r/56767/diff/ Testing --- Thanks, Dan

Review Request 56769: Fix some races in to IndexRepository creation

2017-02-16 Thread Dan Smith
/java/org/apache/geode/cache/lucene/internal/repository/IndexRepositoryImpl.java f1ee9871911f7ecfd3084c464ed8b67e9f28800a Diff: https://reviews.apache.org/r/56769/diff/ Testing --- Thanks, Dan Smith

Re: Build failed in Jenkins: Geode-nightly #749

2017-02-15 Thread Dan Smith
Galen - I'm guessing you might be trying to click on the link below? I'm not sure jenkins actually keeps that stuff - I think it's just looking for file:/// urls in the console output and translating them to http:// urls. You should be able to find the test results by going to the test result link

Re: GeodeRedisAdapter improvments/feedback

2017-02-15 Thread Dan Smith
Doing the spill/unspill option could be pretty tricky to implement, so you have to do a lot of fancy logic in the transition period. I think Jason's suggestion of configuring things might make more sense. -Dan On Wed, Feb 15, 2017 at 1:12 PM, Jason Huynh wrote: > With the

Re: [DISCUSS] JIRA guidelines

2017-02-15 Thread Dan Smith
l> [image: linkedin] > >>> <https://www.linkedin.com/company/3048967> [image: facebook] > >>> <https://www.facebook.com/pivotalsoftware> [image: google plus] > >>> <https://plus.google.com/+Pivotal> [image: youtube] > >>> <https://www.youtube

Re: Review Request 56719: GEODE-2491: Reduce logging of handled exceptions in LuceneEventListener and LuceneBucketListeners

2017-02-15 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56719/#review165774 --- Ship it! Ship It! - Dan Smith On Feb. 15, 2017, 8:54 p.m

Re: Voting Process

2017-02-15 Thread Dan Smith
+1. Good catch! -Dan On Wed, Feb 15, 2017 at 2:49 PM, Michael William Dodge wrote: > +0.9 :) > > > On 15 Feb, 2017, at 14:48, Anthony Baker wrote: > > > >> > >> On Feb 15, 2017, at 2:40 PM, Mark Bretl wrote: > >> > >> Hi, > >> > >> Now

Re: Requesting more JIRA permission

2017-02-15 Thread Dan Smith
Hi Addison, What's your JIRA user id? I can add you. Our policy is to give JIRA permissions to anyone that asks, so there's no need for a vote to give you access. I think we haven't been totally clear on how people can get access to JIRA and the wiki, sorry about that! I did recently add a

Re: GeodeRedisAdapter improvments/feedback

2017-02-15 Thread Dan Smith
Deltas would help. If the regions are persistent, the whole new value does get written to disk though. I suppose a third option would be to store all collections in the same region, but store each element of the collection as a separate entry. For example for HSET rkey rfield rvalue would create

Jenkins build for geode-examples

2017-01-17 Thread Dan Smith
Now that the examples are in a separate repository, I think we should setup a nightly job to build and test that repo. Can someone with access to jenkins help set this up? It should run the ./gradlew build on the geode-examples project; but in order for that to work it needs access to a build of

Re: Addressing OOM while recovering overflow regions.

2017-01-17 Thread Dan Smith
Option 1 is not a bad idea. Another thought might be to not start asynchronous value recovery until all of the regions are created. I think right now we launch a task to read all of the oplogs and recover values as soon as the disk store is created. Maybe we could defer that until after the last

Native client build fails linking shared library?

2017-01-17 Thread Dan Smith
I tried building the next-gen-native-client-software-grant branch on an ubuntu 16.04 box. It gets about halfway through and then fails with these errors. Any ideas? [ 49%] Building CXX object cppcache/src/CMakeFiles/gfcppcache.dir/PdxLocalWriter.cpp.o [ 49%] Building CXX object

Re: Native client build fails linking shared library?

2017-01-17 Thread Dan Smith
dependencies won't show them but give it a try. > > -Jake > > > On Tue, Jan 17, 2017 at 4:34 PM Michael William Dodge <mdo...@pivotal.io> > wrote: > > > Do you see -lz in the link line? > > > > Sarge > > > > > On 17 Jan, 2017, at 1

Re: Review Request 55440: GEODE-1733: Index repository is now created when the chunk bucket becomes primary.

2017-01-17 Thread Dan Smith
place to submit these tasks. - Dan Smith On Jan. 17, 2017, 10:09 p.m., nabarun nag wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Jenkins build for geode-examples

2017-01-17 Thread Dan Smith
th hashes and sigs > rat checks > etc > > Anthony > > > On Jan 17, 2017, at 10:51 AM, Dan Smith <dsm...@pivotal.io> wrote: > > > > Now that the examples are in a separate repository, I think we should > setup > > a nightly job to build a

Re: Review Request 55440: GEODE-1733: Index repository is now created when the chunk bucket becomes primary.

2017-01-18 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55440/#review162131 --- Ship it! Ship It! - Dan Smith On Jan. 18, 2017, 4:19 a.m

Re: backward-compatibility testing

2017-01-19 Thread Dan Smith
probably the best thing to do because the way I have it >> right now might make it very hard to implement new algorithms that involve >> the Locator. If an old-version peer starts up and the Locator sends it a >> message it doesn't comprehend, or the Locator expects it to do somethi

Re: JIRA versions and multiple repos

2017-01-19 Thread Dan Smith
I wonder if we're trying to overcomplicate things there. I don't see why the geode-examples wouldn't use the same release schedule and version number as geode. The C++ and .NET clients are also somewhat tied to the version of geode that they support. As long as we can stick to a regular release

Re: backward-compatibility testing

2017-01-19 Thread Dan Smith
+1 This is great Bruce! I really like this approach of being able to write tests and have them run with some members with a different version. I think with this framework we should be able to just extend existing tests with subclasses that override the version of some of the VMs which I think is a

Review Request 57170: GEODE-2538: Don't deserialize values on the server when getting results

2017-02-28 Thread Dan Smith
/PageResultsJUnitTest.java PRE-CREATION Diff: https://reviews.apache.org/r/57170/diff/ Testing --- Thanks, Dan Smith

Re: Review Request 57170: GEODE-2538: Don't deserialize values on the server when getting results

2017-02-28 Thread Dan Smith
/cache/lucene/internal/results/PageEntryJUnitTest.java PRE-CREATION geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/results/PageResultsJUnitTest.java PRE-CREATION Diff: https://reviews.apache.org/r/57170/diff/ Testing --- Thanks, Dan Smith

Re: Review Request 57170: GEODE-2538: Don't deserialize values on the server when getting results

2017-02-28 Thread Dan Smith
s is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57170/#review167159 --- On Feb. 28, 2017, 10:41 p.m., Dan Smith wrote: > > ---

Re: Review Request 57225: GEODE-2571 CacheClosedException during LuceneQueryFunction should be handled with a retry

2017-03-01 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57225/#review167609 --- Ship it! Ship It! - Dan Smith On March 1, 2017, 11:45 p.m

Re: export logs and stats

2017-02-28 Thread Dan Smith
I'm a bit confused by (1). Isn't it actually more complicated for you to restrict log collection to a relative path? Why not just look for log files no matter where they are written to? I also don't really follow the argument about why a user that writes to /var/logs is not going to want to use

Re: export logs and stats

2017-02-28 Thread Dan Smith
nd use that to find the logs and stats to gather. The > rolling > > code has already been written that will find all the existing logs and > > stats. In any bugs in that code need to be fixed since it would break the > > code that removes old files based on disk space. So it seems like

Re: Review Request 57229: getCache method implemented for LuceneServiceImpl

2017-03-01 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57229/#review167647 --- Ship it! Ship It! - Dan Smith On March 2, 2017, 2:47 a.m

Re: Feature branch cleanup

2017-02-27 Thread Dan Smith
+1 -Dan On Fri, Feb 24, 2017 at 10:35 PM, Anthony Baker wrote: > > The following 100+ feature branches are related to closed bugs. I think > these can safely be deleted (the branch names aren’t exact but pretty > close): > > GEODE-1017: "Closed" > GEODE-1040: "Closed" >

Re: [DISCUSS] changes to Redis implementation

2017-02-27 Thread Dan Smith
> > Stick the operation+params into the EntryEventImpl that follows the > operation through the system and in the BucketRegion subclass pull out that > data and send it instead of the event's newValue. Yeah, but that only works if your events are always played in the same order. In the case of

Re: Review Request 57070: LuceneServiceImpl should throw CacheClosedException if found cache is null

2017-02-27 Thread Dan Smith
has passed in null; that doesn't mean the cache has not been created or has been closed. I think an NPE or an illegal argument exception is more appopriate. - Dan Smith On Feb. 26, 2017, 7:41 a.m., xiaojian zhou wrote

Re: [DISCUSS] changes to Redis implementation

2017-02-27 Thread Dan Smith
> > Given that the feature is still labeled experimental, do our backwards > compatibility constraints apply? > Actually, it doesn't look like it is marked with @Experimental or is described as experimental in the docs. That said, I think maybe it *should* have been marked as experimental

Re: Review Request 57057: GEODE-2538: Don't invoke a cache loader when fetching values for a lucene query

2017-02-27 Thread Dan Smith
this fix in before doing that optimization. - Dan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57057/#review166946 -------

  1   2   3   4   5   6   7   >