Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes

2017-08-03 Thread Emily Yeh
g/r/61166/#comment257977> Super nitpick: there's just one extra line here that could be deleted. - Emily Yeh On Aug. 2, 2017, 5:54 p.m., Jared Stewart wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 61185: GEODE-3231: use tempWorkingFolder to avoid test log file contamination between tests.

2017-08-03 Thread Emily Yeh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61185/#review182128 --- Ship it! Ship It! - Emily Yeh On July 27, 2017, 4:57 p.m

Re: Review Request 60202: GEODE-3056: fix the message for invalid partition-resolver

2017-07-10 Thread Emily Yeh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60202/#review180043 --- Ship it! Ship It! - Emily Yeh On June 19, 2017, 7:08 p.m

Re: Review Request 61042: GEODE-3214: Remove support for multistep gfsh commands.

2017-07-24 Thread Emily Yeh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61042/#review181247 --- Ship it! +1! - Emily Yeh On July 24, 2017, 5:50 p.m., Jared

Re: Review Request 61084: GEODE-3231: withLogFile does not imply withWorkingDir anymore

2017-07-24 Thread Emily Yeh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61084/#review181249 --- Ship it! Ship It! - Emily Yeh On July 24, 2017, 4:28 p.m

Re: Review Request 60666: geode-3166: remove the uncalled getCredential method

2017-07-24 Thread Emily Yeh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60666/#review181245 --- Ship it! +1! - Emily Yeh On July 17, 2017, 3:49 p.m

Re: Review Request 60688: GEODE-1279: rename tests with old bug system numbers

2017-07-24 Thread Emily Yeh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60688/#review181251 --- Ship it! Ship It! - Emily Yeh On July 6, 2017, 6:28 p.m

Re: Review Request 60924: GEODE-2920: added security tests for create diskstore and create persistent region.

2017-07-24 Thread Emily Yeh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60924/#review181274 --- Ship it! Ship It! - Emily Yeh On July 17, 2017, 9:39 p.m

Re: Review Request 60918: GEODE-3134: fix lucene command security

2017-07-24 Thread Emily Yeh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60918/#review181267 --- Ship it! Ship It! - Emily Yeh On July 17, 2017, 6:34 p.m

Re: Review Request 61003: GEODE-393: GetRegionFunction uses the cache in the FunctionContext

2017-07-24 Thread Emily Yeh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61003/#review181266 --- Ship it! Ship It! - Emily Yeh On July 20, 2017, 5:40 p.m

Re: Review Request 61472: GEODE-3097: fix an accidental bug introduced when working on ssl over http

2017-08-09 Thread Emily Yeh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61472/#review182530 --- Ship it! Ship It! - Emily Yeh On Aug. 7, 2017, 5:18 p.m

Re: Review Request 61409: GEODE-3328: simplify GfshParserRule

2017-08-09 Thread Emily Yeh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61409/#review182529 --- Ship it! Ship It! - Emily Yeh On Aug. 3, 2017, 5:12 p.m

Re: Review Request 59961: GEODE-3048: Introduce a rule to identify tests that require GEODE_HOME

2017-06-12 Thread Emily Yeh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59961/#review177671 --- Ship it! Ship It! - Emily Yeh On June 9, 2017, 11:35 p.m

Re: Review Request 60199: GEODE-3092: fix specifiedDefaultValue for cacheLoader and cacheWriter

2017-06-19 Thread Emily Yeh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60199/#review178266 --- Ship it! Ship It! - Emily Yeh On June 19, 2017, 4:09 p.m

Re: Review Request 60348: GEODE-3103: GfshRule no longer clutters output

2017-06-23 Thread Emily Yeh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60348/#review178810 --- Ship it! Ship It! - Emily Yeh On June 23, 2017, 6:01 p.m

Re: Review Request 60200: GEODE-3095: fix parameter type mismatch between the diskstore command and controller

2017-06-19 Thread Emily Yeh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60200/#review178306 --- Ship it! Ship It! - Emily Yeh On June 19, 2017, 9:12 p.m

Re: Review Request 59643: GEODE-3006: reduce the frequency of ping request and reduce the loglevel of login/logout messages

2017-05-31 Thread Emily Yeh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59643/#review176556 --- Ship it! Ship It! - Emily Yeh On May 31, 2017, 10:46 p.m

Re: Review Request 59686: GEODE-2983: correctly handling --J option value that has ", " inside.

2017-06-02 Thread Emily Yeh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59686/#review176783 --- Ship it! Ship It! - Emily Yeh On May 31, 2017, 10:44 p.m

Re: Review Request 59893: GEODE-3032: Fix CI failure of CommandOverHttpDUnitTest

2017-06-07 Thread Emily Yeh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59893/#review177237 --- Ship it! Ship It! - Emily Yeh On June 7, 2017, 9:08 p.m

Re: Review Request 59642: GEODE-3000: do not have jetty log at debug level

2017-05-31 Thread Emily Yeh
op, so that it doesn't have to be re-instantiated during every iteration.) - Emily Yeh On May 31, 2017, 5:45 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 59754: GEODE-2928: get rid of the isGfshVM static variable

2017-06-08 Thread Emily Yeh
r to invoke remote call or not.) - Emily Yeh On June 5, 2017, 8:03 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://rev

Re: Review Request 59905: GEODE-2933: Add jmx-manager-hostname-for-clients for startLocator and startServer

2017-06-08 Thread Emily Yeh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59905/#review177357 --- Ship it! Ship It! - Emily Yeh On June 8, 2017, 5:33 p.m

Re: Review Request 60025: GEODE-3060: Introduce JUnit rule for testing the fully-assembled GFSH

2017-06-13 Thread Emily Yeh
eption is caught, like in line 99 of `GfshScript.java` (`// ignore since we are waiting *quietly*`). - Emily Yeh On June 12, 2017, 9:50 p.m., Jared Stewart wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 59811: GEODE-2420: add file-size-limit param to the ExportLogsController

2017-06-13 Thread Emily Yeh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59811/#review177765 --- Ship it! Ship It! - Emily Yeh On June 8, 2017, 9:08 p.m

Re: Review Request 60052: GEODE-2294: revert to avoid rest protocol change

2017-06-13 Thread Emily Yeh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60052/#review177767 --- Ship it! Ship It! - Emily Yeh On June 13, 2017, 5:29 p.m

Re: Review Request 60010: GEODE-3062: replace SecurityService after loading cluster config

2017-06-13 Thread Emily Yeh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60010/#review19 --- Ship it! Ship It! - Emily Yeh On June 13, 2017, 4:29 p.m

Re: Review Request 60030: GEODE-2925: finer security for disk management

2017-06-13 Thread Emily Yeh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60030/#review177760 --- Ship it! Ship It! - Emily Yeh On June 12, 2017, 9:14 p.m

Re: Review Request 59542: GEODE-2974: rename ResultBuilder methods: GemFire -> Geode

2017-05-30 Thread Emily Yeh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59542/#review176329 --- Ship it! Ship It! - Emily Yeh On May 30, 2017, 5:54 p.m

[jira] [Assigned] (GEODE-2818) add alias to any command's options that involves "group", "member", "jar"

2017-05-26 Thread Emily Yeh (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emily Yeh reassigned GEODE-2818: Assignee: Emily Yeh > add alias to any command's options that involves "group", &

[jira] [Assigned] (GEODE-2977) commands should take string[] as the value for --group and --memberId(--name) whenever possible

2017-05-26 Thread Emily Yeh (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emily Yeh reassigned GEODE-2977: Assignee: Emily Yeh > commands should take string[] as the value for --group and --memberId(--n

[jira] [Updated] (GEODE-2991) "destroy gateway-sender" command not in documentation

2017-05-26 Thread Emily Yeh (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emily Yeh updated GEODE-2991: - Priority: Minor (was: Major) > "destroy gateway-sender" command not in

[jira] [Created] (GEODE-2991) "destroy gateway-sender" command not in documentation

2017-05-25 Thread Emily Yeh (JIRA)
Emily Yeh created GEODE-2991: Summary: "destroy gateway-sender" command not in documentation Key: GEODE-2991 URL: https://issues.apache.org/jira/browse/GEODE-2991 Project: Geode Issue

[jira] [Assigned] (GEODE-2203) gfsh status locator/server - Give more descriptive output on empty parameter

2017-05-24 Thread Emily Yeh (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emily Yeh reassigned GEODE-2203: Assignee: Emily Yeh (was: Alyssa Kim) > gfsh status locator/server - Give more descriptive out

[jira] [Commented] (GEODE-2203) gfsh status locator/server - Give more descriptive output on empty parameter

2017-05-24 Thread Emily Yeh (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023852#comment-16023852 ] Emily Yeh commented on GEODE-2203: -- gfsh> start locator --port=40001 (locator starts and gfsh a

[jira] [Comment Edited] (GEODE-2203) gfsh status locator/server - Give more descriptive output on empty parameter

2017-05-24 Thread Emily Yeh (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023852#comment-16023852 ] Emily Yeh edited comment on GEODE-2203 at 5/24/17 11:01 PM: {code} gfsh>sta

[jira] [Assigned] (GEODE-2601) Banner is logged twice during locator startup

2017-06-01 Thread Emily Yeh (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emily Yeh reassigned GEODE-2601: Assignee: Emily Yeh > Banner is logged twice during locator star

[jira] [Resolved] (GEODE-2818) add alias to any command's options that involves "group", "member", "jar"

2017-05-30 Thread Emily Yeh (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emily Yeh resolved GEODE-2818. -- Resolution: Fixed > add alias to any command's options that involves "group", &

[jira] [Resolved] (GEODE-2977) commands should take string[] as the value for --group and --memberId(--name) whenever possible

2017-05-30 Thread Emily Yeh (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emily Yeh resolved GEODE-2977. -- Resolution: Fixed > commands should take string[] as the value for --group and --memberId(--n