Re: gfsh over http & authentication

I do believe the connect over http should fail immediately if incorrect or no credentials are supplied. A securePing sounds like a good way to go. On Thu, Feb 2, 2017 at 12:32 PM, John Blum wrote: > @Udo- > > That is the thing. It is not just UI; the ping Thread is also there

Review Request 56396: Refactor test rules

/LuceneClusterConfigurationDUnitTest.java 0b0e936652444f0171e37fa52653f5a4e9a63c87 Diff: https://reviews.apache.org/r/56396/diff/ Testing --- precheckin pending Thanks, Jinmei Liao

Re: Review Request 56459: GEODE-2247: GFSH connect over HTTP without credentials should fail earlier

/web/shell/AbstractHttpOperationInvoker.java (line 82) <https://reviews.apache.org/r/56459/#comment236648> Is this change necessary? - Jinmei Liao On Feb. 9, 2017, 12:21 a.m., Kevin Duling wrote: > > --- > This is a

Re: Review Request 56459: GEODE-2247: GFSH connect over HTTP without credentials should fail earlier

> On Feb. 9, 2017, 5:20 a.m., Jinmei Liao wrote: > > geode-core/src/main/java/org/apache/geode/management/internal/web/shell/AbstractHttpOperationInvoker.java, > > line 82 > > <https://reviews.apache.org/r/56459/diff/2/?file=1628039#file1628039line82> > >

Re: Review Request 56332: GEODE-2431: Upgrade use of Awaitility from 1.7.0 to 2.0.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56332/#review164391 --- Ship it! Ship It! - Jinmei Liao On Feb. 6, 2017, 6:18 p.m

Re: Review Request 56332: GEODE-2431: Upgrade use of Awaitility from 1.7.0 to 2.0.0

and the version? Are these tests failing constantly when run together with other flaky? - Jinmei Liao On Feb. 6, 2017, 6:18 p.m., Kirk Lund wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 56425: GEODE-2272: do not use a new method to start locator with pulse

/rules/LocatorServerStartupRule.java 1f0cd9e720e732c2ce06515c16601e1df173ff4f Diff: https://reviews.apache.org/r/56425/diff/ Testing --- Thanks, Jinmei Liao

Re: Review Request 56899: GEODE-2514: add new tests for statistics archive rolling and removal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56899/#review166280 --- Ship it! Ship It! - Jinmei Liao On Feb. 21, 2017, 9:27 p.m

Another way to write a DUnit Test

We've created a few JUnit rules to ease the pain of starting up locator/servers in different vms. Please check these rules out: LocatorServerStartupRule: this rule will allow you to easily start up locator/server in a give VM with the properties you would like to configure them, and get the

Re: Another way to write a DUnit Test

ties. > Look for: LocatorServerConfigurationRule (we can remove this, instead of > having duplicate rules) > > -Anil. > > > > > On Thu, Feb 16, 2017 at 2:26 PM, Jinmei Liao <jil...@pivotal.io> wrote: > > > We've created a few JUnit rules to ease the pa

Re: Review Request 56991: GEODE-2416: Collect together artifacts from individual servers into a single zip file

: https://reviews.apache.org/r/56991/diff/ Testing --- precheckin running Thanks, Jinmei Liao

Review Request 56991: GEODE-2416: Collect together artifacts from individual servers into a single zip file

8afbcf683824545dff050d88ef320a260855c056 Diff: https://reviews.apache.org/r/56991/diff/ Testing --- precheckin running Thanks, Jinmei Liao

Re: Review Request 56637: refactor ServerStarterRule and LocatorStarterRule so that they can be created without a Properties first.

change will also fix the currently failing integration tests. See the change in MemberMBeanSecurityJUnitTest.java Thanks, Jinmei Liao

Re: Review Request 56637: refactor ServerStarterRule and LocatorStarterRule so that they can be created without a Properties first.

I can put a null check here. - Jinmei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56637/#review165541 --- On Feb. 14, 2017, 4:19 p.m., Jinmei Liao wrote: > > -

Re: Review Request 56637: refactor ServerStarterRule and LocatorStarterRule so that they can be created without a Properties first.

, Jinmei Liao

Review Request 56637: refactor ServerStarterRule and LocatorStarterRule so that they can be created without a Properties first.

/pipelines/jiliao-geode-1716 Thanks, Jinmei Liao

Re: Review Request 56516: GEODE-2456: change JUnit4CacheTestCase tearDown to use deleteQuietly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56516/#review165040 --- Ship it! Ship It! - Jinmei Liao On Feb. 9, 2017, 8:06 p.m

Re: Review Request 56519: GEODE-2458: await expected JMX notifications in verifyMemberNotifications

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56519/#review165042 --- Ship it! Ship It! - Jinmei Liao On Feb. 9, 2017, 11:02 p.m

Review Request 56522: GEODE-2198: do not import cluster config if any region exists to prevent different servers having conflicing region definitions at one point of time.

/management/internal/configuration/ClusterConfigImportDUnitTest.java b4cba61d871339570dd3ea18f5532ec597736879 Diff: https://reviews.apache.org/r/56522/diff/ Testing --- precheckin running Thanks, Jinmei Liao

Re: Review Request 56637: refactor ServerStarterRule and LocatorStarterRule so that they can be created without a Properties first.

change will also fix the currently failing integration tests. See the change in MemberMBeanSecurityJUnitTest.java Thanks, Jinmei Liao

Re: Review Request 56633: GEODE-2474: refactor code to use SystemUtils to read OS system props

/SystemUtilsJUnitTest.java (line 114) <https://reviews.apache.org/r/56633/#comment237363> Are these tests really necessary? The expected and actual are using the same code to get the results. Everything else looks great. - Jinmei Liao On Feb. 14, 2017, 2:31 a.m., Kirk Lund

Review Request 56668: GEODE-2474: mark NetstatDUnitTest as flaky

: mark NetstatDUnitTest as flaky Diffs - geode-core/src/test/java/org/apache/geode/management/internal/cli/NetstatDUnitTest.java 3ee0c46675a250db4db2b8558c5cee3cf1e5eea8 Diff: https://reviews.apache.org/r/56668/diff/ Testing --- Thanks, Jinmei Liao

Re: Build failed in Jenkins: Geode-nightly #748

We have a fix for the integration test failure, and fix for the distributed tests are in review too. Thanks! On Tue, Feb 14, 2017 at 8:12 AM, Apache Jenkins Server < jenk...@builds.apache.org> wrote: > See > > Changes: > > [klund]

Re: Review Request 56635: GEODE-2481: extract default properties generation to its own class

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56635/#review165526 --- Ship it! Ship It! - Jinmei Liao On Feb. 14, 2017, 2:33 a.m

Re: Gradle build for idea

I do not need to run gradle command in order to use IDEA. I just imported those modules, and IDEA will sort things out on its own. On Tue, Feb 14, 2017 at 1:20 PM, Udo Kohlmeyer wrote: > Hi there, > > When I run `gradle idea` the following exception is thrown. > > * What went

Re: Review Request 56586: GEODE-1716: refactor JMXMBeanDunitTest

/MBeanServerConnectionRule.java d85975fe7e5bff93ce3fd58a2c1f4e529eff57e0 Diff: https://reviews.apache.org/r/56586/diff/ Testing (updated) --- precheckin successful. .. Thanks, Jinmei Liao

Review Request 56586: GEODE-1716: refactor JMXMBeanDunitTest

d85975fe7e5bff93ce3fd58a2c1f4e529eff57e0 Diff: https://reviews.apache.org/r/56586/diff/ Testing --- precheckin successful Thanks, Jinmei Liao

Re: Geode nightly build failures

I have a fix for JMXMBeanDUnitTest, the code review is sent out. NetstatDUnitTest fails with OutofMemeoryError, probably the machine does not have enough memory to run this test? On Mon, Feb 13, 2017 at 8:40 AM, Kirk Lund wrote: > Some tests still seem to fail only on

Re: Review Request 55532: GEODE-2198: close and re-create the cache on a server when importing new cluster configuration

geode-core/src/test/resources/org/apache/geode/management/internal/configuration/cluster_config_security.zip PRE-CREATION Diff: https://reviews.apache.org/r/55532/diff/ Testing --- precheckin successful Thanks, Jinmei Liao

Re: Review Request 55532: GEODE-2198: close and re-create the cache on a server when importing new cluster configuration

6a5a1e09c03b9a5362e44fd6fe55a6e6181ea17c geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/CommandOverHttpDUnitTest.java a1810b6eaa7d940ad359d64faab98c7d113165f0 Diff: https://reviews.apache.org/r/55532/diff/ Testing --- precheckin successful Thanks, Jinmei Liao

Review Request 55603: GEODE-2261: fix the dunit test in nightly build

geode-wan/src/test/java/org/apache/geode/management/internal/configuration/WanDUnitTest.java c1aeae639b961f7e653d3c7e8c9ed153effeba36 Diff: https://reviews.apache.org/r/55603/diff/ Testing --- precheckin running Thanks, Jinmei Liao

Re: Review Request 55603: GEODE-2261: fix the dunit test in nightly build

/ClusterConfigurationExtensionsDUnitTest.java f9786c7f85eedd3eb1a358aae8f3a8fbcb9a61f4 geode-wan/src/test/java/org/apache/geode/management/internal/configuration/WanDUnitTest.java c1aeae639b961f7e653d3c7e8c9ed153effeba36 Diff: https://reviews.apache.org/r/55603/diff/ Testing --- precheckin running Thanks, Jinmei Liao

Re: Review Request 55532: GEODE-2198: close and re-create the cache on a server when importing new cluster configuration

successful Thanks, Jinmei Liao

Review Request 55687: GEODE-2199: be able to deploy jars without running servers

13442fd68ce2855561fc724bf73cd8c21d2317af geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommands.java 6a5a1e09c03b9a5362e44fd6fe55a6e6181ea17c Diff: https://reviews.apache.org/r/55687/diff/ Testing --- precheckin running Thanks, Jinmei Liao

Re: Review Request 57221: GEODE-2541: Fixed ClassCastException failure

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57221/#review167593 --- Ship it! Ship It! - Jinmei Liao On March 1, 2017, 10:25 p.m

Re: export logs and stats

t really follow the > > argument about why a user that writes to /var/logs is not going to want > to > > use this command. Won't all users want to be able to gather their logs > > using this command? > > > > 2 seems reasonable. It seems like we should restrict th

Re: export logs and stats

gt; using this command? > > > > 2 seems reasonable. It seems like we should restrict the file names if we > > are going to have this limitation. > > > > -Dan > > > > On Tue, Feb 28, 2017 at 2:43 PM, Jinmei Liao <jil...@pivotal.io> wrote: > >

Re: export logs and stats

> using this command? > > 2 seems reasonable. It seems like we should restrict the file names if we > are going to have this limitation. > > -Dan > > On Tue, Feb 28, 2017 at 2:43 PM, Jinmei Liao <jil...@pivotal.io> wrote: > > > Hello community, > > &

Re: Question on Geode security - Custom SecurityManager

I'll update the wiki page to not include that line so that it won't be confusing to the users. On Sun, Feb 26, 2017 at 10:11 PM, Jinmei Liao <jil...@pivotal.io> wrote: > Hi, NilKanth, the ExampleSecurityManager is meant as an example. When > using that ExampleSecurityManager with t

Re: Question on Geode security - Custom SecurityManager

Hi, NilKanth, the ExampleSecurityManager is meant as an example. When using that ExampleSecurityManager with the json file described in https://cwiki.apache.org/confluence/display/GEODE/Using+Custom+SecurityManager, the role "data" only has permission to the following two regions: "region1" and

Re: gfsh> export cluster-configuration - Reason: null

cess command due to GemFire error. Error while processing > command Reason : > null > > > Thanks, > Wes > > > > On Mar 1, 2017, at 12:24 AM, Jinmei Liao <jil...@pivotal.io> wrote: > > > > We have multiple jira tickets on this waiting to be fixed: > &g

Re: Unable to post reviews on reviews.apache.org

Usually, I just ran the following command under in my feature branch: rbt post --repository geode --tracking-branch=origin/develop --target-groups=geode It will post the diff between my branch and develop automatically. On Thu, Dec 8, 2016 at 12:23 PM, Kirk Lund wrote: > The

Review Request 54617: GEODE-2196: add more tests to cover import cluster-configuration and deploy

config and deploy jars -- refactor the GfshConnectorRule to do the retry logic inside the rule so that users won't have worry about it. -- moved all the expected data/verification code into ClusterConfigResult class to make the main test class cleaner. Thanks, Jinmei Liao

Re: Review Request 54608: GEODE-2201 Make UITests a bit more resilient

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54608/#review158725 --- Ship it! Ship It! - Jinmei Liao On Dec. 9, 2016, 9:50 p.m

Re: Review Request 54801: GEODE-2207 GEODE-1662: fix and rename SecurityManager callback test

/IntegratedSecurityCacheLifecycleDistributedTest.java (line 49) <https://reviews.apache.org/r/54801/#comment230409> Try see if you can use the LocatorServerStartupRule, it makes spin off locator/server much easier in any of the Vms. - Jinmei Liao On Dec. 16, 2016, 1:10 a.m., Kirk Lund

Re: Build failed in Jenkins: Geode-nightly #684

Do we know why the last two builds failed with "'Gradle Test Executor 1801' finished with non-zero exit value 1" this error message? There are no test failures anymore. On Tue, Dec 13, 2016 at 9:17 AM, Apache Jenkins Server < jenk...@builds.apache.org> wrote: > See

Review Request 54772: GEODE-2212: request headers are case-insensitive

/support/LoginHandlerInterceptorRequestHeaderJUnitTest.java PRE-CREATION Diff: https://reviews.apache.org/r/54772/diff/ Testing --- the added test Thanks, Jinmei Liao

Re: Review Request 54772: GEODE-2212: request headers are case-insensitive

Diff: https://reviews.apache.org/r/54772/diff/ Testing --- the added test Thanks, Jinmei Liao

Re: Review Request 54801: GEODE-2207 GEODE-1662: fix and rename SecurityManager callback test

> On Dec. 16, 2016, 2:04 a.m., Jinmei Liao wrote: > > geode-core/src/test/java/org/apache/geode/security/IntegratedSecurityCacheLifecycleDistributedTest.java, > > line 62 > > <https://reviews.apache.org/r/54801/diff/1/?file=1586749#file1586749line62> > &g

Re: Review Request 54617: GEODE-2196: add more tests to cover import cluster-configuration and deploy

/verification code into ClusterConfigResult class to make the main test class cleaner. Thanks, Jinmei Liao

Re: Build failed in Jenkins: Geode-nightly #680

This build failed probably because of our change of some of the cluster config code. Those are not failing in concourse though. Will look into this more. On Sat, Dec 10, 2016 at 7:48 AM, Apache Jenkins Server < jenk...@builds.apache.org> wrote: > See

Review Request 55383: GEODE-2261: rename SharedConfig to ClusterConfigurationService

/CommandOverHttpDUnitTest.java 882d8d863eb327850eef28e9703603e29b6da868 Diff: https://reviews.apache.org/r/55383/diff/ Testing --- precheckin running Thanks, Jinmei Liao

Re: Review Request 55356: GEODE-209: delete broken test and fix ProcessStreamReader

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55356/#review161080 --- Ship it! Ship It! - Jinmei Liao On Jan. 9, 2017, 8:58 p.m

Review Request 55512: GEODE-2296: remove security check in GetFunctionAttribute command

/apache/geode/security/IntegratedClientExecuteFunctionAuthDistributedTest.java 61798660acadfa13cbf8b215c6f6179ecfe5f310 Diff: https://reviews.apache.org/r/55512/diff/ Testing --- the affected tests Thanks, Jinmei Liao

Re: Review Request 54266: GEODE-2153 temporary docs update for post processing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54266/#review157660 --- Ship it! Ship It! - Jinmei Liao On Dec. 1, 2016, 9:42 p.m

Review Request 55288: GEODE-2261: do not use remote function calls to update the shared configuration

/geode/management/internal/configuration/WanDUnitTest.java PRE-CREATION Diff: https://reviews.apache.org/r/55288/diff/ Testing --- precheckin running Thanks, Jinmei Liao

Re: Cluster Config

;> If we consider the locators as the directory service for the cluster then >> it makes no sense for them to be configured differently. I think locators >> should be force to adopt the configuration of the other locator in the >> cluster or refuse to join the cluster until thei

Re: Cluster Config

sue 1 do you really need to change 2? I agree it is silly that > it remotes to another locator to execute the CC change but would it have > any effect should all the locators be configured the same? > > > > On Tue, Jan 3, 2017 at 10:29 AM Jinmei Liao <jil...@pivotal.io> wrote:

Re: Cluster Config

; On Tue, Jan 3, 2017 at 10:05 AM Jinmei Liao <jil...@pivotal.io> wrote: > > > Currently our API or gfsh commands allow you to create a cluster with a > mix > > of locators with and without CC. Our DM maintains a list of locators and > a > > separate list of locators

Re: The right way to remove a region's cache listener?

AM, Dave Barnes <dbar...@pivotal.io> wrote: > > > > > What gfsh command (if any) lists the cache-listeners available on a > given > > > region? Seems like if the intention is to support adding and deleting > by > > > name, there should be a way to list exis

Re: Review Request 55288: GEODE-2261: do not use remote function calls to update the shared configuration

geode-wan/src/test/java/org/apache/geode/management/internal/configuration/WanDUnitTest.java PRE-CREATION Diff: https://reviews.apache.org/r/55288/diff/ Testing (updated) --- precheckin successful Thanks, Jinmei Liao

Re: Review Request 54917: GEODE-2238: add FlakyTest category to flaky test

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54917/#review159771 --- Ship it! Ship It! - Jinmei Liao On Dec. 20, 2016, 10:46 p.m

Re: Review Request 54586: GEODE-2172: CustomConfigWithCacheIntegrationTest fails with AssertionError on Windows

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54586/#review159770 --- Ship it! Ship It! - Jinmei Liao On Dec. 19, 2016, 12:45 p.m

Re: Review Request 54943: GEODE-2197: refactor cluster config

, Jinmei Liao

Review Request 54943: GEODE-2197: refactor cluster config

675f5fe25c560fdcccfeb493c759320d12b64caf geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedSerializables.txt d6b770f6c9b18e8c090045a66864a027f0ad8062 Diff: https://reviews.apache.org/r/54943/diff/ Testing --- Thanks, Jinmei Liao

Re: Review Request 54943: GEODE-2197: refactor cluster config

> > > > If it's just used during jar deployment then you can ignore this > > comment. > > Jinmei Liao wrote: > This is used in locator start-up. So in rolling-upgrade scenario, we > would have a locator in 9.1 trying to start up and contacting locato

Re: Review Request 54801: GEODE-2207 GEODE-1662: fix and rename SecurityManager callback test

instead. - Jinmei Liao On Dec. 16, 2016, 10:11 p.m., Kirk Lund wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 57894: GEODE-2670: do not use local mbs server connection even when pulse is in embeded mode.

/r/57894/diff/1/ Testing --- precheckin running Thanks, Jinmei Liao

Re: Review Request 57796: GEODE-2671: When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

is only used when pulse is not in the embedded mode. - Jinmei Liao On March 21, 2017, 4:35 p.m., Kevin Duling wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 57796: GEODE-2671: When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

> On March 21, 2017, 5:43 p.m., Jinmei Liao wrote: > > geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java > > Lines 72 (patched) > > <https://reviews.apache.org/r/57796/diff/1/?file=1670526#file1670526line72> > > > > I

Re: Review Request 57823: GEODE-2704: Remove Pulse's custom StringUtils in favor of Apache Commons StringUtils

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57823/#review169713 --- Ship it! Ship It! - Jinmei Liao On March 21, 2017, 10:25

Re: Review Request 57822: GEODE-1274: Migration from PulseLogWriter to Log4j standard.

as before, or at least went to a reasonable place. - Jinmei Liao On March 22, 2017, 10:33 p.m., Patrick Rhomberg wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 57894: GEODE-2670: do not use local mbs server connection even when pulse is in embeded mode.

case removed? It's just unnessary, the exception is caught by the catch block immediatly below, so eventually, it's throwing a BadCredentialsException. - Jinmei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57894/#review170024 -

Re: Review Request 57522: check for string "null" in server/locator status message

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57522/#review170020 --- Ship it! Ship It! - Jinmei Liao On March 13, 2017, 10:31

Re: Review Request 57820: GEODE-2395: use random ports when starting the jmx manager and http services

--- precheckin running Thanks, Jinmei Liao

Re: Review Request 57822: GEODE-1274: Migration from PulseLogWriter to Log4j standard.

> On March 21, 2017, 11:36 p.m., Jinmei Liao wrote: > > geode-pulse/build.gradle > > Lines 31 (patched) > > <https://reviews.apache.org/r/57822/diff/1/?file=1671156#file1671156line31> > > > > I just noticed this line. Pulse should NOT require g

Re: Review Request 57820: GEODE-2395: use random ports when starting the jmx manager and http services

/ Changes: https://reviews.apache.org/r/57820/diff/2-3/ Testing (updated) --- precheckin successful Thanks, Jinmei Liao

Re: Review Request 57894: GEODE-2670: do not use local mbs server connection even when pulse is in embeded mode.

ddd799f5158e1f4213b0b6b2de8e1853ba65ab74 Diff: https://reviews.apache.org/r/57894/diff/1/ Testing (updated) --- precheckin successful, manul pulse testing Thanks, Jinmei Liao

Re: Review Request 57729: GEODE-2634: use log4j levels for auto-completion

/reviews.apache.org/r/57729/#review169498 --- On March 17, 2017, 6:48 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https

Re: Review Request 57573: GEODE-2648: always move deleted files to dirOfDeletedFiles

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57573/#review169096 --- Ship it! Ship It! - Jinmei Liao On March 15, 2017, 8:02 p.m

Re: Geode log levels vs. log4j log levels

t; > info logging both config and info. > > > > > > On Wed, Mar 15, 2017 at 11:31 AM, Swapnil Bawaskar <sbawas...@pivotal.io > > > > wrote: > > > > > +1 to making the change and updating the docs to reflect only the new > log > > > le

Re: Review Request 57796: GEODE-2671: When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

> On March 21, 2017, 5:43 p.m., Jinmei Liao wrote: > > geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java > > Lines 72 (patched) > > <https://reviews.apache.org/r/57796/diff/1/?file=1670526#file1670526line72> > > > > I

Re: Review Request 57820: GEODE-2395: use random ports when starting the jmx manager and http services

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57820/#review169639 ------- On March 21, 2017, 9:09 p.m., Jinmei Liao wrote: > >

Re: Review Request 57822: GEODE-1274: Migration from PulseLogWriter to Log4j standard.

or jmx. I think we will just need to use log4j api to do the logging instead of using LogService.getLogger api if we want to get rid of PulseLogWriter - Jinmei Liao On March 21, 2017, 10:05 p.m., Patrick Rhomberg

Re: Review Request 57796: GEODE-2671: When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57796/#review169645 --- Ship it! Ship It! - Jinmei Liao On March 21, 2017, 11:22

Geode log levels vs. log4j log levels

Hi, all, Geode, before using log4j for logging has implemented its own LogWriters and logLevels. Geode log levels has values like "finest, finer, fine, config, info, warning, error, severe". We've moved away from using these log writers to favor using log4j logging. So, mostly, geode logs have

Review Request 57658: GEODE-2670: fixing pulse authentication/authorization issues

Diff: https://reviews.apache.org/r/57658/diff/1/ Testing --- precheckin running Thanks, Jinmei Liao

Re: Review Request 58080: GEODE-2420: Add classes to estimated the size of exported logs

ine 95 (original), 95 (patched) <https://reviews.apache.org/r/58080/#comment243886> why is this change necessary? - Jinmei Liao On April 4, 2017, 8:41 p.m., Ken Howe wrote: > > --- > This is an automatically gener

Re: Review Request 58162: GEM-1351: Move a test to the open side and fix the other tests

Thanks, Jinmei Liao

Re: Review Request 58325: GEODE-2737: Change Pulse UI tests to use random port for JMX connections

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58325/#review171502 --- Ship it! Ship It! - Jinmei Liao On April 10, 2017, 9:52 p.m

Re: Client Commands and SecurityService

ns in > addition to caching created commands to avoid the recreation of the > instance. > > The SSLConfigurationFactory is a simple example where you create an > instance when required. Once an instance is created, that instance is > reused each invocation. > > --Udo > >

Re: Review Request 58010: GEODE-2716: export logs default behavior changed from filtering at log level INFO to ALL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58010/#review170882 --- Ship it! Ship It! - Jinmei Liao On March 30, 2017, 7:19 p.m

Re: Review Request 58050: GEODE-2725: export logs --dir now honored when not connected via HTTP[S].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58050/#review170883 --- Ship it! Ship It! - Jinmei Liao On March 31, 2017, 11:16

Re: Client Commands and SecurityService

I think the client commands needs to be singleton instances even after you change the sequence of initialization. We don't want to have each client operation ends up creating a new command instance, right? That would be a more performance drag. On Thu, Mar 30, 2017 at 2:14 PM, Kirk Lund

Re: One class loader vs multiple class loaders for deployed jars

I believe with the current fix, we at least do not have the "eager loading" problem anymore. The classloader isolation was a problem before and would remain as a problem after this for further larger scale changes. +1 for merging the fix. On Tue, Apr 11, 2017 at 4:04 PM, Swapnil Bawaskar

Review Request 58388: GEODE-2730: refactor rules

7fd839c967314e20897b305270de9b72f27149f3 Diff: https://reviews.apache.org/r/58388/diff/1/ Testing --- precheckin successful. Thanks, Jinmei Liao

Re: Review Request 58388: GEODE-2730: refactor rules

/GfshCommandsOverHttpSecurityTest.java 7fd839c967314e20897b305270de9b72f27149f3 Diff: https://reviews.apache.org/r/58388/diff/2/ Changes: https://reviews.apache.org/r/58388/diff/1-2/ Testing --- precheckin successful. Thanks, Jinmei Liao

Re: Review Request 58325: GEODE-2737: Change Pulse UI tests to use random port for JMX connections

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58325/#review171742 --- Ship it! Ship It! - Jinmei Liao On April 12, 2017, 4:02 p.m

Review Request 58238: GEODE-2756: Do not put security-* properties in the env.

118e3853750d7ea3ef9af6ac092664a4dabb0108 Diff: https://reviews.apache.org/r/58238/diff/1/ Testing --- precheckin running Thanks, Jinmei Liao

Re: Review Request 58238: GEODE-2756: Do not put security-* properties in the env.

/LoginHandlerInterceptorRequestHeaderJUnitTest.java 118e3853750d7ea3ef9af6ac092664a4dabb0108 Diff: https://reviews.apache.org/r/58238/diff/1/ Testing (updated) --- precheckin successful Thanks, Jinmei Liao

  1   2   3   4   5   6   7   >