GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/670
GEODE-3336: Refactor IndexCommandsDUnitTest to use test rules
[View the JIRA ticket
here.](https://issues.apache.org/jira/browse/GEODE-3336)
Thank you for submitting a contribution
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/671
GEODE-3255: Refactor CreateAlterDestroyRegionCommands and tests
[View the JIRA ticket
here.](https://issues.apache.org/jira/browse/GEODE-3255)
`CreateAlterDestroyRegionCommands
Github user YehEmily commented on a diff in the pull request:
https://github.com/apache/geode/pull/671#discussion_r131002611
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateRegionCommand.java
---
@@ -1143,4 +721,26 @@ private boolean
Github user YehEmily commented on a diff in the pull request:
https://github.com/apache/geode/pull/679#discussion_r131003469
--- Diff:
geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/ConfigCommandDUnitTest.java
---
@@ -0,0 +1,242
Github user YehEmily commented on a diff in the pull request:
https://github.com/apache/geode/pull/679#discussion_r131003075
--- Diff:
geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/ConfigCommandDUnitTest.java
---
@@ -0,0 +1,242
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/680
GEODE-3257: Refactoring DeployCommands
[View the JIRA ticket
here.](https://issues.apache.org/jira/browse/GEODE-3257)
**Testing Status: Precheckin to be run on morning of 8/3
Github user YehEmily commented on a diff in the pull request:
https://github.com/apache/geode/pull/651#discussion_r130959623
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/DataCommandFunction.java
---
@@ -633,8 +631,8 @@ public
Github user YehEmily commented on a diff in the pull request:
https://github.com/apache/geode/pull/651#discussion_r130959557
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/Launcher.java
---
@@ -99,7 +99,6 @@ protected Launcher
Github user YehEmily commented on a diff in the pull request:
https://github.com/apache/geode/pull/665#discussion_r130960231
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/Interceptor.java
---
@@ -0,0 +1,79 @@
+/*
+ * Licensed
Github user YehEmily commented on a diff in the pull request:
https://github.com/apache/geode/pull/651#discussion_r130958981
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/process/MBeanProcessController.java
---
@@ -260,6 +265,7 @@ private JMXServiceURL
Github user YehEmily commented on a diff in the pull request:
https://github.com/apache/geode/pull/665#discussion_r130965197
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/Interceptor.java
---
@@ -0,0 +1,79 @@
+/*
+ * Licensed
Github user YehEmily commented on the issue:
https://github.com/apache/geode/pull/672
Already merged to develop.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user YehEmily closed the pull request at:
https://github.com/apache/geode/pull/672
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/709
GEODE-3269: Refactoring ShellCommands
[View the JIRA ticket
here.](https://issues.apache.org/jira/browse/GEODE-3269)
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
Github user YehEmily closed the pull request at:
https://github.com/apache/geode/pull/575
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user YehEmily closed the pull request at:
https://github.com/apache/geode/pull/549
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/642
GEODE-3031: Extracting startLocator and startServer from
LauncherLifecycleCommands
[See the JIRA ticket
here.](https://issues.apache.org/jira/browse/GEODE-3031?jql=project%20%3D%20GEODE%20AND
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/650
GEODE-3253: Refactoring ClientCommands and related tests
[View the JIRA ticket
here.](https://issues.apache.org/jira/browse/GEODE-3253)
`ClientCommands.java` was a large class
Github user YehEmily commented on the issue:
https://github.com/apache/geode/pull/580
@jhuynh1 Thanks for the suggestion! I updated the tests in
`OrderByComparatorJUnitTest.java` to cover all the cases in
`OrderByComparator.java` and updated the PR.
---
If your project is set up
Github user YehEmily commented on a diff in the pull request:
https://github.com/apache/geode/pull/580#discussion_r129399374
--- Diff:
geode-core/src/test/java/org/apache/geode/cache/query/internal/OrderByComparatorJUnitTest.java
---
@@ -173,36 +157,58 @@ public void
Github user YehEmily commented on a diff in the pull request:
https://github.com/apache/geode/pull/580#discussion_r129399451
--- Diff:
geode-core/src/test/java/org/apache/geode/cache/query/internal/OrderByComparatorJUnitTest.java
---
@@ -173,36 +157,58 @@ public void
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/651
GEODE-3230: Cleaning up unused (Cli)Strings
[View the JIRA ticket
here.](https://issues.apache.org/jira/browse/GEODE-3230)
`CliStrings.java` contained a lot of Strings that were not used
Github user YehEmily commented on a diff in the pull request:
https://github.com/apache/geode/pull/580#discussion_r129695770
--- Diff:
geode-core/src/test/java/org/apache/geode/cache/query/internal/OrderByComparatorJUnitTest.java
---
@@ -173,36 +157,54 @@ public void
Github user YehEmily commented on a diff in the pull request:
https://github.com/apache/geode/pull/598#discussion_r128363171
--- Diff:
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/OptionAliasesIntegrationTest.java
---
@@ -0,0 +1,259
Github user YehEmily commented on a diff in the pull request:
https://github.com/apache/geode/pull/598#discussion_r128362946
--- Diff:
geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshRule.java
---
@@ -26,6 +26,8 @@
import java.util.function.Predicate
Github user YehEmily commented on a diff in the pull request:
https://github.com/apache/geode/pull/598#discussion_r128362904
--- Diff:
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StatusLocatorRealGfshTest.java
---
@@ -14,6 +14,8
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/647
GEODE-3271: Refactor WanCommands
[See the JIRA ticket
here.](https://issues.apache.org/jira/browse/GEODE-3271)
`WanCommands.java` was a large class that contained multiple commands. Each
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/606
GEODE-2601: Fixing startup configurations logging twice
[View the JIRA ticket
here.](https://issues.apache.org/jira/browse/GEODE-2601)
The original fix (pull request #582) fixed
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/684
GEODE-3266: Refactoring PDXCommands
[View the JIRA ticket
here.](https://issues.apache.org/jira/browse/GEODE-3266)
- [x] JIRA ticket referenced
- [x] PR rebased
- [x
Github user YehEmily closed the pull request at:
https://github.com/apache/geode/pull/687
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/687
GEODE-3258: Refactoring DiskStoreCommands
[View the JIRA ticket
here.](https://issues.apache.org/jira/browse/GEODE-3258)
`DiskStoreCommands` was a huge class that contained a large number
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/665
GEODE-3254: Refactoring ConfigCommands and ConfigCommandsDUnitTest
[View the JIRA ticket
here.](https://issues.apache.org/jira/browse/GEODE-3254)
`ConfigCommands.java` was a large class
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/675
GEODE-3339: Refactoring ClusterConfigurationServiceEndToEndDUnitTest
[View the JIRA ticket
here.](https://issues.apache.org/jira/browse/GEODE-3339
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/672
GEODE-3256: Refactoring DataCommands
[View the JIRA ticket
here.](https://issues.apache.org/jira/browse/GEODE-3256)
`DataCommands.java` was a large class that contained multiple commands
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/701
GEODE-3337: Refactoring LauncherLifecycleCommandsDUnitTest
[View the JIRA ticket
here.](https://issues.apache.org/jira/browse/GEODE-3337)
`LauncherLifecycleCommandsDUnitTest` was a huge
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/689
GEODE-3259: Refactoring DurableClientCommands
[View the JIRA ticket
here.](https://issues.apache.org/jira/browse/GEODE-3259)
`DurableClientCommands` was a huge class that contained a large
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/690
GEODE-3262: Refactoring IndexCommands
[View the JIRA ticket
here.](https://issues.apache.org/jira/browse/GEODE-3262)
`IndexCommands` was a huge class that contained a large number
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/691
GEODE-3260: Refactoring FunctionCommands
[View the JIRA ticket
here.](https://issues.apache.org/jira/browse/GEODE-3260)
`FunctionCommands` was a huge class that contained a large number
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/694
GEODE-3270: Refactoring (renaming) StatusCommands
[View the JIRA ticket
here.](https://issues.apache.org/jira/browse/GEODE-3270)
`StatusCommands` was a class that already contained
Github user YehEmily commented on a diff in the pull request:
https://github.com/apache/geode/pull/687#discussion_r131787338
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ValidateDiskStoreCommand.java
---
@@ -0,0 +1,107
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/695
GEODE-3267: Refactoring QueueCommands
[View the JIRA ticket
here.](https://issues.apache.org/jira/browse/GEODE-3267)
`QueueCommands` was a big class that contained two commands (each class
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/692
GEODE-3264: Refactoring MemberCommands
[View the JIRA ticket
here.](https://issues.apache.org/jira/browse/GEODE-3264)
`MemberCommands` was a big class that contained too many commands
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/696
GEODE-3265: Refactoring MiscellaneousCommands
[View the JIRA ticket
here.](https://issues.apache.org/jira/browse/GEODE-3265)
`MiscellaneousCommands` was a huge class that contained a large
Github user YehEmily commented on a diff in the pull request:
https://github.com/apache/geode/pull/687#discussion_r131783193
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CompactOfflineDiskStoreCommand.java
---
@@ -0,0 +1,178
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/693
GEODE-3268: Refactoring RegionCommands
[View the JIRA ticket
here.](https://issues.apache.org/jira/browse/GEODE-3268)
`RegionCommands` was a big class that contained too many commands
Github user YehEmily commented on a diff in the pull request:
https://github.com/apache/geode/pull/687#discussion_r131783008
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CompactDiskStoreCommand.java
---
@@ -0,0 +1,185
Github user YehEmily commented on a diff in the pull request:
https://github.com/apache/geode/pull/685#discussion_r131705221
--- Diff:
geode-core/src/test/java/org/apache/geode/management/internal/cli/help/HelperIntegrationTest.java
---
@@ -34,7 +36,7 @@
public static void
Github user YehEmily commented on the issue:
https://github.com/apache/geode/pull/687
@pdxrunner The tests that cover these commands are part of a separate JIRA
ticket ([GEODE-1359](https://issues.apache.org/jira/browse/GEODE-1359)), so
@jinmeiliao recommended just refactoring
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/571
GEODE-2601: Fixing banner being logged twice during locator startup
Now only logs once if both locator and distributed systems are started!
There appear to be some minor changes in various
Github user YehEmily commented on the issue:
https://github.com/apache/geode/pull/571
Precheckin is in progress! Some failures so far that also exist on the
develop branch - will take a look at those soon.
---
If your project is set up for it, you can reply to this email and have
Github user YehEmily closed the pull request at:
https://github.com/apache/geode/pull/571
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user YehEmily commented on a diff in the pull request:
https://github.com/apache/geode/pull/571#discussion_r121499647
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/logging/LogWriterFactory.java
---
@@ -87,19 +87,19 @@ public static InternalLogWriter
Github user YehEmily commented on a diff in the pull request:
https://github.com/apache/geode/pull/571#discussion_r121498978
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/InternalLocator.java
---
@@ -478,9 +478,8 @@ private InternalLocator(int port
Github user YehEmily commented on a diff in the pull request:
https://github.com/apache/geode/pull/591#discussion_r123854670
--- Diff:
geode-core/src/main/java/org/apache/geode/cache/query/internal/CompiledSelect.java
---
@@ -925,79 +917,89 @@ private SelectResults
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/598
GEODE-2818: Completing implementation/testing of aliases
[View the JIRA ticket
here.](https://issues.apache.org/jira/browse/GEODE-2818)
Changes were previously implemented to allow users
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/600
GEODE-1958: Rolling back changes to decrypt method
Earlier, I made changes to the `decrypt` method in `PasswordUtil` to allow
it to decrypt any password, when it should only be decrypting passwords
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/592
GEODE-2707: Removing TXLockToken
[View the JIRA ticket
here.](https://issues.apache.org/jira/browse/GEODE-2707)
It seems that there are no other classes that use the `TXLockToken` class
Github user YehEmily closed the pull request at:
https://github.com/apache/geode/pull/539
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user YehEmily commented on the issue:
https://github.com/apache/geode/pull/539
Precheckin pending!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/539
GEODE-2818: add alias to any command's options that involves "group",
"member", "jar"
Thank you for submitting a contribution to Apache Geode.
In
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/549
GEODE-2203: gfsh status locator/server - Command now gives more descrâ¦
â¦iptive output on empty parameter
Thank you for submitting a contribution to Apache Geode.
In order
Github user YehEmily commented on the issue:
https://github.com/apache/geode/pull/549
Precheckin pending!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/548
GEODE-2818: add alias to any command's options that involves "group",â¦
⦠"member", "jar" and replace CliString variables with GROUP, MEMBER,
JAR, etc.
Github user YehEmily commented on the issue:
https://github.com/apache/geode/pull/548
Precheckin in progress!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user YehEmily commented on a diff in the pull request:
https://github.com/apache/geode/pull/549#discussion_r119225797
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
---
@@ -1794,18 +1801,20 @@ public
Github user YehEmily commented on a diff in the pull request:
https://github.com/apache/geode/pull/549#discussion_r119225532
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
---
@@ -771,11 +771,18 @@ public Result
Github user YehEmily commented on a diff in the pull request:
https://github.com/apache/geode/pull/549#discussion_r119225590
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
---
@@ -771,11 +771,18 @@ public Result
Github user YehEmily closed the pull request at:
https://github.com/apache/geode/pull/546
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/546
GEODE-2818: add alias to any command's options that involves "group",
"member", "jar"
Thank you for submitting a contribution to Apache Geode.
In
Github user YehEmily commented on a diff in the pull request:
https://github.com/apache/geode/pull/549#discussion_r119422035
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
---
@@ -771,11 +771,19 @@ public Result
Github user YehEmily commented on a diff in the pull request:
https://github.com/apache/geode/pull/548#discussion_r120137950
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java
---
@@ -412,7 +411,7 @@ public Result
Github user YehEmily closed the pull request at:
https://github.com/apache/geode/pull/548
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user YehEmily commented on a diff in the pull request:
https://github.com/apache/geode/pull/578#discussion_r122279107
--- Diff:
geode-core/src/test/java/org/apache/geode/cache/util/PasswordUtilJUnitTest.java
---
@@ -1,42 +0,0 @@
-/*
- * Licensed to the Apache
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/590
GEODE-3090: Fixing gfsh help message (and a lot of other typos)
[View the original JIRA ticket
here.](https://issues.apache.org/jira/browse/GEODE-3090)
The original ticket called
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/591
GEODE-3073: Renamed OrderByComparatorUnmapped to OrderByComparatorMapped
[View the JIRA ticket
here.](https://issues.apache.org/jira/browse/GEODE-3073)
`OrderByComparatorUnmapped.java
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/580
GEODE-2936: Refactoring OrderByComparator
[View the JIRA ticket
here.](https://issues.apache.org/jira/browse/GEODE-2936)
`OrderByComparator.java` contained a lot of redundant and confusing
Github user YehEmily commented on a diff in the pull request:
https://github.com/apache/geode/pull/580#discussion_r122055572
--- Diff:
geode-core/src/main/java/org/apache/geode/cache/query/internal/OrderByComparator.java
---
@@ -45,78 +44,50 @@ public OrderByComparator(List
Github user YehEmily commented on a diff in the pull request:
https://github.com/apache/geode/pull/580#discussion_r122067285
--- Diff:
geode-core/src/main/java/org/apache/geode/cache/query/internal/OrderByComparator.java
---
@@ -228,4 +139,55 @@ void addEvaluatedSortCriteria
Github user YehEmily commented on a diff in the pull request:
https://github.com/apache/geode/pull/582#discussion_r122476764
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
---
@@ -2167,7 +2191,7 @@ private static void
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/578
GEODE-1958: Removing PasswordUtil
[View the original JIRA ticket
here.](https://issues.apache.org/jira/browse/GEODE-1958)
`PasswordUtil.java` contained methods used to encrypt a password
Github user YehEmily commented on the issue:
https://github.com/apache/geode/pull/578
Precheckin is mostly green, with one (seemingly unrelated) test failure!
I'm rerunning the test and looking into the failure now.
---
If your project is set up for it, you can reply to this email
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/575
GEODE-3048: Editing tests requiring Gradle test runner to fail
descriptively in IntelliJ
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review
Github user YehEmily commented on the issue:
https://github.com/apache/geode/pull/575
Precheckin in progress!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user YehEmily commented on a diff in the pull request:
https://github.com/apache/geode/pull/575#discussion_r121717861
--- Diff:
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsIntegrationTest.java
---
@@ -39,6 +39,8
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/536
GEODE-2977: make group/name option values consistent
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure
Github user YehEmily commented on the issue:
https://github.com/apache/geode/pull/536
Precheckin was successful!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/561
GEODE-3033: Fixing NPE when jarFileNames is null in
ClusterConfigurationLoader
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/560
Geode 2818: Adding aliases to any command options that involve "group",
"member", or "jar"
⦠"member", "jar" and replace CliString variables
Github user YehEmily commented on the issue:
https://github.com/apache/geode/pull/561
Precheckin in progress!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
89 matches
Mail list logo
