Github user deepakddixit commented on the issue:
https://github.com/apache/geode/pull/326
@metatype I have updated the golden-help-offline.properties. The
integration test HelpCommandsIntegrationTest is generic one checking the help
and confirms the contents from golden-help
Github user deepakddixit commented on the issue:
https://github.com/apache/geode/pull/297
Thank you @kirklund and @metatype for review and merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user deepakddixit commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/297#discussion_r90585692
--- Diff:
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ShowStackTraceDUnitTest.java
---
@@ -90,6 +90,20
Github user deepakddixit commented on the issue:
https://github.com/apache/incubator-geode/pull/297
@metatype and @kirklund I have addressed the review comments. Kindly have a
look.
precheckin is successful. I am not sure why travis is failed with
spotlessJavaCheck, at my box
GitHub user deepakddixit opened a pull request:
https://github.com/apache/geode/pull/327
GEODE-2236: Remove all cache-listners using Gfsh
Added check before instantiating cache listner class. Added test to verify
change.
You can merge this pull request into a Git repository
GitHub user deepakddixit opened a pull request:
https://github.com/apache/geode/pull/326
Feature/geode 2103 : Adding --http-service-port and
--http-service-bind-address option in start locator command
You can merge this pull request into a Git repository by running:
$ git
GitHub user deepakddixit opened a pull request:
https://github.com/apache/geode/pull/648
GEODE-3206 : Corrected order of lucene search results based on score.
* Lucene results with higher score value are more relevant than lower once.
Used descending comparator for lucene
GitHub user deepakddixit opened a pull request:
https://github.com/apache/geode/pull/511
Feature/geode 269
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been
GitHub user deepakddixit opened a pull request:
https://github.com/apache/geode/pull/568
GEODE-290 : Removed deprecated method stopWithPort from LocatorLauncherâ¦
Removed deprecated properties.
Modified test cases to use alternate constants.
Thank you
Github user deepakddixit commented on the issue:
https://github.com/apache/geode/pull/511
@jhuynh1 Sure will open new PR without conflict.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user deepakddixit opened a pull request:
https://github.com/apache/geode/pull/526
GEODE-269 : Removing deprecated API's from FunctionService.
Modified test cases after removing deprecated API's
Thank you for submitting a contribution to Apache Geode
GitHub user deepakddixit opened a pull request:
https://github.com/apache/geode/pull/541
GEODE-2960 : Trim field parameter values from create lucene index.
Added logic to trim leading and trailing spaces from values provided
against 'field'.
Modify existing test case to verify
Github user deepakddixit commented on the issue:
https://github.com/apache/geode/pull/568
@kirklund Thanks for review. As noted, I missed following commit
guidelines. I have amended git message. Also updated PR title and description.
---
If your project is set up for it, you can
13 matches
Mail list logo
