[GitHub] geode pull request #577: Feature/geode 3049

2017-06-12 Thread nreich
GitHub user nreich opened a pull request: https://github.com/apache/geode/pull/577 Feature/geode 3049 This request attempts to add logging for when the last copy of a bucket in a PartitionedRegion is lost (we already log on loss of consistency and on every drop in number of copies

[GitHub] geode pull request #577: Feature/geode 3049

2017-06-13 Thread nreich
Github user nreich commented on a diff in the pull request: https://github.com/apache/geode/pull/577#discussion_r121828113 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/BucketRedundancyTracker.java --- @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache

[GitHub] geode pull request #585: GEODE-3091: remove empty method

2017-06-16 Thread nreich
GitHub user nreich opened a pull request: https://github.com/apache/geode/pull/585 GEODE-3091: remove empty method You can merge this pull request into a Git repository by running: $ git pull https://github.com/nreich/geode feature/GEODE-3091 Alternatively you can review and

[GitHub] geode pull request #594: GEODE-2861: Remove dead code

2017-06-20 Thread nreich
GitHub user nreich opened a pull request: https://github.com/apache/geode/pull/594 GEODE-2861: Remove dead code * code removed related to shutting down DiskStoreTaskPool Thank you for submitting a contribution to Apache Geode. In order to streamline the review of

[GitHub] geode pull request #577: Feature/geode 3049

2017-06-26 Thread nreich
Github user nreich commented on a diff in the pull request: https://github.com/apache/geode/pull/577#discussion_r124145519 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/BucketRedundancyTracker.java --- @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache

[GitHub] geode pull request #616: GEODE-2860: Refactor use of EventTracker

2017-07-03 Thread nreich
GitHub user nreich opened a pull request: https://github.com/apache/geode/pull/616 GEODE-2860: Refactor use of EventTracker * change EventTracker to an interface with two implementations * move as much logic out of LocalRegion down into subclasses that make use

[GitHub] geode pull request #627: GEODE-3194: cleanup disk store on failed initial re...

2017-07-12 Thread nreich
GitHub user nreich opened a pull request: https://github.com/apache/geode/pull/627 GEODE-3194: cleanup disk store on failed initial recovery Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to

[GitHub] geode pull request #616: GEODE-2860: Refactor use of EventTracker

2017-07-14 Thread nreich
Github user nreich closed the pull request at: https://github.com/apache/geode/pull/616 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #636: GEODE-3198: Allow bucket creation when over local-m...

2017-07-14 Thread nreich
GitHub user nreich opened a pull request: https://github.com/apache/geode/pull/636 GEODE-3198: Allow bucket creation when over local-max-memory * the bucket will not be created on a member that is over local max * memory, unless all members have failed to create the bucket

[GitHub] geode pull request #638: Feature/geode 2860

2017-07-14 Thread nreich
GitHub user nreich opened a pull request: https://github.com/apache/geode/pull/638 Feature/geode 2860 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken

[GitHub] geode pull request #704: GEODE-3300: Complete and expose parallel export fea...

2017-08-09 Thread nreich
GitHub user nreich opened a pull request: https://github.com/apache/geode/pull/704 GEODE-3300: Complete and expose parallel export feature for use This change exposes parallel export of snapshots. It provides a filename mapper for parallel exports that gives each snapshot file a

[GitHub] geode issue #704: GEODE-3300: Complete and expose parallel export feature fo...

2017-08-10 Thread nreich
Github user nreich commented on the issue: https://github.com/apache/geode/pull/704 The requirement for the ".gfd" extension currently resides in the ExportDataCommand from gfsh, the only non-internal entry point to create/restore a backup. This constraint could be also va

[GitHub] geode pull request #710: GEODE-3435: Fix serialization test failure

2017-08-11 Thread nreich
GitHub user nreich opened a pull request: https://github.com/apache/geode/pull/710 GEODE-3435: Fix serialization test failure This pull request it to fix an issue introduced in GEODE-3300 that caused AnalyzeSerializablesJUnitTest to fail. You can merge this pull request into a Git

[GitHub] geode pull request #715: GEODE-3169: Decoupling of DiskStore and backups

2017-08-16 Thread nreich
GitHub user nreich opened a pull request: https://github.com/apache/geode/pull/715 GEODE-3169: Decoupling of DiskStore and backups * move backup logic away from DiskStore and into BackupManager * refactor code into smaller methods * improve test code clarity You can

[GitHub] geode pull request #721: GEODE-3448: Implement and expose parallel snapshot ...

2017-08-18 Thread nreich
GitHub user nreich opened a pull request: https://github.com/apache/geode/pull/721 GEODE-3448: Implement and expose parallel snapshot import Tests showed that allowing the parallel import of snapshot files (from parallel export) scales nearly linearly, greatly increasing

[GitHub] geode pull request #753: GEODE-3283: Expose parallel import and export in gf...

2017-08-31 Thread nreich
GitHub user nreich opened a pull request: https://github.com/apache/geode/pull/753 GEODE-3283: Expose parallel import and export in gfsh This pull request allows users to conduct parallel import and export of snapshots through gfsh. Because multiple snapshot files may be present on

[GitHub] geode issue #753: GEODE-3283: Expose parallel import and export in gfsh

2017-08-31 Thread nreich
Github user nreich commented on the issue: https://github.com/apache/geode/pull/753 @jinmeiliao Region is still required, so this would still not work (there is a test in my commit that confirms this): gfsh> export data --member=abc --dir=xxx Your observation about --

[GitHub] geode pull request #754: GEODE-3550: Improve snapshot filter testing

2017-08-31 Thread nreich
GitHub user nreich opened a pull request: https://github.com/apache/geode/pull/754 GEODE-3550: Improve snapshot filter testing Make more explicit testing that filters work on both imports and exports and improve test speed by decreasing data size used. You can merge this pull

[GitHub] geode pull request #753: GEODE-3283: Expose parallel import and export in gf...

2017-09-01 Thread nreich
Github user nreich commented on a diff in the pull request: https://github.com/apache/geode/pull/753#discussion_r136641632 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportDataCommand.java --- @@ -87,4 +80,45 @@ public Result exportData

[GitHub] geode pull request #753: GEODE-3283: Expose parallel import and export in gf...

2017-09-01 Thread nreich
Github user nreich commented on a diff in the pull request: https://github.com/apache/geode/pull/753#discussion_r136642718 --- Diff: geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ImportDataIntegrationTest.java --- @@ -0,0 +1,158

[GitHub] geode pull request #753: GEODE-3283: Expose parallel import and export in gf...

2017-09-01 Thread nreich
Github user nreich commented on a diff in the pull request: https://github.com/apache/geode/pull/753#discussion_r136643154 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/snapshot/RegionSnapshotServiceImpl.java --- @@ -342,6 +342,7 @@ private void