Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/353
+1 I'll merge the non .gitignore changes. I don't think we should be
ignoring directories named bin, we actually have some code checked in those
directories.
I suspect maybe you
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/321
Hi all,
I'm really sorry I missed this. I was out of town for a while and somehow
the discussion slipped through the cracks when I was catching up.
These changes are what I
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/341
@pivotal-jbarrett - Here's a jira -
https://issues.apache.org/jira/browse/GEODE-2317.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/342
Looks good so far, but there are still a lot of files missing apache
headers. I don't know how easy it will be to integrate [apache
rat](https://creadur.apache.org/rat/) into the cmake build
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode-examples/pull/2
Wowsers, good stuff! A couple of comments/questions:
1. Should we really remove gradlew.bat? That means windows users won't be
able to run the examples.
2. Since you
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/344
This PR fixed the issue for me on ubuntu.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/296
@deepakddixit I was running ./gradlew test when it failed. What's weird to
me is that we're not seeing the stack trace from the test for what actually
failed the test, but I think there's
Github user upthewaterspout commented on a diff in the pull request:
https://github.com/apache/geode/pull/303#discussion_r91392448
--- Diff:
geode-core/src/main/java/org/apache/geode/cache/wan/GatewaySender.java ---
@@ -400,4 +400,19 @@
public int
Github user upthewaterspout commented on a diff in the pull request:
https://github.com/apache/geode/pull/303#discussion_r91393140
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/GatewaySenderDestroyFunction.java
---
@@ -0,0 +1,90
Github user upthewaterspout commented on a diff in the pull request:
https://github.com/apache/geode/pull/318#discussion_r92688373
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionQueryDUnitTest.java
---
@@ -149,6 +154,92 @@ public void run
GitHub user upthewaterspout opened a pull request:
https://github.com/apache/geode/pull/318
Handle exceptions and don't deserialize PDX objects when creating indexes
These are two related changes to our index creation code. We should not
deserialize PDX objects during index
Github user upthewaterspout commented on a diff in the pull request:
https://github.com/apache/geode/pull/318#discussion_r92688937
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java
---
@@ -8751,18 +8751,26 @@ public Index createIndex
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/296
+1 looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user upthewaterspout commented on the issue:
https://github.com/apache/incubator-geode/pull/299
+1 - looks good to me, I think it's ready to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user upthewaterspout commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/293#discussion_r90073132
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/cache/FireAndForgetFunctionOnAllServersDUnitTest.java
---
@@ -0,0 +1,164
Github user upthewaterspout commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/299#discussion_r90077733
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/statistics/StatMonitorHandler.java
---
@@ -50,36 +50,26 @@ public
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode-examples/pull/1
+1 - Ship it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/296
Hi @deepakddixit
Sorry for the slow response. I'm a little concerned that with your changes
to the test in ef4d38d, the test is no longer actually testing what happens
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/322
+1 Awesome!!!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/322
@agingade - Yeah, they'll get generated every time you do a clean followed
a by a build. Presumably if you don't do a clean the antlr plugin will detect
if the files are up to date
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/296
@deepakddixit - I think using LoggingThreadGroup is definitely a better
fix. The changes look good to me now, I'll merge them. Thanks!
---
If your project is set up for it, you can reply
GitHub user upthewaterspout opened a pull request:
https://github.com/apache/geode/pull/427
GEODE-2674: Changing the lucene listener to get from the region
Rather than use the value that is in the queue, use the latest value
from the region to update the lucene index
Github user upthewaterspout commented on a diff in the pull request:
https://github.com/apache/geode/pull/427#discussion_r106484913
--- Diff:
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventSubstitutionFilter.java
---
@@ -0,0 +1,37
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/430
I Think it would be better to figure out why we a creating a ton of
threads, rather than create a thread pool specifically just for this one
message.
---
If your project is set up
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/426
@galen-pivotal - it looks like the public API is just GeodeRedisServer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user upthewaterspout closed the pull request at:
https://github.com/apache/geode/pull/427
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user upthewaterspout commented on a diff in the pull request:
https://github.com/apache/geode/pull/427#discussion_r106504069
--- Diff:
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventSubstitutionFilter.java
---
@@ -0,0 +1,37
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/427
Changes are merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/321
+1 these latest changes look good to me!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/450
Regarding putting JMH benchmarks in the core - seems fine. I think I
originally made geode-benchmarks a separate project so it would be easy to
share code and compare benchmarks between
GitHub user upthewaterspout opened a pull request:
https://github.com/apache/geode/pull/472
GEODE-2808 - Fixing lock ordering issues in DeltaSession
Region expiration of sessions and explicit expiration of sessions had
lock ordering issues. Fixing the code so that expiration
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/472
@jhuynh1 @boglesby
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/421
Good catch Anthony. I've pushed a fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user upthewaterspout opened a pull request:
https://github.com/apache/geode/pull/421
GEODE-2595: Change LuceneService.createIndex to use a factory
Changing LuceneService.createIndex to createIndexFactory and
using a factory pattern to create the index
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/421
Good catch, Gester! I'll fix that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user upthewaterspout commented on a diff in the pull request:
https://github.com/apache/geode/pull/420#discussion_r105061375
--- Diff:
geode-lucene/src/test/java/org/apache/geode/cache/lucene/EvictionDUnitTest.java
---
@@ -0,0 +1,145 @@
+/*
+ * Licensed
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/410
@jhuynh1 @karensmolermiller @gesterzhou
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user upthewaterspout commented on a diff in the pull request:
https://github.com/apache/geode-examples/pull/3#discussion_r103761595
--- Diff: partitioned/README.md ---
@@ -0,0 +1,276 @@
+
+
+# Geode partitioned region example
+
+This example demonstrates
Github user upthewaterspout commented on a diff in the pull request:
https://github.com/apache/geode-examples/pull/3#discussion_r103763443
--- Diff:
partitioned/src/main/java/org/apache/geode/examples/partitioned/BaseClient.java
---
@@ -0,0 +1,79 @@
+/*
--- End diff
Github user upthewaterspout commented on a diff in the pull request:
https://github.com/apache/geode-examples/pull/3#discussion_r103763778
--- Diff:
partitioned/src/main/java/org/apache/geode/examples/partitioned/Consumer.java
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed
Github user upthewaterspout commented on a diff in the pull request:
https://github.com/apache/geode-examples/pull/3#discussion_r103763868
--- Diff:
partitioned/src/main/java/org/apache/geode/examples/partitioned/Consumer.java
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed
Github user upthewaterspout closed the pull request at:
https://github.com/apache/geode/pull/658
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/658
Merged to develop in 56ea940d3c826e98b16d6b508fc834f7bd50220c.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user upthewaterspout closed the pull request at:
https://github.com/apache/geode/pull/655
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/620
After reviewing these changes with @jhuynh1 - it looks like the
HAEventWrapper will never get serialized - we don't configure eviction on the
regions that hold HAEventWrapper. So
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/620
Head's up - I'm not sure my changes to fix 1.2->1.0 copying of the queue
are going to completely work. If the HAEventWrapper gets serialized for some
reason (maybe evicted to disk?) The
GitHub user upthewaterspout opened a pull request:
https://github.com/apache/geode-examples/pull/7
GEODE-3196: Fixing the format of the .md5 and .sha256 files
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/upthewaterspout/geode
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/626
+1 I'll merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user upthewaterspout opened a pull request:
https://github.com/apache/geode/pull/640
GEODE-3232: Get a snapshot of maps when serializing FilterProfile
Avoiding a race when serializing a CopyOnWrite data structures be
grabbing a copy first.
Thank you
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/640
@ladyVader @nabarunnag
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user upthewaterspout opened a pull request:
https://github.com/apache/geode/pull/655
GEODE-3030: Set possibleDuplicate=true for all bucket events after failover
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit
Github user upthewaterspout commented on a diff in the pull request:
https://github.com/apache/geode/pull/645#discussion_r128376504
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/cache/ha/HARQAddOperationJUnitTest.java
---
@@ -287,12 +289,11 @@ public void
GitHub user upthewaterspout opened a pull request:
https://github.com/apache/geode-examples/pull/9
GEODE-3199: Make signing with a gpg key optional
Make it optional to sign the archives with a gpg key, to avoid annoying
users trying to build the examples.
You can merge
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode-examples/pull/9
Sure, I'll change it. I was using askpass just because that mirrored what
the main geode repo uses, but I think signArtifacts or something like that is
clearer.
---
If your project
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode-examples/pull/9
@metatype - I updated the PR. Travis is now stuck on find a 1.2 geode
distribution, but it got past the signing check.
---
If your project is set up for it, you can reply
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/608
+1 - I'll merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user upthewaterspout commented on a diff in the pull request:
https://github.com/apache/geode/pull/603#discussion_r125094490
--- Diff:
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesIntegrationTest.java
---
@@ -59,7 +64,7 @@
@Rule
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/620
@jhuynh1 @ladyVader @bschuchardt @hiteshk25
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user upthewaterspout opened a pull request:
https://github.com/apache/geode/pull/620
GEODE-3172: Fix serialization errors with client queues from between 1.0
and 1.2
Adding new tests and fixing errors when copying a client queue from a 1.0
member to a 1.2 member, or from
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/468
I think it's good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/469
I think it's good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/467
I'm not quite sure about this one. LogWriter and LoggerI18n are also
deprecated. I believe they were deprecated because geode is now using log4j2.
@dschneider-pivotal - It looks like
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/466
I think it's good to merge!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/465
I think it's good to merge!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode-examples/pull/4
Is lombok supposed to work in my IDE without installing a plugin? For me
this code has compile errors in intellij.
I like the fact that you got rid of the shell scripts
Github user upthewaterspout commented on a diff in the pull request:
https://github.com/apache/geode/pull/479#discussion_r113564312
--- Diff:
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventListener.java
---
@@ -53,6 +54,8 @@
Logger logger
GitHub user upthewaterspout opened a pull request:
https://github.com/apache/geode/pull/658
GEODE-3315: Replaced PreferBytes... with VMCachedDeserializable
When getting a HAEventWrapper as part of a GII, make sure that we store
the wrapper in a VMCachedDeserializable
Github user upthewaterspout commented on a diff in the pull request:
https://github.com/apache/geode/pull/609#discussion_r131433628
--- Diff:
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/WaitUntilFlushedFunction.java
---
@@ -85,8 +72,10 @@ public
Github user upthewaterspout commented on a diff in the pull request:
https://github.com/apache/geode/pull/712#discussion_r133827499
--- Diff:
extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/DeltaSession.java
---
@@ -553,8 +555,30 @@ public void
Github user upthewaterspout commented on a diff in the pull request:
https://github.com/apache/geode/pull/712#discussion_r133827419
--- Diff:
extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/DeltaSession.java
---
@@ -586,6 +610,20 @@ public int
GitHub user upthewaterspout opened a pull request:
https://github.com/apache/geode/pull/489
GEODE-1728: Http session filter should only apply to REQUEST
The docs should not tell users to add apply the session filter to
FORWARD, INCLUDE, and ERROR dispatchers. It should just
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/489
@joeymcallister @davebarnes97 - can you review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user upthewaterspout opened a pull request:
https://github.com/apache/geode/pull/506
GEODE-2900: DUnit test of moving primary during AEQ dispatching
Adding a dunit test that moves the primary and moves it again during AEQ
dispatching.
@jhuynh1 - I based
Github user upthewaterspout commented on a diff in the pull request:
https://github.com/apache/geode/pull/503#discussion_r115623920
--- Diff:
geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneQuery.java ---
@@ -37,21 +42,38 @@
* Results are returned in order
Github user upthewaterspout commented on a diff in the pull request:
https://github.com/apache/geode/pull/503#discussion_r115624028
--- Diff:
geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneQuery.java ---
@@ -60,7 +82,16 @@
* the limit specified by {@link
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/538
@metatype - Yes, we'll need to update the website as well, the location of
the xsd is also wrong on the website, but for different reasons.
---
If your project is set up for it, you can
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/538
@boglesby - I see the problem with lucene:indexxx. It looks like in
cache-1.0.xsd, which specify this in order to allow other schemas (like
lucene.xsd) to extend region with additional
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/538
@boglesby - Let me know what you think of the new changes. I added some
validation to the code.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user upthewaterspout commented on a diff in the pull request:
https://github.com/apache/geode/pull/570#discussion_r122085382
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionDataStore.java
---
@@ -1472,6 +1472,19 @@ public boolean
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/584
+1 - Looks good to me!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user upthewaterspout commented on a diff in the pull request:
https://github.com/apache/geode/pull/481#discussion_r114158965
--- Diff:
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexImpl.java
---
@@ -131,30 +131,41 @@ protected void initialize
Github user upthewaterspout commented on a diff in the pull request:
https://github.com/apache/geode/pull/481#discussion_r114158872
--- Diff:
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexForPartitionedRegion.java
---
@@ -78,17 +87,9 @@ protected
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/494
@jhuynh1 @jdeppe-pivotal
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user upthewaterspout opened a pull request:
https://github.com/apache/geode/pull/494
GEODE-2889: Update the last access time of native sessions
Our getSession method had some races where we were holding onto a
reference to the native session, but not updating the last
GitHub user upthewaterspout opened a pull request:
https://github.com/apache/geode/pull/538
GEODE-2975: Change the location of the lucene xsd
The lucene xsd was not in the right location on disk, which resulted in
a failure to validate lucene elements in the xml file
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/538
@nabarunnag @boglesby
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user upthewaterspout opened a pull request:
https://github.com/apache/geode-site/pull/6
Adding an assemble task for travis to invoke
Travis always invokes assemble for a gradle project, apparently.
You can merge this pull request into a Git repository by running:
$ git
GitHub user upthewaterspout opened a pull request:
https://github.com/apache/geode/pull/733
Keeping old versions around even during a clean
Putting old versions of geode in a separate directory so they are not
removed during a clean.
Thank you for submitting
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/733
> Would it be possible to include old versions as dependencies?
Yeah, that's what I would really like to do, actually. The problem is that
gradle doesn't make it easy to ca
GitHub user upthewaterspout opened a pull request:
https://github.com/apache/geode/pull/740
GEODE-3513: Removing the use of native sessions session caching
In the session module for generic app servers, we were asking the
application server for a 'native' session
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/740
@jhuynh1 @boglesby
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user upthewaterspout commented on a diff in the pull request:
https://github.com/apache/geode/pull/740#discussion_r135148933
--- Diff:
extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/filter/attributes
Github user upthewaterspout commented on a diff in the pull request:
https://github.com/apache/geode/pull/740#discussion_r135151782
--- Diff:
geode-assembly/src/test/java/org/apache/geode/session/tests/Jetty9CachingClientServerTest.java
---
@@ -0,0 +1,83
Github user upthewaterspout commented on a diff in the pull request:
https://github.com/apache/geode/pull/740#discussion_r135150238
--- Diff:
extensions/geode-modules-session/src/main/java/org/apache/geode/modules/session/filter/SessionListener.java
---
@@ -22,6 +22,11
Github user upthewaterspout commented on a diff in the pull request:
https://github.com/apache/geode/pull/740#discussion_r135150926
--- Diff:
extensions/session-testing-war/src/main/java/org/apache/geode/modules/session/SessionCountingListener.java
---
@@ -12,28 +12,35
GitHub user upthewaterspout opened a pull request:
https://github.com/apache/geode/pull/728
Don't download geode 1.2 every time a build runs
Setting the overwrite flag on the download tasks to false so that we
don't download the old version of geode for every build
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/733
Closing this PR, it seems like this isn't the right change. I'm a little
short on time to mess with this, so if someone else wants to tackle handling
the download in a nicer way please do
Github user upthewaterspout closed the pull request at:
https://github.com/apache/geode/pull/733
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
98 matches
Mail list logo
