[GitHub] geode-native issue #115: GEODE-3165: Reogranized sources relative to the roo...

2017-08-11 Thread dgkimura
Github user dgkimura commented on the issue:

https://github.com/apache/geode-native/pull/115
  
@pivotal-jbarrett: Ship-it!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native issue #115: GEODE-3165: Reogranized sources relative to the roo...

2017-08-11 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on the issue:

https://github.com/apache/geode-native/pull/115
  
@dgkimura https://issues.apache.org/jira/browse/GEODE-3432

Anything else you don't like?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native issue #115: GEODE-3165: Reogranized sources relative to the roo...

2017-08-11 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on the issue:

https://github.com/apache/geode-native/pull/115
  
@dgkimura Those files actually need to be redone in a way more closely 
aligned with other CMake find modules. I would leave them alone for now and fix 
later.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native issue #115: GEODE-3165: Reogranized sources relative to the roo...

2017-08-11 Thread dgkimura
Github user dgkimura commented on the issue:

https://github.com/apache/geode-native/pull/115
  
@pivotal-jbarrett I was referring to `FindNativeClient.cmake` and 
`FindNativeClientCPPCache.cmake`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native issue #115: GEODE-3165: Reogranized sources relative to the roo...

2017-08-11 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on the issue:

https://github.com/apache/geode-native/pull/115
  
@dgkimura which CMake find modules are you referring to?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---