[GitHub] geode-native pull request #115: GEODE-3165: Reogranized sources relative to ...
Github user asfgit closed the pull request at: https://github.com/apache/geode-native/pull/115 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #115: GEODE-3165: Reogranized sources relative to ...
Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/115#discussion_r132769880 --- Diff: CMakeLists.txt --- @@ -242,7 +242,7 @@ add_subdirectory(dhimpl) add_subdirectory(sqliteimpl) add_subdirectory(tests) add_subdirectory(templates/security) -add_subdirectory(docs) +add_subdirectory(docs/api) --- End diff -- There are API docs and the manual. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #115: GEODE-3165: Reogranized sources relative to ...
Github user dgkimura commented on a diff in the pull request: https://github.com/apache/geode-native/pull/115#discussion_r132757951 --- Diff: CMakeLists.txt --- @@ -242,7 +242,7 @@ add_subdirectory(dhimpl) add_subdirectory(sqliteimpl) add_subdirectory(tests) add_subdirectory(templates/security) -add_subdirectory(docs) +add_subdirectory(docs/api) --- End diff -- Ah, I see. So we have 2 docs? That's a little confusing.. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #115: GEODE-3165: Reogranized sources relative to ...
Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/115#discussion_r132755738 --- Diff: CMakeLists.txt --- @@ -242,7 +242,7 @@ add_subdirectory(dhimpl) add_subdirectory(sqliteimpl) add_subdirectory(tests) add_subdirectory(templates/security) -add_subdirectory(docs) +add_subdirectory(docs/api) --- End diff -- Could not move /src/docs to /docs since /docs already exists. /src/docs are just the config to generate api docs. So /docs/api made sense. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #115: GEODE-3165: Reogranized sources relative to ...
Github user dgkimura commented on a diff in the pull request: https://github.com/apache/geode-native/pull/115#discussion_r132739636 --- Diff: CMakeLists.txt --- @@ -242,7 +242,7 @@ add_subdirectory(dhimpl) add_subdirectory(sqliteimpl) add_subdirectory(tests) add_subdirectory(templates/security) -add_subdirectory(docs) +add_subdirectory(docs/api) --- End diff -- What was the motivation to move the doc's `CMakeLists.txt` into api directory? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #115: GEODE-3165: Reogranized sources relative to ...
GitHub user pivotal-jbarrett opened a pull request: https://github.com/apache/geode-native/pull/115 GEODE-3165: Reogranized sources relative to the root for better CMake ⦠IDE integration. - Moved src/docs to docs/api. - Moved src/* to root. - Fixup paths in CMake files. You can merge this pull request into a Git repository by running: $ git pull https://github.com/pivotal-jbarrett/geode-native feature/GEODE-3165 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode-native/pull/115.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #115 commit 6cbd424fe39bc907025460c555768552430c0c5d Author: Jacob Barrett Date: 2017-08-11T15:30:49Z GEODE-3165: Reogranized sources relative to the root for better CMake IDE integration. - Moved src/docs to docs/api. - Moved src/* to root. - Fixup paths in CMake files. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
