[GitHub] geode-native pull request #63: GEODE-2657 - Fixes and tests Function Executi...
Github user asfgit closed the pull request at: https://github.com/apache/geode-native/pull/63 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #63: GEODE-2657 - Fixes and tests Function Executi...
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106930234
--- Diff:
src/cppcache/integration-test/testThinClientPoolExecuteFunction.cpp ---
@@ -1158,9 +1160,10 @@ DUNIT_TASK_DEFINITION(CLIENT1, Client2OpTest)
LOGINFO("FETimeOut begin onServer");
ExecutionPtr serverExc =
FunctionService::onServer(getHelper()->cachePtr);
- CacheableVectorPtr vec =
serverExc->withArgs(CacheableInt32::create(5000))
- ->execute(FETimeOut, 5000)
- ->getResult();
+ CacheableVectorPtr vec =
+ serverExc->withArgs(CacheableInt32::create(5000 * 1000))
--- End diff --
See comment on same request below.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #63: GEODE-2657 - Fixes and tests Function Executi...
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106930126
--- Diff:
src/cppcache/integration-test/testThinClientPoolExecuteFunction.cpp ---
@@ -1506,48 +1353,10 @@ void runFunctionExecution(bool isEndpoint) {
CALL_TASK(StopC1);
CALL_TASK(CloseServers);
CALL_TASK(CloseLocator1);
-
--- End diff --
Like I said in the review request. This test was split out into tho two
tests. The test had two different tests crammed into one file. The big delete
in this file is all the crap that became the second test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #63: GEODE-2657 - Fixes and tests Function Executi...
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106929938
--- Diff: src/clicache/src/CacheFactory.cpp ---
@@ -84,6 +85,12 @@ namespace Apache
//TODO::split
SafeConvertClassGeneric::SetAppDomainEnabled(appDomainEnable);
+ if (appDomainEnable)
+ {
+// Register managed AppDomain context with unmanaged.
+apache::geode::client::createAppDomainContext =
::Geode::Client::createAppDomainContext;
--- End diff --
+1 make it a built default, less property juggling for the app devs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #63: GEODE-2657 - Fixes and tests Function Executi...
Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/63#discussion_r106929867 --- Diff: src/clicache/integration-test/ThinClientFunctionExecutionTestsN.cs --- @@ -959,7 +959,7 @@ public void ExecuteFETimeOut() region[i] = "VALUE--" + i; } - object args = 5000; + object args = 5000 * 1000; --- End diff -- I felt it was important to call out the disconnect between units here rather than hide it in a constant. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #63: GEODE-2657 - Fixes and tests Function Executi...
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106929690
--- Diff:
src/clicache/integration-test/ThinClientAppDomainFunctionExecutionTests.cs ---
@@ -0,0 +1,282 @@
+//=
+// Copyright (c) 2002-2014 Pivotal Software, Inc. All Rights Reserved.
+// This product is protected by U.S. and international copyright
+// and intellectual property laws. Pivotal products are covered by
+// more patents listed at http://www.pivotal.io/patents.
+//
+
+using System;
+using System.Collections.Generic;
+using System.Collections;
+using System.Threading;
+
+namespace Apache.Geode.Client.UnitTests
+{
+ using NUnit.Framework;
+ using Apache.Geode.DUnitFramework;
+ using Apache.Geode.Client.Tests;
+
+ using Apache.Geode.Client;
+ using Region = Apache.Geode.Client.IRegion;
+
+ public class MyAppDomainResultCollector :
IResultCollector
+ {
+#region Private members
+private bool m_resultReady = false;
+ICollection m_results = null;
+private int m_addResultCount = 0;
+private int m_getResultCount = 0;
+private int m_endResultCount = 0;
+#endregion
+public int GetAddResultCount()
+{
+ return m_addResultCount;
+}
+public int GetGetResultCount()
+{
+ return m_getResultCount;
+}
+public int GetEndResultCount()
+{
+ return m_endResultCount;
+}
+public MyAppDomainResultCollector()
+{
+ m_results = new List();
+}
+public void AddResult(TResult result)
+{
+ Util.Log("hitesh in MyAppDomainResultCollector " + result + " : " +
result.GetType());
--- End diff --
Doh! thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #63: GEODE-2657 - Fixes and tests Function Executi...
Github user mmartell commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106929025
--- Diff:
src/clicache/integration-test/ThinClientAppDomainFunctionExecutionTests.cs ---
@@ -0,0 +1,282 @@
+//=
+// Copyright (c) 2002-2014 Pivotal Software, Inc. All Rights Reserved.
+// This product is protected by U.S. and international copyright
+// and intellectual property laws. Pivotal products are covered by
+// more patents listed at http://www.pivotal.io/patents.
+//
+
+using System;
+using System.Collections.Generic;
+using System.Collections;
+using System.Threading;
+
+namespace Apache.Geode.Client.UnitTests
+{
+ using NUnit.Framework;
+ using Apache.Geode.DUnitFramework;
+ using Apache.Geode.Client.Tests;
+
+ using Apache.Geode.Client;
+ using Region = Apache.Geode.Client.IRegion;
+
+ public class MyAppDomainResultCollector :
IResultCollector
+ {
+#region Private members
+private bool m_resultReady = false;
+ICollection m_results = null;
+private int m_addResultCount = 0;
+private int m_getResultCount = 0;
+private int m_endResultCount = 0;
+#endregion
+public int GetAddResultCount()
+{
+ return m_addResultCount;
+}
+public int GetGetResultCount()
+{
+ return m_getResultCount;
+}
+public int GetEndResultCount()
+{
+ return m_endResultCount;
+}
+public MyAppDomainResultCollector()
+{
+ m_results = new List();
+}
+public void AddResult(TResult result)
+{
+ Util.Log("hitesh in MyAppDomainResultCollector " + result + " : " +
result.GetType());
--- End diff --
What's the significance of "hitesh in"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #63: GEODE-2657 - Fixes and tests Function Executi...
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106924253
--- Diff:
src/cppcache/integration-test/testThinClientExecuteFunctionPrSHOP.cpp ---
@@ -563,7 +563,7 @@ DUNIT_TASK_DEFINITION(CLIENT1, Client1OpTest2)
LOGINFO("FETimeOut begin onRegion");
ExecutionPtr RexecutionPtr = FunctionService::onRegion(regPtr0);
CacheableVectorPtr fe =
- RexecutionPtr->withArgs(CacheableInt32::create(5000))
+ RexecutionPtr->withArgs(CacheableInt32::create(5000 * 1000))
--- End diff --
Should we be marking these areas for posterity and conversion to only using
milli?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #63: GEODE-2657 - Fixes and tests Function Executi...
Github user PivotalSarge commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106922752
--- Diff: src/clicache/src/CacheFactory.cpp ---
@@ -84,6 +85,12 @@ namespace Apache
//TODO::split
SafeConvertClassGeneric::SetAppDomainEnabled(appDomainEnable);
+ if (appDomainEnable)
+ {
+// Register managed AppDomain context with unmanaged.
+apache::geode::client::createAppDomainContext =
::Geode::Client::createAppDomainContext;
--- End diff --
Does moving the registration of the managed app domain context to cache
factory from distributed system make it available sooner?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
