Github user asfgit closed the pull request at:
https://github.com/apache/geode/pull/609
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user ameybarve15 commented on a diff in the pull request:
https://github.com/apache/geode/pull/609#discussion_r132678804
--- Diff:
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesIntegrationTest.java
---
@@ -331,6 +331,29 @@ public void
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/609#discussion_r132497282
--- Diff:
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesIntegrationTest.java
---
@@ -331,6 +331,29 @@ public void queryJsonObject()
Github user upthewaterspout commented on a diff in the pull request:
https://github.com/apache/geode/pull/609#discussion_r131433628
--- Diff:
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/WaitUntilFlushedFunction.java
---
@@ -85,8 +72,10 @@ public
Github user ameybarve15 commented on a diff in the pull request:
https://github.com/apache/geode/pull/609#discussion_r131056489
--- Diff:
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/WaitUntilFlushedFunction.java
---
@@ -85,8 +72,10 @@ public void
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/609#discussion_r130952081
--- Diff:
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/WaitUntilFlushedFunction.java
---
@@ -85,8 +72,10 @@ public void
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/609#discussion_r129624935
--- Diff:
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesIntegrationTest.java
---
@@ -290,6 +295,24 @@ public void queryJsonObject()
Github user ameybarve15 commented on a diff in the pull request:
https://github.com/apache/geode/pull/609#discussion_r129480518
--- Diff:
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesIntegrationTest.java
---
@@ -290,6 +295,24 @@ public void
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/609#discussion_r129418949
--- Diff:
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesIntegrationTest.java
---
@@ -290,6 +295,24 @@ public void queryJsonObject()
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/609#discussion_r128584677
--- Diff:
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneServiceImpl.java
---
@@ -472,12 +478,20 @@ public boolean
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/609#discussion_r128585366
--- Diff:
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesIntegrationTest.java
---
@@ -290,6 +295,24 @@ public void queryJsonObject()
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/609#discussion_r128586252
--- Diff:
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesIntegrationTest.java
---
@@ -290,6 +295,24 @@ public void queryJsonObject()
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/609#discussion_r128584345
--- Diff:
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/WaitUntilFlushedFunction.java
---
@@ -85,8 +72,8 @@ public void
GitHub user ameybarve15 opened a pull request:
https://github.com/apache/geode/pull/609
GEODE-2886 : sent IllegalStateException instead of throwing
IllegalArgumentException inside WaitUntilFlushedFunction
1. sent IllegalStateException instead of throwing IllegalArgumentException
14 matches
Mail list logo
