[GitHub] geode pull request #672: GEODE-3256: Refactoring DataCommands

2017-08-11 Thread YehEmily 
Github user YehEmily closed the pull request at:

https://github.com/apache/geode/pull/672


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #672: GEODE-3256: Refactoring DataCommands

2017-08-02 Thread kirklund 
Github user kirklund commented on a diff in the pull request:

https://github.com/apache/geode/pull/672#discussion_r130944162
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DataCommandsUtils.java
 ---
@@ -0,0 +1,311 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+
+package org.apache.geode.management.internal.cli.commands;
+
+import java.util.ArrayList;
+import java.util.HashSet;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Set;
+import java.util.StringTokenizer;
+
+import org.apache.commons.collections.CollectionUtils;
+import org.apache.commons.lang.StringUtils;
+
+import org.apache.geode.LogWriter;
+import org.apache.geode.cache.Region;
+import org.apache.geode.cache.execute.FunctionService;
+import org.apache.geode.cache.execute.ResultCollector;
+import org.apache.geode.distributed.DistributedMember;
+import org.apache.geode.internal.cache.InternalCache;
+import org.apache.geode.management.DistributedRegionMXBean;
+import org.apache.geode.management.ManagementService;
+import org.apache.geode.management.cli.Result;
+import org.apache.geode.management.internal.MBeanJMXAdapter;
+import org.apache.geode.management.internal.cli.CliUtil;
+import org.apache.geode.management.internal.cli.LogWrapper;
+import org.apache.geode.management.internal.cli.domain.DataCommandRequest;
+import org.apache.geode.management.internal.cli.domain.DataCommandResult;
+import 
org.apache.geode.management.internal.cli.functions.DataCommandFunction;
+import org.apache.geode.management.internal.cli.i18n.CliStrings;
+import org.apache.geode.management.internal.cli.result.CompositeResultData;
+import org.apache.geode.management.internal.cli.result.ResultBuilder;
+import org.apache.geode.management.internal.cli.result.TabularResultData;
+
+public class DataCommandsUtils {
--- End diff --

I would prefer to avoid *Utils classes as well. It's reasonable to 
introduce it as a temporary refactoring though just to facilitate breaking 
DataCommands up into multiple Command classes. At some point, we should try to 
refactor DataCommandUtils to non-static OO classes.

Unfortunately I don't have any examples for changing DataCommandUtils to OO 
off the top of my head. That code is going to require some studying to figure 
out how to properly organize it. 

I guess my recommendation at this point is to pull in these changes as they 
are and then @jaredjstewart @YehEmily @jinmeiliao and myself could get together 
and mob on restructuring DataCommandUtils. Thoughts?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #672: GEODE-3256: Refactoring DataCommands

2017-08-01 Thread jaredjstewart 
Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/672#discussion_r130673499
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DataCommandsUtils.java
 ---
@@ -0,0 +1,311 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+
+package org.apache.geode.management.internal.cli.commands;
+
+import java.util.ArrayList;
+import java.util.HashSet;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Set;
+import java.util.StringTokenizer;
+
+import org.apache.commons.collections.CollectionUtils;
+import org.apache.commons.lang.StringUtils;
+
+import org.apache.geode.LogWriter;
+import org.apache.geode.cache.Region;
+import org.apache.geode.cache.execute.FunctionService;
+import org.apache.geode.cache.execute.ResultCollector;
+import org.apache.geode.distributed.DistributedMember;
+import org.apache.geode.internal.cache.InternalCache;
+import org.apache.geode.management.DistributedRegionMXBean;
+import org.apache.geode.management.ManagementService;
+import org.apache.geode.management.cli.Result;
+import org.apache.geode.management.internal.MBeanJMXAdapter;
+import org.apache.geode.management.internal.cli.CliUtil;
+import org.apache.geode.management.internal.cli.LogWrapper;
+import org.apache.geode.management.internal.cli.domain.DataCommandRequest;
+import org.apache.geode.management.internal.cli.domain.DataCommandResult;
+import 
org.apache.geode.management.internal.cli.functions.DataCommandFunction;
+import org.apache.geode.management.internal.cli.i18n.CliStrings;
+import org.apache.geode.management.internal.cli.result.CompositeResultData;
+import org.apache.geode.management.internal.cli.result.ResultBuilder;
+import org.apache.geode.management.internal.cli.result.TabularResultData;
+
+public class DataCommandsUtils {
--- End diff --

I tend to try to avoid `---Utils` classes, as they often end up as a bag of 
unrelated methods rather than a true object-oriented class with a single 
responsibility.  I'm not sure where all of these methods belong in this case 
though, and I think this is certainly a step in the right direction from the 
old `DataCommands` monolith.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #672: GEODE-3256: Refactoring DataCommands

2017-07-31 Thread YehEmily 
GitHub user YehEmily opened a pull request:

https://github.com/apache/geode/pull/672

GEODE-3256: Refactoring DataCommands

[View the JIRA ticket 
here.](https://issues.apache.org/jira/browse/GEODE-3256)

`DataCommands.java` was a large class that contained multiple commands. 
Each command was refactored into a separate class, and the methods shared by 
the commands were refactored into a new and appropriately named class of their 
own (`DataCommandsUtils`).

**Testing Done: Precheckin to be run on morning of 8/1**

- [x] JIRA ticket

- [x] PR rebased

- [x] Single, squashed commit

- [x] Does `gradlew build` runs cleanly

- [ ] No unit tests updated with this change (yet) - some related tests 
could stand to be refactored (especially `GemfireDataCommandsDUnitTest`), but I 
think I will leave these for 
[GEODE-1359](https://issues.apache.org/jira/browse/GEODE-1359).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/YehEmily/geode GEODE-3256

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/672.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #672


commit 017e39eb9cfe27c010c4c31f248c3fcdeab391f9
Author: YehEmily 
Date:   2017-07-31T23:45:19Z

GEODE-3256: Refactoring DataCommands




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---