[GitHub] geode pull request #693: GEODE-3268: Refactoring RegionCommands

2017-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/693 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] geode pull request #693: GEODE-3268: Refactoring RegionCommands

2017-08-07 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/693#discussion_r131775864 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DescribeRegionCommand.java --- @@ -333,9 +247,8 @@ private void w

[GitHub] geode pull request #693: GEODE-3268: Refactoring RegionCommands

2017-08-07 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/693#discussion_r131776451 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DescribeRegionCommand.java --- @@ -359,7 +272,7 @@ private boolean

[GitHub] geode pull request #693: GEODE-3268: Refactoring RegionCommands

2017-08-07 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/693#discussion_r131783322 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ListRegionCommand.java --- @@ -0,0 +1,113 @@ +/* + * Licen

[GitHub] geode pull request #693: GEODE-3268: Refactoring RegionCommands

2017-08-07 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/693#discussion_r131775100 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/RegionCommandsController.java --- @@ -26,11 +26,12 @@ impo

[GitHub] geode pull request #693: GEODE-3268: Refactoring RegionCommands

2017-08-07 Thread YehEmily
GitHub user YehEmily opened a pull request: https://github.com/apache/geode/pull/693 GEODE-3268: Refactoring RegionCommands [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3268) `RegionCommands` was a big class that contained too many commands (each