[GitHub] incubator-geode issue #296: GEODE-2109 : Calling submit on ExecutionService ...

2016-12-04 Thread deepakddixit
Github user deepakddixit commented on the issue: https://github.com/apache/incubator-geode/pull/296 @kirklund I have added a test as suggested with SingleHopTestExecutor. Kindly review. --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] incubator-geode issue #296: GEODE-2109 : Calling submit on ExecutionService ...

2016-12-01 Thread kirklund
Github user kirklund commented on the issue: https://github.com/apache/incubator-geode/pull/296 We've been requiring unit tests or integration tests for all bug fixes. At a minimum, I would recommend adding a new test that fails due to at least of the conditions reported by G

[GitHub] incubator-geode issue #296: GEODE-2109 : Calling submit on ExecutionService ...

2016-11-30 Thread deepakddixit
Github user deepakddixit commented on the issue: https://github.com/apache/incubator-geode/pull/296 @upthewaterspout Thanks for the review. The class declaration is mistakenly changed. I have corrected it. All tests are passing from precheckin after this. --- If your project is set u