[GitHub] incubator-geode issue #299: [ GEODE-2141 ] #comment Fix Issue #2141

2016-12-01 Thread upthewaterspout
Github user upthewaterspout commented on the issue:

https://github.com/apache/incubator-geode/pull/299
  
+1 - looks good to me, I think it's ready to merge. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-geode issue #299: [ GEODE-2141 ] #comment Fix Issue #2141

2016-11-30 Thread davinash
Github user davinash commented on the issue:

https://github.com/apache/incubator-geode/pull/299
  
Is this PR good to merge to develop ? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-geode issue #299: [ GEODE-2141 ] #comment Fix Issue #2141

2016-11-30 Thread davinash
Github user davinash commented on the issue:

https://github.com/apache/incubator-geode/pull/299
  
Thanks @upthewaterspout , @metatype for review
I Have address review comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---