Re: Naming unit tests and integration tests

I've updated the page https://cwiki.apache.org/confluence/display/GEODE/Writing+tests -- please review and provide any feedback you may have. Sorry to take so long -- I went on PTO immediately after my previous message and finally got back to this task now. I'm planning to add in some test exampl

Re: Naming unit tests and integration tests

+1 for renaming existing tests to follow the new conventions and especially renaming old TRAC bug number tests I'll update the wiki today and then report back to this thread. On Mon, Feb 5, 2018 at 1:09 PM, Bruce Schuchardt wrote: > Should we make a pass over all of the tests and rename them to

Re: Naming unit tests and integration tests

Should we make a pass over all of the tests and rename them to follow the conventions we come up with?  It would take some time, and maybe access to Pivotal's old Trac issue tracker in order to rename files with "Bug" and numbers for a name. On 2/5/18 12:28 PM, Kirk Lund wrote: I've been usi

Re: Naming unit tests and integration tests

I've been using the name FooDistributedTest for new dunit tests. I should've included that. For RegressionTests, I've been including the GEODE jira ticket number and summary in the javadocs on the test class. I'll include that in any changes I make to the wiki. On Mon, Feb 5, 2018 at 11:55 AM, Br

Re: Naming unit tests and integration tests

+1 to Kirk's last point (and, well, the points before it). As for bug specific tests, it is common to add a comment of the nature... class SomeExistingTestClass { /** * ... ** @see http://issues.apache.org/../GEODE-123 ">Bug Title Here* */ @Test public v

Re: Naming unit tests and integration tests

These seem like sensible ideas to me.  I especially don't like tests named after bug numbers.  I do like a pointer to relevant tickets in test comments/javadocs though. We also have DUnitTest.  Some designation in the name that it's using the dunit infrastructure is often useful to me.  Having

Re: Naming unit tests and integration tests

Another valuable naming standard is the use FooRegressionTest for tests that are specific to reproducing a bug and verifying its fix. Don't use Bug007IntegrationTest. Use something description like QueryShouldNotIncludeTXSetsRegressionTest (if you want a separate test class for the bug which is som