Re: Review Request 54210: GEODE-2146: deploy should require more elevated privileges than just data:manage
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54210/#review157629 --- Ship it! Ship It! - Kevin Duling On Nov. 30, 2016, 1:27 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54210/ > --- > > (Updated Nov. 30, 2016, 1:27 p.m.) > > > Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund. > > > Repository: geode > > > Description > --- > > GEODE-2146: deploy should require more elevated privileges than just > data:manage > > > Diffs > - > > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/AbstractCommandsSupport.java > d5403d903bd064345b1a4eb6e2d230478e64aa92 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DeployCommands.java > 832207b7bbf8410d1c2290865b1950f5aaef9e16 > > geode-core/src/test/java/org/apache/geode/management/internal/security/DeployCommandsSecurityTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/security/SimpleSecurityManagerTest.java > 066c139ce711459d8c422df45b0d9a027c6e697a > > geode-core/src/test/java/org/apache/geode/security/SimpleTestSecurityManager.java > 0db9825d44a073fffb21ea0942736bf853ba2131 > > Diff: https://reviews.apache.org/r/54210/diff/ > > > Testing > --- > > precheckin running > > > Thanks, > > Jinmei Liao > >
Re: Review Request 54210: GEODE-2146: deploy should require more elevated privileges than just data:manage
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54210/#review157612 --- Ship it! Ship It! - Kirk Lund On Nov. 30, 2016, 9:27 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54210/ > --- > > (Updated Nov. 30, 2016, 9:27 p.m.) > > > Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund. > > > Repository: geode > > > Description > --- > > GEODE-2146: deploy should require more elevated privileges than just > data:manage > > > Diffs > - > > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/AbstractCommandsSupport.java > d5403d903bd064345b1a4eb6e2d230478e64aa92 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DeployCommands.java > 832207b7bbf8410d1c2290865b1950f5aaef9e16 > > geode-core/src/test/java/org/apache/geode/management/internal/security/DeployCommandsSecurityTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/security/SimpleSecurityManagerTest.java > 066c139ce711459d8c422df45b0d9a027c6e697a > > geode-core/src/test/java/org/apache/geode/security/SimpleTestSecurityManager.java > 0db9825d44a073fffb21ea0942736bf853ba2131 > > Diff: https://reviews.apache.org/r/54210/diff/ > > > Testing > --- > > precheckin running > > > Thanks, > > Jinmei Liao > >
Re: Review Request 54210: GEODE-2146: deploy should require more elevated privileges than just data:manage
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54210/ --- (Updated Nov. 30, 2016, 9:27 p.m.) Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund. Repository: geode Description --- GEODE-2146: deploy should require more elevated privileges than just data:manage Diffs (updated) - geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/AbstractCommandsSupport.java d5403d903bd064345b1a4eb6e2d230478e64aa92 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DeployCommands.java 832207b7bbf8410d1c2290865b1950f5aaef9e16 geode-core/src/test/java/org/apache/geode/management/internal/security/DeployCommandsSecurityTest.java PRE-CREATION geode-core/src/test/java/org/apache/geode/security/SimpleSecurityManagerTest.java 066c139ce711459d8c422df45b0d9a027c6e697a geode-core/src/test/java/org/apache/geode/security/SimpleTestSecurityManager.java 0db9825d44a073fffb21ea0942736bf853ba2131 Diff: https://reviews.apache.org/r/54210/diff/ Testing --- precheckin running Thanks, Jinmei Liao
