Re: Review Request 54283: GEODE-1978: Waiting for the queue to drain in testReplicatedSerialProp...

2016-12-01 Thread Barry Oglesby

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54283/#review157690
---


Ship it!




Ship It!

- Barry Oglesby


On Dec. 2, 2016, 1:18 a.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54283/
> ---
> 
> (Updated Dec. 2, 2016, 1:18 a.m.)
> 
> 
> Review request for geode and Barry Oglesby.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Waiting to the queue to drain in this test. The test had an assertion
> that the queue was not empty. But really, in the background the
> dispatcher was draining the queue as fast as it good. The actually
> expected behavior is that the queue will become empty if the remote side
> destroys a region.
> 
> 
> Diffs
> -
> 
>   
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/WANTestBase.java 
> 635193343c7fca14ca584b6ba69f535bd52478fd 
>   
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/concurrent/ConcurrentWANPropagation_1_DUnitTest.java
>  fd9a9c94a21577907ee264197564e0134fadd812 
> 
> Diff: https://reviews.apache.org/r/54283/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>



Re: Review Request 54283: GEODE-1978: Waiting for the queue to drain in testReplicatedSerialProp...

2016-12-01 Thread nabarun nag

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54283/#review157685
---


Ship it!




Ship It!

- nabarun nag


On Dec. 2, 2016, 1:18 a.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54283/
> ---
> 
> (Updated Dec. 2, 2016, 1:18 a.m.)
> 
> 
> Review request for geode and Barry Oglesby.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Waiting to the queue to drain in this test. The test had an assertion
> that the queue was not empty. But really, in the background the
> dispatcher was draining the queue as fast as it good. The actually
> expected behavior is that the queue will become empty if the remote side
> destroys a region.
> 
> 
> Diffs
> -
> 
>   
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/WANTestBase.java 
> 635193343c7fca14ca584b6ba69f535bd52478fd 
>   
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/concurrent/ConcurrentWANPropagation_1_DUnitTest.java
>  fd9a9c94a21577907ee264197564e0134fadd812 
> 
> Diff: https://reviews.apache.org/r/54283/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>