Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61166/ --- (Updated Aug. 8, 2017, 5:14 p.m.) Review request for geode, Emily Yeh, Jared

Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61166/#review182126 --- Ship it! Looks good! +1

Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes

> On Aug. 2, 2017, 4:44 p.m., Kirk Lund wrote: > > You might consider hoisting these classes out of management pkg and into > > org.apache.geode.test.something. Maybe even move them to geode-test module. > > They seem very useful even outside of geode-core and management. > > > > Ship It!

Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61166/ --- (Updated Aug. 2, 2017, 5:54 p.m.) Review request for geode, Emily Yeh, Jared

Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61166/#review181999 --- Ship it! You might consider hoisting these classes out of

Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61166/#review181921 --- Ship it! Ship It! - Jinmei Liao On Aug. 1, 2017, 6:31 p.m.,

Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61166/ --- (Updated Aug. 1, 2017, 6:31 p.m.) Review request for geode, Emily Yeh, Jared

Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61166/ --- (Updated July 31, 2017, 10:37 p.m.) Review request for geode, Emily Yeh, Jared

Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes

> On July 30, 2017, 5:05 a.m., Jinmei Liao wrote: > > geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/JarBuilder.java > > Lines 66 (patched) > > > > > > looks like only the

Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61166/#review181770 ---

Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61166/ --- (Updated July 28, 2017, 10:46 p.m.) Review request for geode, Emily Yeh, Jared

Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61166/#review181686 --- Ship it! Some javadoc on how to use thes test utilities would

Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61166/ --- (Updated July 27, 2017, 11:29 p.m.) Review request for geode, Emily Yeh, Jared

Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61166/ --- (Updated July 27, 2017, 11:15 p.m.) Review request for geode, Emily Yeh, Jared