Re: Review Request 61417: GEODE-3328: adding ssl-truststore-type to the config

2017-08-07 Thread Dave Barnes
Hi Jinmei, 1. Yes, a parallel change would be good for keystore. In both cases, we need to specify the default. My sample text said empty string ('') -- is that correct, or is the default JKS? 2 & 3: Good - glad they're correct. I wasn't sure, just noticed the patterns. -Dave On Sat, Aug 5, 2017 a

Re: Review Request 61417: GEODE-3328: adding ssl-truststore-type to the config

2017-08-05 Thread Jinmei Liao
> On Aug. 3, 2017, 11:36 p.m., Dave Barnes wrote: > > 1. The help message for the property should state what it does and whether > > it has a default. JKS was our assumption in the past, but with the > > introduction of this feature other values (such as 'pkcs12') are possible. > > Current word

Re: Review Request 61417: GEODE-3328: adding ssl-truststore-type to the config

2017-08-04 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61417/#review182233 --- geode-core/src/main/java/org/apache/geode/distributed/Configurati

Re: Review Request 61417: GEODE-3328: adding ssl-truststore-type to the config

2017-08-04 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61417/#review182230 --- Ship it! Ship It! - Jared Stewart On Aug. 3, 2017, 9:15 p.m.

Re: Review Request 61417: GEODE-3328: adding ssl-truststore-type to the config

2017-08-03 Thread Dave Barnes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61417/#review182181 --- 1. The help message for the property should state what it does and

Re: Review Request 61417: GEODE-3328: adding ssl-truststore-type to the config

2017-08-03 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61417/#review182172 --- Ship it! Ship It! - Udo Kohlmeyer On Aug. 3, 2017, 9:15 p.m.