Re: Review Request 61562: GEODE-3423: Provide support for running parallel docker builds in Jenkins

2017-08-11 Thread Anthony Baker 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61562/#review182715
---


Ship it!




Ship It!

- Anthony Baker


On Aug. 10, 2017, 9:16 p.m., Jens Deppe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61562/
> ---
> 
> (Updated Aug. 10, 2017, 9:16 p.m.)
> 
> 
> Review request for geode, Anthony Baker and Mark Bretl.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> - Also cleaning up other Dockerfiles which are unused
> 
> Signed-off-by: Scott Jewell 
> 
> 
> Diffs
> -
> 
>   dev-tools/docker/base/Dockerfile 1cce0ddb0d29c9e188d27481c82123e357c5b685 
>   dev-tools/docker/base/build-base-docker.sh 
> 9aab72c45d63c519874ad39aaf74c8236d9671ed 
>   dev-tools/docker/compile/Dockerfile 
> 6ae343a70eccf7cc4b303228118cee0b8579e79a 
>   dev-tools/docker/compile/start-compile-docker.sh 
> 9059c5b5bbffbadaa82277c05e2189360d94a484 
>   gradle/docker.gradle 79719740bc85fd1939d2d7859a7c78c0a87dd26e 
> 
> 
> Diff: https://reviews.apache.org/r/61562/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jens Deppe
> 
>

Re: Review Request 61562: GEODE-3423: Provide support for running parallel docker builds in Jenkins

2017-08-10 Thread Jens Deppe 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61562/
---

(Updated Aug. 10, 2017, 9:16 p.m.)


Review request for geode, Anthony Baker and Mark Bretl.


Changes
---

Switched to openjdk as base image


Repository: geode


Description
---

- Also cleaning up other Dockerfiles which are unused

Signed-off-by: Scott Jewell 


Diffs (updated)
-

  dev-tools/docker/base/Dockerfile 1cce0ddb0d29c9e188d27481c82123e357c5b685 
  dev-tools/docker/base/build-base-docker.sh 
9aab72c45d63c519874ad39aaf74c8236d9671ed 
  dev-tools/docker/compile/Dockerfile 6ae343a70eccf7cc4b303228118cee0b8579e79a 
  dev-tools/docker/compile/start-compile-docker.sh 
9059c5b5bbffbadaa82277c05e2189360d94a484 
  gradle/docker.gradle 79719740bc85fd1939d2d7859a7c78c0a87dd26e 


Diff: https://reviews.apache.org/r/61562/diff/2/

Changes: https://reviews.apache.org/r/61562/diff/1-2/


Testing
---


Thanks,

Jens Deppe

Re: Review Request 61562: GEODE-3423: Provide support for running parallel docker builds in Jenkins

2017-08-10 Thread Anthony Baker 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61562/#review182621
---




dev-tools/docker/base/Dockerfile
Line 27 (original), 27 (patched)


We can't embedd/redistribute the Oracle JDK due to licensing.  We should 
use the openjdk:8 as a base image (see https://hub.docker.com/_/openjdk/).


- Anthony Baker


On Aug. 10, 2017, 5:34 p.m., Jens Deppe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61562/
> ---
> 
> (Updated Aug. 10, 2017, 5:34 p.m.)
> 
> 
> Review request for geode, Anthony Baker and Mark Bretl.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> - Also cleaning up other Dockerfiles which are unused
> 
> Signed-off-by: Scott Jewell 
> 
> 
> Diffs
> -
> 
>   dev-tools/docker/base/Dockerfile 1cce0ddb0d29c9e188d27481c82123e357c5b685 
>   dev-tools/docker/base/build-base-docker.sh 
> 9aab72c45d63c519874ad39aaf74c8236d9671ed 
>   dev-tools/docker/compile/Dockerfile 
> 6ae343a70eccf7cc4b303228118cee0b8579e79a 
>   dev-tools/docker/compile/start-compile-docker.sh 
> 9059c5b5bbffbadaa82277c05e2189360d94a484 
>   gradle/docker.gradle 79719740bc85fd1939d2d7859a7c78c0a87dd26e 
> 
> 
> Diff: https://reviews.apache.org/r/61562/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jens Deppe
> 
>

Review Request 61562: GEODE-3423: Provide support for running parallel docker builds in Jenkins

2017-08-10 Thread Jens Deppe 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61562/
---

Review request for geode, Anthony Baker and Mark Bretl.


Repository: geode


Description
---

- Also cleaning up other Dockerfiles which are unused

Signed-off-by: Scott Jewell 


Diffs
-

  dev-tools/docker/base/Dockerfile 1cce0ddb0d29c9e188d27481c82123e357c5b685 
  dev-tools/docker/base/build-base-docker.sh 
9aab72c45d63c519874ad39aaf74c8236d9671ed 
  dev-tools/docker/compile/Dockerfile 6ae343a70eccf7cc4b303228118cee0b8579e79a 
  dev-tools/docker/compile/start-compile-docker.sh 
9059c5b5bbffbadaa82277c05e2189360d94a484 
  gradle/docker.gradle 79719740bc85fd1939d2d7859a7c78c0a87dd26e 


Diff: https://reviews.apache.org/r/61562/diff/1/


Testing
---


Thanks,

Jens Deppe