Review Request 52306: GEODE-1769: add the ignored exception

2016-09-27 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52306/ --- Review request for geode. Repository: geode Description --- GEODE-1769:

Re: Review Request 52269: GEODE-1659: put security properties in the cluster config and applied to all the members in the cluster.

2016-09-27 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52269/ --- (Updated Sept. 27, 2016, 5:25 p.m.) Review request for geode, Jared Stewart,

Re: Review Request 52306: GEODE-1769: add the ignored exception

2016-09-27 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52306/ --- (Updated Sept. 27, 2016, 6:13 p.m.) Review request for geode, Jared Stewart,

JUnit best practices #1

2016-09-27 Thread Kirk Lund
Some of the very basic best practices for JUnit: 1) never catch an unexpected exception Yes: public void myTest() throws Exception { doSomething(); validation(); } No: public void myTest() { try { doSomething(); validation(); } catch (Exception e) { fail(e.getMessage()); }

JUnit best practices #2

2016-09-27 Thread Kirk Lund
We are using Categories to aid in separating UnitTests, IntegrationTests, etc. A UnitTest is: /** * JUnit Test Category that specifies a test with very narrow and well defined * scope. Any complex dependencies and interactions are stubbed or mocked. * * A {@code UnitTest} should not do any