Review Request 53784: GEODE-1247: unable to stop server using http connection

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53784/ --- Review request for geode, Jens Deppe, John Blum, Kevin Duling, and Kirk Lund.

Re: Review Request 53784: GEODE-1247: unable to stop server using http connection

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53784/#review155927 --- Why would we move away from using Jackson in favor of our own

[GitHub] incubator-geode pull request #284: Improved cleanup for UITests

GitHub user jaredjstewart opened a pull request: https://github.com/apache/incubator-geode/pull/284 Improved cleanup for UITests UITests were failing when more than one was run because they all share a base class that was not properly cleaned up. You can merge this pull request

[GitHub] incubator-geode issue #285: GEODE-1617: Regions can be created with a variet...

Github user kirklund commented on the issue: https://github.com/apache/incubator-geode/pull/285 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-geode issue #285: GEODE-1617: Regions can be created with a variet...

Github user kirklund commented on the issue: https://github.com/apache/incubator-geode/pull/285 I reworded your commit message: ``` GEODE-1617: add test for region names Added comprehensive test to validate region names This closes #285 ``` --- If

[GitHub] incubator-geode pull request #284: Improved cleanup for UITests

Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/284 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: Review Request 53685: GEODE-1955: properly disconnect gfsh session so that it won't leave heartbeat thread around to pollute other tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53685/#review155926 --- Ship it! Ship It! - Kevin Duling On Nov. 14, 2016, 12:56

[GitHub] incubator-geode issue #283: GEODE-2098: Moved gfsh history file location fro...

Github user kirklund commented on the issue: https://github.com/apache/incubator-geode/pull/283 +1 looks ready to push to develop. Once it's committed on develop, then mark the Jira ticket Resolved (not Closed) and Fix Version(s) should say 1.1.0-incubating. When 1.1.0 is

[GitHub] incubator-geode pull request #285: GEODE-1617: Regions can be created with a...

Github user kirklund commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/285#discussion_r88075036 --- Diff: geode-core/src/test/java/org/apache/geode/cache/RegionNameValidationJUnitTest.java --- @@ -0,0 +1,75 @@ +package

[GitHub] incubator-geode issue #284: Improved cleanup for UITests

Github user jaredjstewart commented on the issue: https://github.com/apache/incubator-geode/pull/284 Precheckin passed (except for one failure in FlakyTest) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-geode pull request #285: GEODE-1617: Regions can be created with a...

GitHub user kjduling opened a pull request: https://github.com/apache/incubator-geode/pull/285 GEODE-1617: Regions can be created with a variety of characters that … …are unsupported Added comprehensive test to validate region names You can merge this pull request into

[GitHub] incubator-geode pull request #285: GEODE-1617: Regions can be created with a...

Github user kirklund commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/285#discussion_r88075502 --- Diff: geode-core/src/test/java/org/apache/geode/cache/RegionNameValidationJUnitTest.java --- @@ -0,0 +1,75 @@ +package

[GitHub] incubator-geode issue #283: GEODE-2098: Moved gfsh history file location fro...

Github user davinash commented on the issue: https://github.com/apache/incubator-geode/pull/283 Thanks @kirklund, @metatype I have followed the process from https://cwiki.apache.org/confluence/display/GEODE/Code+contributions Please do let me know if everything is correct. ---

Build failed in Jenkins: Geode-nightly #654

See Changes: [bschuchardt] GEODE-2074 [bschuchardt] reformatted recent commit with spotlessApply [klund] GEODE-2102: annotate flaky test with FlakyTest category [kmiller] GEODE-2105 Remove docs about log collection utility [kmiller]

[GitHub] incubator-geode pull request #285: GEODE-1617: Regions can be created with a...

Github user kjduling commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/285#discussion_r88080988 --- Diff: geode-core/src/test/java/org/apache/geode/cache/RegionNameValidationJUnitTest.java --- @@ -0,0 +1,75 @@ +package

[GitHub] incubator-geode pull request #285: GEODE-1617: Regions can be created with a...

Github user kjduling commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/285#discussion_r88081170 --- Diff: geode-core/src/test/java/org/apache/geode/cache/RegionNameValidationJUnitTest.java --- @@ -0,0 +1,75 @@ +package

[GitHub] incubator-geode issue #286: GEODE-2104: Fix parsing of options following --J

Github user jinmeiliao commented on the issue: https://github.com/apache/incubator-geode/pull/286 LGTM. build it and start up gfsh and play with it with different options and see if it's not having some side effects. After that I can pull this in. --- If your project is set up for

Re: Review Request 53784: GEODE-1247: unable to stop server using http connection

> On Nov. 15, 2016, 4:43 p.m., Kevin Duling wrote: > > Why would we move away from using Jackson in favor of our own JSON mapping > > code? Or is this a special case where we do some magic serialization we > > can't do via Jackson? > > Jinmei Liao wrote: > I tried using Jackson's

Re: Review Request 53784: GEODE-1247: unable to stop server using http connection

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53784/#review155978 --- Ship it! Ship It! - Kirk Lund On Nov. 15, 2016, 3:06 p.m.,

Re: gfsh start server with the --password option

I thought we had code that deals with redacting password in gfsh history, not sure why it's not in effect anymore. On Tue, Nov 15, 2016 at 2:27 PM, Swapnil Bawaskar wrote: > When you want to connect to a secure system you can choose not to use the > --password option at

Re: gfsh start server with the --password option

When you want to connect to a secure system you can choose not to use the --password option at which point you will be prompted to enter a username/password. e.g: gfsh>connect --locator=localhost[10334] Connecting to Locator at [host=localhost, port=10334] .. Connecting to Manager at

[GitHub] incubator-geode pull request #286: GEODE-2104: Fix parsing of options follow...

GitHub user jaredjstewart opened a pull request: https://github.com/apache/incubator-geode/pull/286 GEODE-2104: Fix parsing of options following --J You can merge this pull request into a Git repository by running: $ git pull https://github.com/jaredjstewart/incubator-geode

gfsh start server with the --password option

When specifying user name and password to use as authentication credentials with the gfsh start server command, the password is specified in the clear. I've added a note in the documentation to point this out, but specifying a password in this way leads to further ways the clear text password can

Re: gfsh start server with the --password option

There should be redaction in gfsh history. Maybe repeating the command is a case that wasn't fully covered? This is a bug we'll need to file and fix. Clear text in process string is probably not a bug. Users should implement a callback to provide the password instead of providing it as a system

[GitHub] incubator-geode issue #285: GEODE-1617: Regions can be created with a variet...

Github user kirklund commented on the issue: https://github.com/apache/incubator-geode/pull/285 Pushed to develop. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Re: Review Request 53784: GEODE-1247: unable to stop server using http connection

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53784/#review155990 --- Ship it! Ship It! - Kevin Duling On Nov. 15, 2016, 7:06

Re: gfsh start server with the --password option

Also, when doing a gfsh connect (not just start server) that specifies user and password on the command line, if a further command of gfsh history --file=historyfilename is executed, the user and password are written in clear text to the history file. On Tue, Nov 15, 2016 at 12:31 PM, Jinmei

[GitHub] incubator-geode pull request #286: GEODE-2104: Fix parsing of options follow...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/286 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: Review Request 53784: GEODE-1247: unable to stop server using http connection

> On Nov. 15, 2016, 4:43 p.m., Kevin Duling wrote: > > Why would we move away from using Jackson in favor of our own JSON mapping > > code? Or is this a special case where we do some magic serialization we > > can't do via Jackson? I tried using Jackson's converter, but it's giving errors

Re: Review Request 53784: GEODE-1247: unable to stop server using http connection

> On Nov. 15, 2016, 4:43 p.m., Kevin Duling wrote: > > Why would we move away from using Jackson in favor of our own JSON mapping > > code? Or is this a special case where we do some magic serialization we > > can't do via Jackson? > > Jinmei Liao wrote: > I tried using Jackson's