Re: [VOTE] RC2: Apache Geode (Incubating) first Milestone release - v1.0.0-incubating.M1

I found some more errors in the text files in the source distribution that were missed in the RC1 packages. Filed a JIRA on these doc issues, GEODE-874 (https://issues.apache.org/jira/browse/GEODE-874). Again we have gradlew instead of gradle, now in COMPILE.txt, RUNNING.txt,

Re: Reminder: include GEODE-xxx jira ticket # in commit message

+1 to Jake’s comment The number of “special cases” we’re talking about is pretty small compared to the overall number commits. Even for doc typos it’s not a problem to submit a JIRA when you see the problem. I’d be inclined to open one JIRA for however many typos or minor textual errors I find

Re: [GitHub] incubator-geode pull request: Updating README

With the bigtop gradlew script (see GEODE-826) shouldn’t the build command for “Geode in 5 Minutes” in the README.md be reverted to use ./gradlew instead of gradle? > On Feb 25, 2016, at 4:17 PM, Swapnil Bawaskar wrote: > > Please look at

Re: [VOTE] Apache Geode (Incubating) first Milestone release - v1.0.0-incubating.M1

I’m installing the M1 release from the source distribution (.tar.gz) and have noted a couple issues: 1. The gradle wrapper script, gradlew, is missing. I expected to find this script at the top level of the un-zipped archive, where it is when cloning the incubator-geode git repo. Building with

Re: [VOTE] Apache Geode (Incubating) first Milestone release - v1.0.0-incubating.M1

? Because of these, none of the build instructions in the source distribution are correct. Ken > On Jan 21, 2016, at 4:14 PM, Kenneth Howe <kh...@pivotal.io> wrote: > > I’m installing the M1 release from the source distribution (.tar.gz) and have > noted a couple > issues: >

Re: [VOTE] Apache Geode (Incubating) first Milestone release - v1.0.0-incubating.M1

>> gemfire-assembly/build.gradle's distribution target so may be an easy fix if >> we go that route. >> >> - Nitin >> >> >> From: Kenneth Howe <kh...@pivotal.io> >> Sent: Thursday, January 21, 2016 4:14 PM >> To: dev@geode.incuba

Re: Lambdas in dunits! Time to remove string invoke?

+1 Ken

Re: GEODE-52 Remove @author tags from Java source

+1 Ken > On Feb 17, 2016, at 1:35 PM, Anthony Baker wrote: > > +1 > > The ASF policy is well known [1] and I think @author information is no longer > helpful in any case. > > Anthony > > [1] >

Re: Conributors.md

+1 to provide a link on the Geode Community web page to the cwiki How to Contribute, with the cwiki being the one place to keep the info current. Ken > On Mar 1, 2016, at 10:57 AM, Dave Barnes wrote: > > +1 to providing a more obvious path to the "how to contribute" info.

Re: Adding GC logging for DUnit testing

+1 Sounds like a good idea, at least for DUnits and integration tests. Ken > On Mar 28, 2016, at 3:19 PM, Udo Kohlmeyer wrote: > > +1 > > If we suspect GC to be playing a role here, then I think we should. > > --Udo > > On 29/03/2016 8:52 am, Kirk Lund wrote: >> +1

Re: Can we close GEODE-36 ? (Gfsh renaming)

+1 > On Mar 16, 2016, at 9:57 AM, Dan Smith wrote: > > +1 to gfsh, and +1 to William's ascii art! > > -Dan > > > > > > On Wed, Mar 16, 2016 at 9:32 AM, Jens Deppe wrote: > >> +1 >> >> On Wed, Mar 16, 2016 at 8:58 AM, Gregory Chase

Re: @since tags in our javadocs - old gemfire vs. geode versions

+1 to “gemFire x.y.z” Adding the GemFire makes it obvious where the feature came from, no inference required as would happen if we left just a version number for old @since annotations. Ken > On Apr 25, 2016, at 4:39 PM, Kirk Lund wrote: > > +1 for @since Geode 1.0.0 > >

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating.M3 - RC5

Some clarification please - this is the “fourth release candidate” but it’s named …M3.RC5? Ken > On Jul 26, 2016, at 12:16 PM, William Markito wrote: > > All, > > This is the fourth release candidate Apache Geode, version > 1.0.0-incubating.M3. > > We're including the

Re: Renaming GeodePermission

+1 to ResourcePermission Based on your description, this sounds like a better fit for what it does than the more general Permission. > On Jul 27, 2016, at 10:10 AM, Darrel Schneider wrote: > > +1 for ResourcePermission > > On Wed, Jul 27, 2016 at 9:54 AM, Kirk Lund

Re: Flaky tests failing with BindException

Sounds like it would improve the results, but not necessarily fix, BindException @Flaky test failures. Even after n number of retries we’d still not be sure of finding the requested port available. Has any testing been done to find a point of diminishing returns on increasing the retry count?

Re: Proposal - Fail cache creation on persistent PR colocation misconfiguration

dynamically? I believe that could be a >> valid >>> case. The right thing to do is recover what you can, when you can. Not to >>> make parent recovery dependant on its children. >>> >>> -- >>> Mike Stolz >>> Principal Engineer - Gemfire

Gfsh Command enhancement - show missing-disk-stores

GEODE-1128 requests the addition of missing colocated region information to the gfsh show missing-disk-stores command. This is of course doable, however with additional information not directly related to disk stores, the command name would be

Re: git commit messages

Agree with Kirk, 50 chars is really short by the time you use up the first 12 characters for the Jira tag. If we’re going to have a guideline, I’d rather be longer - somewhat arbitrarily I’d probably make it 20-30 chars more. It’s been a long time since text listings were intended to fit on a

Re: git commit messages

ader ignores later stats >>>>resource with same name as closed stats resource >>>> >>>>* ResourceInstTest verifies the underlying issue and fix in >>>>StatArchiveReader.ResourceInst.equals and the fix >>>> >>>>

Re: Limiting scope for Geode 1.0

+1 > On Sep 29, 2016, at 2:31 PM, Jacob Barrett wrote: > > +1 for creating branch now to prevent feature creep. > > On Thu, Sep 29, 2016 at 2:10 PM Kirk Lund wrote: > >> I think we should propose creating that release branch sooner (now?) so we >> can

Re: Tweaking the IntelliJ and Eclipse formatters

1) +1 - How long were you proposing Kirk? I’d suggest something like 120-130. Regardless of the length chosen we could end up with anomaly Darrel pointed out with a comment at the end of a long line. In these cases it’s probably better to put the comment on a separate line. 2) +1 3) +1 4) +1

Re: Coding practices/standards

kid desc limit 10", >>>>>>>>>> - >>>>>>>>>> - }; >>>>>>>>>> +"SELECT ID, description, createTime, pkid FROM >>>> /portfolio1 >>>>>>> pf1 >>>&g

Re: Gfsh Parsing

Thanks! A problem for me with the Spring Shell output is the lack of the command syntax summary. Ken > On Nov 4, 2016, at 8:38 AM, Jinmei Liao wrote: > > --resend with attachments > > We have several jira issues related to gfsh parsing (GEODE-1598, GEODE-1912). > After

Re: Gfsh Parsing

Jinmei, Your examples didn’t come through the mail Ken > On Nov 4, 2016, at 8:27 AM, Jinmei Liao wrote: > > We have several jira issues related to gfsh parsing (GEODE-1598, GEODE-1912). > After spending some time understanding how the parsing works, I found out we > have

Re: Backwards compatibility for 1.1

+1 to Dan +1 to Bruce - the distributedTest extensions for backward compatibility would great > On Nov 1, 2016, at 4:11 PM, Bruce Schuchardt wrote: > > +1 > > I still have the backward-compatibility distributedTest extensions that I > could contribute. The extension

Re: Coding practices/standards

Agree with Mark, this has to work with 0 errors before it would be useful in precheckin. I think I could live with an additional 17 seconds most of the time for running the spotlessCheck as suggested. Jared, Is that 17 seconds running locally on your laptop or on a more capable machine? Ken