Github user davinash commented on the issue:
https://github.com/apache/incubator-geode/pull/218
Thanks @kirklund for initial review. I have updated the PR with addition of
Tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user davinash opened a pull request:
https://github.com/apache/incubator-geode/pull/218
GEODE-1682: Adding options for starting Geode REST API using gfsh
GEODE-1682:
- Added option in gfsh to start REST `start-rest-api`
- Added option for http service port `http
Github user davinash commented on the issue:
https://github.com/apache/incubator-geode/pull/218
what is the next step for merge, I do not see that option. May be I am
missing something !!!
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user davinash opened a pull request:
https://github.com/apache/incubator-geode/pull/278
Feature/geode 1896 unable to specify a PartitionResolver in gfsh
GEODE-1896: Added a argument in Create Region to specify Partition Resolver.
You can merge this pull request
Github user davinash commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/278#discussion_r86684704
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java
---
@@ -907,6 +903,31
Github user davinash commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/278#discussion_r86684707
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java
---
@@ -907,6 +903,31
Github user davinash commented on the issue:
https://github.com/apache/incubator-geode/pull/278
Thanks @kirklund and @upthewaterspout for details review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user davinash commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/278#discussion_r86684713
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java
---
@@ -907,6 +903,31
Github user davinash commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/278#discussion_r86684717
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/RegionCreateFunction.java
---
@@ -405,9 +408,48 @@ private
Github user davinash commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/278#discussion_r86684743
--- Diff:
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java
---
@@ -1091,6
Github user davinash commented on the issue:
https://github.com/apache/incubator-geode/pull/278
Anything else pending for this PR to merge from my side ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user davinash opened a pull request:
https://github.com/apache/incubator-geode/pull/283
GEODE-2098: Moved gfsh history file location from .gemfire to .geode
Made the code changes and added a test for the same.
Following Test is failing with precheckin, but works fine
Github user davinash commented on the issue:
https://github.com/apache/incubator-geode/pull/283
Thanks @kirklund @metatype @upthewaterspout. Do I need to mark the JIRA for
release notes ? If not I will merge this PR, please let me know.
---
If your project is set up for it, you can
Github user davinash commented on the issue:
https://github.com/apache/incubator-geode/pull/283
@kirklund
What OS does DiskSpaceLimitIntegrationTest fail on for you?
[ Avinash ] Linux
---
If your project is set up for it, you can reply to this email and have your
reply
Github user davinash commented on the issue:
https://github.com/apache/incubator-geode/pull/283
Thanks @kirklund, @metatype I have followed the process from
https://cwiki.apache.org/confluence/display/GEODE/Code+contributions
Please do let me know if everything is correct
Github user davinash commented on the issue:
https://github.com/apache/incubator-geode/pull/278
Yes but I guess I have no write access to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user davinash commented on the issue:
https://github.com/apache/incubator-geode/pull/278
@metatype Please help to merge this PR this time, from next I will
following process mentioned at
https://cwiki.apache.org/confluence/display/GEODE/Code+contributions
---
If your project
17 matches
Mail list logo
