[GitHub] incubator-geode issue #278: Feature/geode 1896 unable to specify a Partition...
Github user metatype commented on the issue: https://github.com/apache/incubator-geode/pull/278 @davinash I merged the PR. Next time make sure to prefix your commit message with "Geode-NNN" so the commits are linked to the JIRA issue. I also marked the issue as resolved. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode issue #278: Feature/geode 1896 unable to specify a Partition...
Github user davinash commented on the issue: https://github.com/apache/incubator-geode/pull/278 @metatype Please help to merge this PR this time, from next I will following process mentioned at https://cwiki.apache.org/confluence/display/GEODE/Code+contributions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode issue #278: Feature/geode 1896 unable to specify a Partition...
Github user metatype commented on the issue: https://github.com/apache/incubator-geode/pull/278 As a committer (https://people.apache.org/phonebook.html?uid=adongre) you should have write access. If that isn't working send a note to priv...@geode.incubator.apache.org and we will help sort that out. If you'd have someone else merge the PR, let me know and I will follow the steps at https://cwiki.apache.org/confluence/display/GEODE/Code+contributions. Cheers! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode issue #278: Feature/geode 1896 unable to specify a Partition...
Github user davinash commented on the issue: https://github.com/apache/incubator-geode/pull/278 Yes but I guess I have no write access to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode issue #278: Feature/geode 1896 unable to specify a Partition...
Github user metatype commented on the issue: https://github.com/apache/incubator-geode/pull/278 @davinash Thanks for the contribution! Looks like the review is wrapped up from the above comments. If you need help pushing the changes, let me know. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode issue #278: Feature/geode 1896 unable to specify a Partition...
Github user davinash commented on the issue: https://github.com/apache/incubator-geode/pull/278 Anything else pending for this PR to merge from my side ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode issue #278: Feature/geode 1896 unable to specify a Partition...
Github user upthewaterspout commented on the issue: https://github.com/apache/incubator-geode/pull/278 +1 Looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode issue #278: Feature/geode 1896 unable to specify a Partition...
Github user davinash commented on the issue: https://github.com/apache/incubator-geode/pull/278 Thanks @kirklund and @upthewaterspout for details review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode issue #278: Feature/geode 1896 unable to specify a Partition...
Github user upthewaterspout commented on the issue: https://github.com/apache/incubator-geode/pull/278 +1 Looks good to me after addressing Kirk's comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
