Re: GEODE-37 (Hold your checkins in develop)

2016-09-19 Thread Anthony Baker
Yea, the geode-pulse src is still com.vmware.gemfire too. Anthony > On Sep 19, 2016, at 1:10 PM, Kirk Lund wrote: > > Hitesh and I just noticed some io.pivotal.geode packages in > geode-spark-connector that probably need to be converted to > org.apache.geode. > > -Kirk > > > On Thu, Sep 15,

Re: GEODE-37 (Hold your checkins in develop)

2016-09-19 Thread Kirk Lund
Hitesh and I just noticed some io.pivotal.geode packages in geode-spark-connector that probably need to be converted to org.apache.geode. -Kirk On Thu, Sep 15, 2016 at 4:27 PM, Kirk Lund wrote: > I decided to go ahead and scrub real domains and machine names from > LauncherLifecycleCommandsJUn

Re: GEODE-37 (Hold your checkins in develop)

2016-09-15 Thread Kirk Lund
I decided to go ahead and scrub real domains and machine names from LauncherLifecycleCommandsJUnitTest. This way it won't give false positive hits when grepping for gemstone or vmware. Completed: #6) replace real domains and machines with fake names for unit test [commit 8341d7] Thanks, Kirk O

Re: GEODE-37 (Hold your checkins in develop)

2016-09-15 Thread Anthony Baker
I found a lot of references to gemstone.com as well. At some point we’ll need to update and change those url’s. Anthony > On Sep 15, 2016, at 4:04 PM, Kirk Lund wrote: > > I completed some additional cleanup for GEODE-37: > > #1) Update IDE formatters [commit 17a434] > #3) log4j [commit e13

Re: GEODE-37 (Hold your checkins in develop)

2016-09-15 Thread Kirk Lund
I completed some additional cleanup for GEODE-37: #1) Update IDE formatters [commit 17a434] #3) log4j [commit e13875] #5) log4j portion [commit e13875] #5) security portion [commit ef39b3] #6) weird stuff does not require any change -- this is a UnitTest that has a string host name but does nothin

Re: GEODE-37 (Hold your checkins in develop)

2016-09-15 Thread Kirk Lund
Unless someone objects or really wants to work these, I will take these: 1) Update IDE formatters 3) log4j partial 5) only the log4j and security pieces 6) weird stuff -Kirk

Re: GEODE-37 (Hold your checkins in develop)

2016-09-15 Thread Anthony Baker
lowing way.. > git log --follow > ./geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java > > Thanks.Hitesh > > > From: Anthony Baker > To: dev@geode.incubator.apache.org > Sent: Wednesday, September 14, 2016 7:02 PM > Subject: Re: GEODE-37

Re: GEODE-37 (Hold your checkins in develop)

2016-09-14 Thread Hitesh Khamesra
eImpl.java Thanks.Hitesh From: Anthony Baker To: dev@geode.incubator.apache.org Sent: Wednesday, September 14, 2016 7:02 PM Subject: Re: GEODE-37 (Hold your checkins in develop) Thanks Hitesh!  Are your changes available on a feature branch where we could review and comment? Anthony

Re: GEODE-37 (Hold your checkins in develop)

2016-09-14 Thread Anthony Baker
Thanks Hitesh! Are your changes available on a feature branch where we could review and comment? Anthony > On Sep 13, 2016, at 3:30 PM, Hitesh Khamesra > wrote: > > As part of GEODE-37, I am changing com.gemstone.gemfire package name to > org.apache.geode. > Thus I request you to hold your