Re: Gfsh Parsing

2016-11-04 Thread Dan Smith
+1 for simplifying the parsing and using spring shell. -Dan On Fri, Nov 4, 2016 at 1:42 PM, Real Wes wrote: > That would be a really good implementation since it would keep production > code from relying on the formatting of the GFSH return message. If you did >

Re: Gfsh Parsing

2016-11-04 Thread Real Wes
That would be a really good implementation since it would keep production code from relying on the formatting of the GFSH return message. If you did —output=json, then the call to the GfshParser could possibly involve non-internal classes, which would be even nicer. > On Nov 4, 2016, at 4:31

Re: Gfsh Parsing

2016-11-04 Thread Anthony Baker
Wes, I think it would be interesting if we added a new option ‘--output=json’ to better handle the use case you described. Then you could pipe the gfsh command through a json parser like jq. Anthony > On Nov 4, 2016, at 9:51 AM, Real Wes wrote: > > I call the GFSH

Re: Gfsh Parsing

2016-11-04 Thread Kevin Duling
+1 On Fri, Nov 4, 2016 at 11:14 AM, Jens Deppe wrote: > One of the 'features' of the current output is for the text to be able to > indicate whether the command is currently available or not. Personally I > don't think there's much value to that. If necessary, more

Re: Gfsh Parsing

2016-11-04 Thread Jens Deppe
One of the 'features' of the current output is for the text to be able to indicate whether the command is currently available or not. Personally I don't think there's much value to that. If necessary, more information could always be added to the help text. Definitely +1 for removing code

Re: Gfsh Parsing

2016-11-04 Thread Jared Stewart
Huge +1 to the idea of simplifying Gfsh parsing. I find the green help text from Spring Shell too be less readable then the black text from JoptSimple, but I assume we can configure that to our choosing. > On Nov 4, 2016, at 10:05 AM, Jinmei Liao wrote: > > This is a good

Re: Gfsh Parsing

2016-11-04 Thread Jinmei Liao
This is a good idea. I'll reach out to find it out. Thanks! On Fri, Nov 4, 2016 at 9:48 AM, Michael Stolz wrote: > Can we suggest improvements to the Spring help capabilities? The Spring > community tends to be very responsive to good suggestions. > > -- > Mike Stolz >

Re: Gfsh Parsing

2016-11-04 Thread Jinmei Liao
Hi, it would be nice to know what kind of GFSH Parser api you are using? Are you specifically using GfshParser or just the execution result? On Fri, Nov 4, 2016 at 9:51 AM, Real Wes wrote: > I call the GFSH Parser from code and rely on the formatting of the return >

Re: Gfsh Parsing

2016-11-04 Thread Real Wes
I call the GFSH Parser from code and rely on the formatting of the return message to determine the response. So I’d like to see that code as encapsulated in one place. > On Nov 4, 2016, at 11:38 AM, Jinmei Liao wrote: > > > We have several jira issues related to gfsh

Re: Gfsh Parsing

2016-11-04 Thread Michael Stolz
Can we suggest improvements to the Spring help capabilities? The Spring community tends to be very responsive to good suggestions. -- Mike Stolz Principal Engineer - Gemfire Product Manager Mobile: 631-835-4771 On Nov 4, 2016 8:27 AM, "Jinmei Liao" wrote: > We have several

Re: Gfsh Parsing

2016-11-04 Thread Kenneth Howe
Thanks! A problem for me with the Spring Shell output is the lack of the command syntax summary. Ken > On Nov 4, 2016, at 8:38 AM, Jinmei Liao wrote: > > --resend with attachments > > We have several jira issues related to gfsh parsing (GEODE-1598, GEODE-1912). > After

Re: Gfsh Parsing

2016-11-04 Thread Kenneth Howe
Jinmei, Your examples didn’t come through the mail Ken > On Nov 4, 2016, at 8:27 AM, Jinmei Liao wrote: > > We have several jira issues related to gfsh parsing (GEODE-1598, GEODE-1912). > After spending some time understanding how the parsing works, I found out we > have