Re: Review Request 52994: GEODE-1959: prompt for password when starting a server if username is specified
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52994/#review153314 --- Ship it! Ship It! - Kirk Lund On Oct. 19, 2016, 12:11 a.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52994/ > --- > > (Updated Oct. 19, 2016, 12:11 a.m.) > > > Review request for geode, John Blum, Kevin Duling, and Kirk Lund. > > > Repository: geode > > > Description > --- > > GEODE-1959: prompt for password when starting a server if username is > specified > > > Diffs > - > > > geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsDUnitTest.java > 490e309dad7ee5100a2c39fc8ec3b13bc9c30737 > geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java > a3d3845bf218cd04500a336e65d6143277433f7f > > geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java > 89a9a37d917eb29eddd12676621417c5e3eadd25 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java > 4ffe08271d0e06919f45769f200b71ef0978d879 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ShellCommands.java > 792a8abed97dcff8c15f678a4cd12e0d1656568d > > geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java > 51887cf500f6aed00f79c10b22f708b03a13d178 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/Gfsh.java > 467682d9b931e0bdd03c8dd3a739b686a6ace1c3 > > geode-core/src/test/resources/org/apache/geode/management/internal/cli/commands/golden-help-offline.properties > 28083f3058655b46c027c23dd64225f449ddb84e > > Diff: https://reviews.apache.org/r/52994/diff/ > > > Testing > --- > > precheckin running > > > Thanks, > > Jinmei Liao > >
Re: Review Request 52994: GEODE-1959: prompt for password when starting a server if username is specified
> On Oct. 18, 2016, 11:28 p.m., Kirk Lund wrote: > > I think you may need to find some API to ask GFSH if it's running in > > interactive mode or script mode. Then if it's in script mode, it should > > fail instead of prompting. John Blum might be a good person to ask if they > > know how to check interactive vs script mode. He would be a good reviewer > > for this changeset in general. I believe the gfsh.readPassword and gfsh.readText already does that. I just moved these two private method in ShellCommands.java into Gfsh and make that public so that my LauncherLifecycleCommands can use it as well. I will add John to the reviewer as well. - Jinmei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52994/#review153212 --- On Oct. 19, 2016, 12:11 a.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52994/ > --- > > (Updated Oct. 19, 2016, 12:11 a.m.) > > > Review request for geode, John Blum, Kevin Duling, and Kirk Lund. > > > Repository: geode > > > Description > --- > > GEODE-1959: prompt for password when starting a server if username is > specified > > > Diffs > - > > > geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsDUnitTest.java > 490e309dad7ee5100a2c39fc8ec3b13bc9c30737 > geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java > a3d3845bf218cd04500a336e65d6143277433f7f > > geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java > 89a9a37d917eb29eddd12676621417c5e3eadd25 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java > 4ffe08271d0e06919f45769f200b71ef0978d879 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ShellCommands.java > 792a8abed97dcff8c15f678a4cd12e0d1656568d > > geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java > 51887cf500f6aed00f79c10b22f708b03a13d178 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/Gfsh.java > 467682d9b931e0bdd03c8dd3a739b686a6ace1c3 > > geode-core/src/test/resources/org/apache/geode/management/internal/cli/commands/golden-help-offline.properties > 28083f3058655b46c027c23dd64225f449ddb84e > > Diff: https://reviews.apache.org/r/52994/diff/ > > > Testing > --- > > precheckin running > > > Thanks, > > Jinmei Liao > >
Re: Review Request 52994: GEODE-1959: prompt for password when starting a server if username is specified
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52994/#review153212 --- I think you may need to find some API to ask GFSH if it's running in interactive mode or script mode. Then if it's in script mode, it should fail instead of prompting. John Blum might be a good person to ask if they know how to check interactive vs script mode. He would be a good reviewer for this changeset in general. - Kirk Lund On Oct. 18, 2016, 11:09 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52994/ > --- > > (Updated Oct. 18, 2016, 11:09 p.m.) > > > Review request for geode, Kevin Duling and Kirk Lund. > > > Repository: geode > > > Description > --- > > GEODE-1959: prompt for password when starting a server if username is > specified > > > Diffs > - > > > geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsDUnitTest.java > 490e309dad7ee5100a2c39fc8ec3b13bc9c30737 > geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java > a3d3845bf218cd04500a336e65d6143277433f7f > > geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java > 89a9a37d917eb29eddd12676621417c5e3eadd25 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java > 4ffe08271d0e06919f45769f200b71ef0978d879 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ShellCommands.java > 792a8abed97dcff8c15f678a4cd12e0d1656568d > > geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java > 51887cf500f6aed00f79c10b22f708b03a13d178 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/Gfsh.java > 467682d9b931e0bdd03c8dd3a739b686a6ace1c3 > > geode-core/src/test/resources/org/apache/geode/management/internal/cli/commands/golden-help-offline.properties > 28083f3058655b46c027c23dd64225f449ddb84e > > Diff: https://reviews.apache.org/r/52994/diff/ > > > Testing > --- > > precheckin running > > > Thanks, > > Jinmei Liao > >
Re: Review Request 52994: GEODE-1959: prompt for password when starting a server if username is specified
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52994/ --- (Updated Oct. 18, 2016, 11:09 p.m.) Review request for geode, Kevin Duling and Kirk Lund. Changes --- making error messages more precise Repository: geode Description --- GEODE-1959: prompt for password when starting a server if username is specified Diffs (updated) - geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsDUnitTest.java 490e309dad7ee5100a2c39fc8ec3b13bc9c30737 geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java a3d3845bf218cd04500a336e65d6143277433f7f geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java 89a9a37d917eb29eddd12676621417c5e3eadd25 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java 4ffe08271d0e06919f45769f200b71ef0978d879 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ShellCommands.java 792a8abed97dcff8c15f678a4cd12e0d1656568d geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java 51887cf500f6aed00f79c10b22f708b03a13d178 geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/Gfsh.java 467682d9b931e0bdd03c8dd3a739b686a6ace1c3 geode-core/src/test/resources/org/apache/geode/management/internal/cli/commands/golden-help-offline.properties 28083f3058655b46c027c23dd64225f449ddb84e Diff: https://reviews.apache.org/r/52994/diff/ Testing --- precheckin running Thanks, Jinmei Liao
Re: Review Request 52994: GEODE-1959: prompt for password when starting a server if username is specified
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52994/#review153173 --- Ship it! Ship It! - Kevin Duling On Oct. 18, 2016, 1:28 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52994/ > --- > > (Updated Oct. 18, 2016, 1:28 p.m.) > > > Review request for geode, Kevin Duling and Kirk Lund. > > > Repository: geode > > > Description > --- > > GEODE-1959: prompt for password when starting a server if username is > specified > > > Diffs > - > > > geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsDUnitTest.java > 490e309dad7ee5100a2c39fc8ec3b13bc9c30737 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java > 4ffe08271d0e06919f45769f200b71ef0978d879 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ShellCommands.java > 792a8abed97dcff8c15f678a4cd12e0d1656568d > > geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java > 51887cf500f6aed00f79c10b22f708b03a13d178 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/Gfsh.java > 467682d9b931e0bdd03c8dd3a739b686a6ace1c3 > > geode-core/src/test/resources/org/apache/geode/management/internal/cli/commands/golden-help-offline.properties > 28083f3058655b46c027c23dd64225f449ddb84e > > Diff: https://reviews.apache.org/r/52994/diff/ > > > Testing > --- > > precheckin running > > > Thanks, > > Jinmei Liao > >
