Re: Review Request 53750: GEODE-2110 Add gfsh start server user and password options

2016-11-14 Thread Jinmei Liao

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53750/#review155879
---


Ship it!




Ship It!

- Jinmei Liao


On Nov. 15, 2016, 1:55 a.m., Karen Miller wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53750/
> ---
> 
> (Updated Nov. 15, 2016, 1:55 a.m.)
> 
> 
> Review request for geode, Dave Barnes, Jinmei Liao, and Joey McAllister.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Modifies gfsh start server command reference page to add
> the two missing options: --user and --password
> 
> 
> Diffs
> -
> 
>   geode-docs/tools_modules/gfsh/command-pages/start.html.md.erb 
> 06dfce4d6a96f64295a069a50d79d55b87a1da67 
> 
> Diff: https://reviews.apache.org/r/53750/diff/
> 
> 
> Testing
> ---
> 
> 1. bundle exec bookbinder bind local   finds no broken links
> 
> 2. gradle rat check passes
> 
> 
> Thanks,
> 
> Karen Miller
> 
>



Re: Review Request 53750: GEODE-2110 Add gfsh start server user and password options

2016-11-14 Thread Dave Barnes

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53750/#review155877
---


Ship it!




Ship It!

- Dave Barnes


On Nov. 15, 2016, 1:55 a.m., Karen Miller wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53750/
> ---
> 
> (Updated Nov. 15, 2016, 1:55 a.m.)
> 
> 
> Review request for geode, Dave Barnes, Jinmei Liao, and Joey McAllister.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Modifies gfsh start server command reference page to add
> the two missing options: --user and --password
> 
> 
> Diffs
> -
> 
>   geode-docs/tools_modules/gfsh/command-pages/start.html.md.erb 
> 06dfce4d6a96f64295a069a50d79d55b87a1da67 
> 
> Diff: https://reviews.apache.org/r/53750/diff/
> 
> 
> Testing
> ---
> 
> 1. bundle exec bookbinder bind local   finds no broken links
> 
> 2. gradle rat check passes
> 
> 
> Thanks,
> 
> Karen Miller
> 
>